Skip to content

refactor: add booth typings and remove any #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kim-song-jun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: add booth typings and remove any #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/booths/BoothDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { useNavigate } from 'react-router-dom';
import { useParams } from 'react-router-dom';
import { useUserStore } from '@/stores/logins/userStore';
import FestinoLogo from '@/components/icons/FestinoLogo';
import { Menu } from '@/types/booths/booth.types';

const BoothDetailPage: React.FC = () => {
const { reset, init, boothInfo, menuList, updateBoothInfo, updateMenuList } = useBoothDetail();
Expand Down Expand Up @@ -44,7 +45,7 @@ const BoothDetailPage: React.FC = () => {
scrollImage('right');
};

const handleClickSoldOut = async (menu: any) => {
const handleClickSoldOut = async (menu: Menu) => {
if (isBoothOwner) {
try {
const response = await api.put('/admin/menu/sold-out', {
Expand Down
4 changes: 2 additions & 2 deletions src/pages/mobiles/MobileRservePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const MobileReservePage: React.FC = () => {
useEffect(() => {
const init = async () => {
await getAllBoothList();
const filtered = boothList.filter((booth: any) => booth?.isReservation);
const filtered = (boothList as Booth[]).filter((booth: Booth) => booth?.isReservation);
setReserveBoothList(filtered);

if (isAdmin) {
Expand All @@ -54,7 +54,7 @@ const MobileReservePage: React.FC = () => {
setSelectedBooth(filtered[0]);
} else {
if (userOwnBoothId) {
const found = filtered.find((booth: any) => booth.boothId === userOwnBoothId);
const found = filtered.find((booth: Booth) => booth.boothId === userOwnBoothId);
if (found) {
setSelectedBooth(found);
setBoothInfo(found);
Expand Down
6 changes: 4 additions & 2 deletions src/pages/orders/OrderRealTimePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import IconNotFound from '@/components/icons/IconNotFound';
import { cloneDeep, isEqual } from 'lodash';
import OrderCard from '@/components/orders/OrderCard';
import { useNowOrderStore } from '@/stores/orders/nowOrder';
import { WaitDepositOrder } from '@/types/orders/order.types';
import { WaitDepositOrder, CookingMenu, FinishOrder } from '@/types/orders/order.types';

const OrderRealTimePage: React.FC = () => {
const { boothId } = useTableStatusOrder();
Expand Down Expand Up @@ -58,7 +58,9 @@ const OrderRealTimePage: React.FC = () => {
};
}, [boothId, nowDate]);

const renderCardSection = (type: string, data: any[]) => {
type OrderData = WaitDepositOrder | CookingMenu | FinishOrder;

const renderCardSection = (type: string, data: OrderData[]) => {
const bgMap: Record<string, string> = {
ready: 'bg-danger-600-light-5',
cooking: 'bg-primary-600-light-5',
Expand Down
2 changes: 1 addition & 1 deletion src/types/booths/booth.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export interface BoothInfo {
openTime: string;
closeTime: string;
boothIntro: string;
boothImage: any[];
boothImage: string[];
location: string;
isCall: boolean;
isOpen: boolean;
Expand Down