Add function to remove unit from squad#5256
Merged
Merged
Conversation
myk002
reviewed
Feb 7, 2025
myk002
reviewed
Feb 7, 2025
myk002
reviewed
Feb 7, 2025
myk002
left a comment
Member
There was a problem hiding this comment.
LGTM -- should I remove the "draft" PR status?
Contributor
Author
Sure, thank you! Do you think that the function should return a value? If it returns false at any point after changing game state it would likely be a bug that leaves game state inconsistent, so maybe I should just have it be void and expect that it works fine? |
Member
That's a good point. I think that it should return false if the unit is not in a squad or other preconditions fail. I think it should return true if it has updated all the state that is feasible to update. If some dependent data structure cannot be found, I think it can skip it and still return true. |
myk002
approved these changes
Feb 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally intended to be used in a now-cancelled Lua script feature, but figured it may be useful for those dabbling in military matters.