Apply suggestions from code review

Co-authored-by: Nicholas McDaniel <[email protected]>
DFHack · Feb 11, 2025 · 76b75c0 · 76b75c0
1 parent 376e4f3
commit 76b75c0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/GUI.cpp b/GUI.cpp
@@ -510,7 +510,7 @@ namespace
     void drawSelectionCursor(WorldSegment* segment)
     {
         auto& ssConfig = stonesenseState.ssConfig;
-        df::coord& selection = segment->segState.dfSelection;
+        df::coord selection = segment->segState.dfSelection;
         if ((selection.x != -30000 && ssConfig.config.follow_DFcursor)) {
             drawCursorAt(segment, selection, uiColor(3));
         }
@@ -521,7 +521,7 @@ namespace
 
     void drawDebugCursor(WorldSegment* segment)
     {
-        df::coord& cursor = segment->segState.dfCursor;
+        df::coord cursor = segment->segState.dfCursor;
         drawCursorAt(segment, cursor, uiColor(2));
     }
 

diff --git a/SpriteObjects.cpp b/SpriteObjects.cpp
@@ -996,7 +996,7 @@ void c_sprite::assemble_world_offset(int x, int y, int z, int plateoffset, Tile
         int16_t drawx = x;
         int16_t drawy = y;
         int16_t drawz = z; //- ownerSegment->sizez + 1;
-        df::coord drawcoord(drawx, drawx, drawz);
+        df::coord drawcoord(drawx, drawy, drawz);
 
 
         b->ownerSegment->CorrectTileForSegmentOffset(drawcoord);

diff --git a/Tile.cpp b/Tile.cpp
@@ -219,7 +219,7 @@ void Tile::GetDrawLocation(int32_t& drawx, int32_t& drawy)
     drawx = x;
     drawy = y;
     int32_t drawz = z;
-    df::coord drawcoord(drawx, drawx, drawz);
+    df::coord drawcoord(drawx, drawy, drawz);
 
 
     ownerSegment->CorrectTileForSegmentOffset(drawcoord);