-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor out Crd3D and Crd2D to use df::coord and df::coord2d #207
Refactor out Crd3D and Crd2D to use df::coord and df::coord2d #207
Conversation
} | ||
|
||
Crd2D LocalTileToScreen(int32_t x, int32_t y, int32_t z) | ||
df::coord2d LocalTileToScreen(int16_t x, int16_t y, int16_t z) | ||
{ | ||
pointToScreen((int*)&x, (int*)&y, z); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is casting a int16_t*
to int*
.
Co-authored-by: Nicholas McDaniel <[email protected]>
I'm going to stand here in opposition to the entire idea behind this PR. I would instead recommend keeping these types mostly as is, and add the required constructors and cast operators to the |
im completely in agreement with this. this PR broke more than it fixed. |
This is not gonna happen |
Fixes #205