Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,34 @@ jobs:
--fail-under-functions 80
--fail-under-regions 80

# REGRESSION GATE (deploy run 32498562051): the arm64 cross-compile that deploy.yml performs was
# not exercised anywhere in CI, so a toolchain drift broke it silently and was only discovered
# after merge, at deploy time, with the pointer already frozen. Rust 1.98.0 began emitting
# `-Wl,--fix-cortex-a53-843419` for aarch64-unknown-linux-gnu; zig's linker rejects the flag, so
# every `cargo lambda build --arm64` failed to link.
#
# This job runs the SAME build deploy.yml runs, minus AWS: if the Lambda cannot be cross-compiled,
# the PR is red instead of the deploy. It must stay byte-for-byte in step with deploy.yml's build
# (same toolchain, same pinned cargo-lambda + ziglang, same targets and features).
lambda-build:
name: arm64 lambda cross-compile (mirrors deploy.yml)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
with:
toolchain: stable
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
- name: install cargo-lambda + zig (arm64 cross-compile)
run: pip install "cargo-lambda==1.9.2" "ziglang==0.16.0"
- name: build both lambda zips (arm64)
run: |
set -euo pipefail
cargo lambda build --release --arm64 --features aws --bin bootstrap --output-format zip
cargo lambda build --release --arm64 --features aws --bin watcher --output-format zip
test -f target/lambda/bootstrap/bootstrap.zip
test -f target/lambda/watcher/bootstrap.zip

js:
name: js test
runs-on: ubuntu-latest
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,17 @@ jobs:
toolchain: stable
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
- uses: hashicorp/setup-terraform@b9cd54a3c349d3f38e8881555d616ced269862dd # v3.1.2
# PINNED, not floating. Rust 1.98.0 began emitting `-Wl,--fix-cortex-a53-843419` for
# aarch64-unknown-linux-gnu, which zig's linker rejects; cargo-lambda 1.9.1 bundles
# cargo-zigbuild 0.20.1, which does not filter the flag, so run 32498562051 could not link
# the Lambda and this deploy failed on a tip nothing in the repo had changed. cargo-lambda
# 1.9.2 carries the cargo-zigbuild 0.23.0 uplift that filters it.
#
# Both versions are pinned so a toolchain move arrives as a deliberate bump reviewed here,
# and so ci.yml's `lambda-build` gate and this step build with the SAME toolchain — an
# unpinned gate can pass on a version the later deploy no longer resolves to.
- name: install cargo-lambda + zig (arm64 cross-compile)
run: pip install cargo-lambda ziglang
run: pip install "cargo-lambda==1.9.2" "ziglang==0.16.0"
- name: build resolver lambda zip (arm64)
id: build
run: |
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "on-dig-net-resolver"
version = "0.5.11"
version = "0.5.12"
edition = "2021"
rust-version = "1.94.1"
license = "GPL-2.0-only"
Expand Down
Loading