Skip to content

Conversation

@Robin-Van-de-Merghel
Copy link
Contributor

BEGINRELEASENOTES

Please follow the template:
*Integration Tests
NEW: Add pilot logs into the integration tests

ENDRELEASENOTES

CLIENT_UPLOAD_LFN: LFN:/vo/test_lfn.txt
CLIENT_UPLOAD_FILE: test_lfn.txt
PILOT_INSTALLATION_COMMAND: dirac-pilot.py --modules /home/dirac/LocalRepo/ALTERNATIVE_MODULES/DIRAC -M 2 -N jenkins.cern.ch -Q jenkins-queue_not_important -n DIRAC.Jenkins.ch --pilotUUID=whatever12345 --CVMFS_locations=/home/dirac/ -o diracInstallOnly --wnVO=vo --debug
PILOT_INSTALLATION_COMMAND: dirac-pilot.py --modules /home/dirac/LocalRepo/ALTERNATIVE_MODULES/DIRAC -M 2 -N jenkins.cern.ch -Q jenkins-queue_not_important -n DIRAC.Jenkins.ch --pilotUUID=whatever12345 --CVMFS_locations=/home/dirac/ -o diracInstallOnly --wnVO=vo --debug --diracx_URL=http://diracx:8000 --clientID=072afab5-ed92-46e0-a61d-4ecbc96e0770 -z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added in the equivalent file in LHCbDIRAC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to be done in 2 PRs: add legacy adaptor tests in LHCBDirac, then modify this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -181 to -182
if pilotReference:
return self.pilotManager.getPilotOutput(pilotReference)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove it from here then we should probably remove it from anywhere else.

Copy link
Contributor Author

@Robin-Van-de-Merghel Robin-Van-de-Merghel Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: #8233

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned

Screenshot 2025-08-07 at 15 26 40

@fstagni
Copy link
Contributor

fstagni commented Aug 7, 2025

Maybe this PR can be for 9.0

@Robin-Van-de-Merghel Robin-Van-de-Merghel marked this pull request as ready for review August 7, 2025 13:02
@Robin-Van-de-Merghel
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants