Skip to content

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Sep 25, 2025

BEGINRELEASENOTES

*Configuration
FIX: removed pinging of the CS when refreshing

ENDRELEASENOTES

@fstagni fstagni requested a review from atsareg as a code owner September 25, 2025 14:20
@chaen
Copy link
Contributor

chaen commented Sep 25, 2025

I was tempting to do the exact same earlier today and then realized it is not a good idea, because a completely overwhelmed slave could still call the method from the master. So I tried hotfixing it to reduce the timeout to 2s.

@fstagni
Copy link
Contributor Author

fstagni commented Sep 25, 2025

I do not see any added value in attempting this ping, anyway in most cases the slave will not be added to the list (because it would be there already)

@chaen
Copy link
Contributor

chaen commented Sep 26, 2025

I am not sure I understand what you mean. The list of slave is cleaned every 10 minutes (by default).

@fstagni
Copy link
Contributor Author

fstagni commented Sep 26, 2025

I am not sure I understand what you mean. The list of slave is cleaned every 10 minutes (by default).

Ah, I had forgotten about that. What is the reason for such a frequent cleaning?

@chrisburr
Copy link
Member

10 minutes is a long time to have a dead server in the list

@fstagni fstagni closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants