Feature/test settings page #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunilHwang
approved these changes
Feb 28, 2022
Comment on lines
+34
to
+35
| const isShowOption = (settingOptionType: SettingOptionType) => | ||
| editingState[settingOptionType] !== EditingStateType.EMPTY; |
There was a problem hiding this comment.
editingState에 대해 메모이제이션을 해도 좋을 것 같음
There was a problem hiding this comment.
현재 컴포넌트는 state 를 editingState 하나만 쓰이기 때문에 메모이제이션을 사용할 필요가 없음. (useCallback) 그러나
추후 state가 추가가 될 가능성이 있다면 미리 useCallback 을 써주는 것이 좋으나,
하나의 컴포넌트는 최소한의 state 를 가질수있도록 코딩하는 것이 객체지향적으로 좋을듯함.
| <Conditional condition={isShowOption(SettingOptionType.POSITION)}> | ||
| <SettingPosition | ||
| editingStateType={editingState[SettingOptionType.POSITION]} | ||
| setEditingState={() => setEditingState(SettingOptionType.POSITION)} |
There was a problem hiding this comment.
const setOneOfEditingState = useCallback(
(settingOption: SettingOptionType) =>
() => setEditingState(settingOptionType),
[setEditingState]
);이런 함수를 하나 만들어서 사용하면 좋을 것 같음
| return ( | ||
| <> | ||
| <SettingOption | ||
| question={"[] 분 동안 몸 풀래요"} |
| <> | ||
| <SettingOption | ||
| question={"[] 분 동안 몸 풀래요"} | ||
| selectedOption={(!!selectedTime ? `${selectedTime} 분` : "") + ""} |
There was a problem hiding this comment.
Suggested change
| selectedOption={(!!selectedTime ? `${selectedTime} 분` : "") + ""} | |
| selectedOption={String(!!selectedTime ? `${selectedTime} 분` : "")} |
이렇게 표현하면 더 명확할듯
Comment on lines
27
to
36
| {question.substring(0, question.indexOf(SettingOptionalChar))} | ||
| <span> | ||
| {editingStateType === EditingStateType.COMPLETE | ||
| ? selectedOption | ||
| : "..."} | ||
| </span> | ||
| {question.substring( | ||
| question.indexOf(SettingOptionalChar) + SettingOptionalChar.length, | ||
| question.length | ||
| )} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.