Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed marci ephemeris time difference #600

Merged
merged 3 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ release.
- Changed how push frame sensor drivers compute the `ephemeris_time` property [#595](https://github.com/DOI-USGS/ale/pull/595)

### Fixed

- Fixed landed sensors to correctly project locally [#590](https://github.com/DOI-USGS/ale/pull/590)
- Fixed Hayabusa amica center time computation to match ISIS [#592](https://github.com/DOI-USGS/ale/pull/592)
- Set Lunar Oribter abberation correction to None as it is in ISIS [#593](https://github.com/DOI-USGS/ale/pull/593)
- Fixed missing sensor_model_version attribute on NewHorizonsLorriIsisLabelNaifSpiceDriver [#583](https://github.com/DOI-USGS/ale/pull/583)
- Fixed missing sensor_model_version attribute on VikingIsisLabelNaifSpiceDriver [#583](https://github.com/DOI-USGS/ale/pull/583)
- Fixed incorrect distortion look up in Orex camera when working with PolyCam images [#583](https://github.com/DOI-USGS/ale/pull/583)
- Brought timing in line with ISIS for the KaguyaMiIsisLabelNaifSpiceDriver [#599](https://github.com/DOI-USGS/ale/pull/599)
- Brought timing in line with ISIS for the MroMarciIsisLabelNaifSpiceDriver [#600](https://github.com/DOI-USGS/ale/pull/600)

## [0.10.0] - 2024-01-08

Expand Down
7 changes: 7 additions & 0 deletions ale/drivers/mro_drivers.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import numpy as np
import spiceypy as spice

from ale.base import Driver
Expand Down Expand Up @@ -179,6 +180,12 @@ def ephemeris_stop_time(self):
line = 0.5
self._ephemeris_stop_time = max(self.compute_marci_time(line))
return self._ephemeris_stop_time

@property
def ephemeris_time(self):
if not hasattr(self, "_ephemeris_time"):
self._ephemeris_time = np.linspace(self.ephemeris_start_time, self.ephemeris_stop_time + self.interframe_delay, self.image_lines + 1)
return self._ephemeris_time

@property
def detector_center_line(self):
Expand Down
Loading
Loading