Threads #204
Open
Threads #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of polling an atomic boolean value with micro sleeps, use pthread condition objects that are designed exactly for signaling between threads. This allows the kernel to properly schedule waiting threads until they need to be woken up. This will be leveraged in future commits to keep worker threads alive all the time even when they don't have any RXQ to poll. Signed-off-by: Robin Jarry <[email protected]>
Be consistent and use the same "grout:" prefix for all threads created by grout. Signed-off-by: Robin Jarry <[email protected]>
Keep one worker thread per CPU in the datapath affinity mask. Only destroy threads when removing CPUs from that mask. Now that threads are waiting for a pthread condition, this will not consume any cycles on these CPUs and will allow the kernel to change the C-state / P-state of the cores accordingly. Moreover, since the threads are now always started, moving rxqs around should be faster. Signed-off-by: Robin Jarry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.