Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: broken-link #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: broken-link #18

wants to merge 1 commit into from

Conversation

gassims
Copy link

@gassims gassims commented Jan 23, 2023

Replaced the link (https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-235/web-api.html) which incorrectly redirects to the docs main page with https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-master/introduction.html

2.35 is no longer an officially supported version of dhis2, docs should link to dhis2-core-version. Thank you!

Replaced the link (https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-235/web-api.html) which incorrectly redirects to the docs main page with https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-master/introduction.html

2.35 is no longer an officially supported version of dhis2, docs should link to dhis2-core-version. Thank you!
@nathanfletcher
Copy link
Collaborator

Hi @gassims thanks for the PR!
Looping in @prajectory to this PR.

@nathanfletcher
Copy link
Collaborator

Hi @gassims

This is the new DPG web page format DHIS2 https://app.digitalpublicgoods.net/a/10165

We are migrating all DPGs to this new page format. This new page format gets the descriptions from a new API we are migrating to. As such, the change you asked for here will also have to be made there, after verification.
I will accept this PR but will do so after the description in the new page format has also been made.

@prajectory (cc @ricardomiron ) in the new DPG web app, the description for DHIS2 will have to be updated, specifically in the NonPII section
https://app.digitalpublicgoods.net/a/10165

@gassims PR requests that we replace the URL https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-235/web-api.html with https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-master/introduction.html

The reason is in the PR description above.

@gassims
Copy link
Author

gassims commented Feb 2, 2023

Thank you!

I see that it got updated to: https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-239/introduction.html

However, the one that will ALWAYS be current doesn't have a version number: https://docs.dhis2.org/en/develop/using-the-api/dhis-core-version-master/introduction.html

core-version-master remains up to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants