Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HTML): Export formulas with mathml #144

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Conversation

dolfim-ibm
Copy link
Contributor

@dolfim-ibm dolfim-ibm commented Jan 31, 2025

feat(HTML): Allow the export of formulas as mathml
feat(HTML): Retain the original latex using html standards
fix(HTML): Keep newlines in pre blocks

Chore:

  • Rework the sanitize function and move newline cleanup in there
  • Remove functions which would never be executed (because the labels logic changed)

Open questions:

  1. Should this be the default?
  2. Should the new dependency always be there or as extras?

the labels allowlist is checked before

Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Copy link

mergify bot commented Jan 31, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

Signed-off-by: Michele Dolfi <[email protected]>
PeterStaar-IBM
PeterStaar-IBM previously approved these changes Jan 31, 2025
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!! 🚀

Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm changed the title feat: Export formulas with mathml feat(HTML): Export formulas with mathml Jan 31, 2025
vagenas
vagenas previously approved these changes Jan 31, 2025
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm merged commit ed36437 into main Jan 31, 2025
8 checks passed
@dolfim-ibm dolfim-ibm deleted the feat-export-formulas branch January 31, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants