Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HTML): Fallback showing formulas as images #146

Merged
merged 13 commits into from
Feb 3, 2025
Merged

Conversation

dolfim-ibm
Copy link
Contributor

This PR is based on the assumption that item.text should be populated only and only if the formula is coming from a trusted source, i.e. from a declarative backend (like MS Word) or from the code_formula model.

To make this assumption work, the glm_utils.to_docling_document() method will be modified to wipe the item.text and keep only the item.orig.

the labels allowlist is checked before

Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Michele Dolfi <[email protected]>
Copy link

mergify bot commented Jan 31, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@dolfim-ibm dolfim-ibm merged commit 23477f7 into main Feb 3, 2025
8 checks passed
@dolfim-ibm dolfim-ibm deleted the feat-formula-as-img branch February 3, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants