feat!: New API for models initialization with accelerators parameters. Use HF implementation for LayoutPredictor. Migrate models to safetensors format. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
…layout_predictor_jit.py The safe tensors version is the layout_predictor.py Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
…text files with the predictions Signed-off-by: Nikos Livathinos <[email protected]>
…t_predictor_jit.py Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
…youtPredictor Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
…e measurements Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
… num_threads. Remove envvars. Update unit tests. Signed-off-by: Nikos Livathinos <[email protected]>
…g. Improve demo_layout_predictor Signed-off-by: Nikos Livathinos <[email protected]>
This was referenced Nov 25, 2024
dolfim-ibm
reviewed
Dec 6, 2024
pyproject.toml
Outdated
| @@ -24,6 +24,8 @@ packages = [ | |||
| python = "^3.9" | |||
| torch = "^2.2.2" | |||
| torchvision = "^0" | |||
| transformers = "^4.46.2" | |||
There was a problem hiding this comment.
RT-DETR was published in 4.42.0 would that be a good initial version?
There was a problem hiding this comment.
I just tried it with 4.42.0 and it seems to work and pass the tests. I guess we can lower the version.
pyproject.toml
Outdated
| @@ -24,6 +24,8 @@ packages = [ | |||
| python = "^3.9" | |||
| torch = "^2.2.2" | |||
| torchvision = "^0" | |||
| transformers = "^4.46.2" | |||
| accelerate = "^1.1.1" | |||
There was a problem hiding this comment.
it doesn't seem to be imported. do we need it?
There was a problem hiding this comment.
The accelerate module is used internally by the HF RT-DETR implementation and we need to install it, otherwise we receive an error message to do it.
I have refactored the code so that the accelerate package is not needed.
…58) Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
…ests. Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
cau-git
force-pushed
the
nli/performance
branch
from
5c232b2 to
8d8c2f8
Compare
cau-git
changed the title
Signed-off-by: Christoph Auer <[email protected]>
cau-git
approved these changes
Dec 11, 2024
dolfim-ibm
approved these changes
Dec 11, 2024
nikos-livathinos
changed the title
nikos-livathinos
changed the title
nikos-livathinos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following tasks:
LayoutPredictorthat uses the HF API and safe tensors checkpoint.torch.jitimplementation and the new HF + safe tensors are the same (labels, bboxes).LayoutPredictorto use the safe tensors implementation and improve the output.Links:
https://huggingface.co/docs/transformers/model_doc/rt_detr
Checklist:
conventional commits.