fix(html-backend): improve accordion extraction and hidden content ha… #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling
- Add specialized handlers for Bootstrap accordion components to properly extract
questions from panel-title elements
- Implement is_hidden_element() method to detect and skip content with hidden
classes, styles, and attributes
- Update walk(), analyze_tag(), and extract_text_recursively() to filter out
hidden elements
- Add comprehensive test suite with direct method tests and example HTML files
This fixes two issues:
1. Missing questions in accordion components
2. Unwanted extraction of hidden metadata content
Tests: tests/test_html_enhanced.py
Signed-off-by: Ulan.Yisaev <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Ulan.Yisaev <[email protected]>
dolfim-ibm
previously approved these changes
Mar 5, 2025
There was a problem hiding this comment.
@ulan-yisaev thanks for your contribution. looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues with the HTML backend:
Missing questions in Bootstrap accordion components: The HTML backend was not properly extracting questions from Bootstrap accordion components. These questions were in
<a>tags inside<div class="panel-title">elements, causing incomplete Q&A extraction.Unwanted extraction of hidden content: The backend was including text from elements marked as 'hidden', which polluted the extracted content with metadata and invisible elements.
Changes implemented:
divto theTAGS_FOR_NODE_ITEMSlist to ensure div elements are processedhandle_panel_title(): Extracts question text from panel titleshandle_panel(): Processes entire accordion panelsis_hidden_element()method to detect various types of hidden elements:extract_text_recursively()to skip hidden content during text collectionwalk()to skip processing hidden tags entirelyanalyze_tag()to prevent processing hidden elementsIssue resolved by this Pull Request:
Resolves #1112
Checklist: