consolidate advanced chunker notebook #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bill Murdock <[email protected]>
Signed-off-by: Bill Murdock <[email protected]>
Earlier versions used the `doc.name` as the overall title of the document, but the discussion revealed that probably it is better to just trust the `doc_chunk.meta.headings` to have the title information sooner or later. So I've removed all the special title stuff and am just relying on the headers now. Signed-off-by: Bill Murdock <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Add typing, switch to list comprehensions where possible, encapsulate all methods within new chunker implementation, use dataclass instead of unmanged dictionary, list dependencies in setup installation line Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
Base automatically changed from
jwm4-chunking-example-1
to
advanced-chunking-example
November 19, 2024 22:12
|
Changes directly merged to https://github.com/DS4SD/docling/tree/advanced-chunking-example as part of ce38baf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements with this PR: