Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for the crash when encountering WMF images in pptx and docx #837

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

maxmnemonic
Copy link
Contributor

PIL supports WMF images only on Windows platform, hence this fix

Issue resolved by this Pull Request:
Resolves #594

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

…nds on non Windows platforms

Signed-off-by: Maksym Lysak <[email protected]>
Copy link

mergify bot commented Jan 30, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@dolfim-ibm
Copy link
Contributor

The fix looks good, but can you please add the following in docs/faq.md? (or similar)

??? Some images are missing from MS Word and Powerpoint"

    ### Some images are missing from MS Word and Powerpoint

    The image processing library used by Docling is able to handle WMF images only on Windows platform.
    If you are on other operaring systems, these images will be ignored.

Signed-off-by: Maksym Lysak <[email protected]>
@maxmnemonic
Copy link
Contributor Author

The fix looks good, but can you please add the following in docs/faq.md? (or similar)

??? Some images are missing from MS Word and Powerpoint"

    ### Some images are missing from MS Word and Powerpoint

    The image processing library used by Docling is able to handle WMF images only on Windows platform.
    If you are on other operaring systems, these images will be ignored.

That's a cool idea, added to faq.md!

@maxmnemonic maxmnemonic merged commit fea0a99 into main Jan 30, 2025
9 checks passed
@maxmnemonic maxmnemonic deleted the dev/fixes_for_wmf branch January 30, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMF images cause unhandled exceptions in mspowerpoint_backend
2 participants