Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docx): merged table cells not properly converted #857

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

ceberam
Copy link
Contributor

@ceberam ceberam commented Jan 31, 2025

  • Fix merged table cells not properly converted in Word documents.
  • Simplify Word table conversion code.
  • Add docx file with several table formats for regression tests.
  • Add type hinting to docx backend module.

Issue resolved by this Pull Request:
Resolves #791

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Fix conversion issue of merged cells in Word tables leading to repeated text.
Simplify Word table conversion code.
Add docx file with several table formats for regression tests.

Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Copy link

mergify bot commented Jan 31, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@ceberam ceberam self-assigned this Feb 3, 2025
@ceberam ceberam merged commit 0cd81a8 into main Feb 3, 2025
10 checks passed
@ceberam ceberam deleted the fix/msword-merged-cells branch February 3, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Table Formatting in Converting Word Documents To HTML
3 participants