feat(dt-utils): refactor the dt-utils #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyFBB
reviewed
Jun 27, 2025
LuckyFBB
reviewed
Jun 27, 2025
| * generateUrlWithQuery('/api/data', { id: 123, name: null, status: undefined }) // => '/api/data?id=123' | ||
| * ``` | ||
| */ | ||
| const generateUrlWithQuery = (pathname: string, queryParams: QueryParams = {}): string => { |
There was a problem hiding this comment.
buildQueryUrl
formatUrlWithParams
appendQueryToUrl
这几个命名如何
| * getKey(5) // => "a4b2x" | ||
| * ``` | ||
| */ | ||
| const getKey = (size: number): string => { |
There was a problem hiding this comment.
会不会太简单了，太宽泛了。
generateUniqueId 这个如何？
| * getTypeOfValue(new Set()); // => 'set' | ||
| * ``` | ||
| */ | ||
| const getTypeOfValue = (value: any) => { |
There was a problem hiding this comment.
比 typeof 强点，要不直接叫 typeof吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
变更类型
请选择以下选项以描述 PR 的类型：
相关问题
变更内容
优化
新增
对应 Previewer
https://jin-sir.github.io/dt-utils/