Skip to content

Porting#164

Merged
jimmy312495 merged 11 commits into
mainfrom
porting
Mar 11, 2026
Merged

Porting#164
jimmy312495 merged 11 commits into
mainfrom
porting

Conversation

@ric2k1
Copy link
Copy Markdown
Contributor

@ric2k1 ric2k1 commented Mar 11, 2026

Check List

  1. Does your submission pass tests by running make test?
  2. If you have specified a [no ci] tag, does your submission also pass tests by running make test-docker?
  3. Have you linted your code locally with make lint before submission?

Added

  • 加上 #include ,讓 std::uint8_t 有正確定義。
  • 讓使用者可以建立自己的 .env.local, 定義一些 local overrides 的變數 (e.g. CC/CXX) for compilation 或是環境變數的客製化
  • cmake: allow GCC 15+ build by relaxing cast-user-defined as warning

Changed

  • Some modifications for porting to Mac

Fixed

  • make test & lint errors/warnings

Removed

ric2k1 added 10 commits March 11, 2026 14:46
CMake ≥ 3.29,並說明如何檢查與升級
明確列出 C++20 與編譯器 (g++-11 / clang++-16+)
說明需要 BLAS/LAPACK (OpenBLAS / LAPACK)
Linux:改寫為用預設 gcc/g++,並提到可用環境變數或 .env.local 覆寫編譯器。

macOS:

保留 LLVM 選項,並新增 GCC 選項(遇到 fmt/consteval 錯誤時建議用 GCC)
說明用 .env.local 指定 Homebrew GCC 的路徑與範例
Local overrides (.env.local) 新章節:

說明 .env.local 為選用、僅在檔案存在時被讀取、且被 git 忽略
建議 cp .env.local.example .env.local 再編輯
給出 CC / CXX 的範例
Docker Builds:

強調可直接 docker run ... 使用預建映像
註明 make build-docker 需要映像內 CMake ≥ 3.29
- Add -Wno-error=cast-user-defined for qsyn executable and libqsyn when
  using GNU compiler. GCC 15 treats C-style cast in ordered_hashtable
  (pair<K,V> to pair<const K,V>&) as -Werror=cast-user-defined; this
  keeps the build passing while preserving the warning.

Made-with: Cursor
- Include .env.local when present so CC, CXX (and other vars) can be
  overridden per-developer without touching the repo.
- Only include if .env.local exists (wildcard check).
- Clarify comment for platform default compiler block.

Made-with: Cursor
@jimmy312495 jimmy312495 self-requested a review March 11, 2026 14:55
Copy link
Copy Markdown
Contributor

@jimmy312495 jimmy312495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmy312495 jimmy312495 merged commit b77187c into main Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants