test(pril): make C4 tracked-file assertion bite on its own (review sa…#97
Merged
Conversation
…lvage) Independent-review finding (salvaged from a session-limit-killed reviewer, then verified by mutation probe): the tracked-but-ignore-matching assertion ran against a changed-list that also carried an independently-blocking file, so it would have passed even if tracked files were wrongly exempted. Now a single-file tracked-only list decides purely on the tracked/untracked split, plus a roundtrip assertion (untracked again -> exempt again). Mutation probes: disabling only the tracked-split still blocks (git check-ignore itself excludes tracked files — independent second defense); unconditional exemption makes BOTH assertions fail. Reverted after probe. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR strengthens the C4 runtime integrity test by ensuring the tracked-but-ignore-matching assertion is exercised in isolation on a single-file changed list and adds a roundtrip check that the same path becomes exempt again when untracked, directly validating the tracked/untracked split behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lvage)
Independent-review finding (salvaged from a session-limit-killed reviewer, then verified by mutation probe): the tracked-but-ignore-matching assertion ran against a changed-list that also carried an independently-blocking file, so it would have passed even if tracked files were wrongly exempted. Now a single-file tracked-only list decides purely on the tracked/untracked split, plus a roundtrip assertion (untracked again -> exempt again).
Mutation probes: disabling only the tracked-split still blocks (git check-ignore itself excludes tracked files — independent second defense); unconditional exemption makes BOTH assertions fail. Reverted after probe.
Summary by Sourcery
Tests: