Conversation
* Update Val architecture to clarify compilation-time semantics Restructure Val documentation to emphasize that val represents a value at a specific point in time during compilation. Rename 'from' to 'prev' and reorganize properties to show transformation tracking (code, validation) as relative to the previous val in the chain. * Fix Val documentation accuracy - Val is mutable, reflects specific value type (not immutable snapshot) - Clarify expected is the schema to build decoder for - Remove 'built-in' qualifier from validation (not always built-in) --------- Co-authored-by: Claude <[email protected]>
* Fix hasTransform and isAsync for recursive schemas - Add hasTransform field to schema type (parallel to isAsync) - Cache hasTransform in compileDecoder alongside isAsync - Refactor recursiveDecoder to use optimistic compilation: - Start with optimistic assumptions (hasTransform=false, isAsync=false) - Set values on def before compiling for inner circular refs to read - After compilation, check if actual values match assumptions - If mismatched, clear cache and recompile with correct values - Remove messy isAsyncInternal workaround and FIXME comment - Update JSON parse code test expectation (no more array/object recreation) This fixes the TODO about not needing to recreate array/json values. Recursive schemas without transforms now generate cleaner code. https://claude.ai/code/session_01J6u8Aw2p2PGXbZUMUEScK1 * Update compiled Sury.res.mjs https://claude.ai/code/session_01J6u8Aw2p2PGXbZUMUEScK1 * Fix embed of temporary decoder * Improve recursive decoder * Final test fixes for recursive improvement --------- Co-authored-by: Claude <[email protected]>
* Decouple refiner from decoder by storing in refiner field Instead of baking refiner logic into the decoder via appendRefiner, store the refiner function in the dedicated `refiner` field on the internal schema type. The parse function already calls `expected.refiner` separately after the decoder, so this change requires no parse logic modifications. Chaining of multiple refiners is handled by composing the builder functions in the refiner field. https://claude.ai/code/session_01LPsNZxPJdRczdL94YEHccc * Change refiner field type from builder to code-returning function Refiner no longer mutates the val inside itself. Instead of using the builder type (val => val), the refiner and inputRefiner fields now use (~input: val, ~selfSchema: internal) => string - the same type that internalRefine accepts. The parse function calls the refiner and appends the returned code string to codeAfterValidation. Multiple refiners are composed by concatenating their code strings. https://claude.ai/code/session_01LPsNZxPJdRczdL94YEHccc * Remove ~selfSchema from refiner type and clean up internalRefine The selfSchema param was unused by all refiners (always ~selfSchema as _) since it's available via input.expected. Simplified the refiner type to (~input: val) => string. Moved the switch outside of mut.refiner assignment in internalRefine for cleaner control flow. https://claude.ai/code/session_01LPsNZxPJdRczdL94YEHccc * Rename refiner arg to makeRefiner and refinerCode to refiner https://claude.ai/code/session_01LPsNZxPJdRczdL94YEHccc * Remove unused appendRefiner fn --------- Co-authored-by: Claude <[email protected]>
) * Update test assertions for logically correct compiled code snapshot changes 8 snapshot assertions updated across 6 test files to match the new compiled output from the val architecture refactoring: - S_test.ts: Fix error message for recursive self-as-transform-target - S_refine_test.res: Update parse code snapshot (object construction before validation) - S_object_test.res: Update parse + reverse convert snapshots - Example_test.res: Update serialize code snapshot (unused variable read) - S_recursive_test.res: Update 2 ParseAsync snapshots (new recursive ref format) - S_union_test.res: Update json-rpc ReverseConvert (3x→2x union duplication) https://claude.ai/code/session_01Uax71CbmZTwTgfRjWVgcLu * Revert S_test.ts message change (was correct before) and add FIXME for union v5 double conversion The "Recursive with self as transform target" test correctly expects "from string to Node[]" — the library now incorrectly says "from Node". Added FIXME noting v5 is still converted twice in json-rpc ReverseConvert. https://claude.ai/code/session_01Uax71CbmZTwTgfRjWVgcLu * Update json-rpc ReverseConvert assertion to expect single v5 conversion The nested error union should only need one pass to convert v5, not two. The test will fail until the library is fixed. https://claude.ai/code/session_01Uax71CbmZTwTgfRjWVgcLu --------- Co-authored-by: Claude <[email protected]>
Instead of hardcoding selfReverse=false, check if the item schema is self-reversing by comparing Dict.getUnsafe(reversedKey) === itemInternal. Also rename reverseKey to reversedKey. https://claude.ai/code/session_01FSGU4DhYDjWQu2n3bE3FQh Co-authored-by: Claude <[email protected]>
* Change S.refine JS API from callback-based to boolean-returning signature
S.refine now takes (value) => boolean check function with optional
{ error, path } options instead of (value, s) => void with s.fail().
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Update JS docs and add ideas.md with changelog for S.refine change
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Inline js_refine check via internalRefine, remove tracked S_test.js, update IDEAS.md
- Refactored js_refine to use internalRefine directly, generating inline
validation code instead of going through effectCtx
- Removed S_test.js from git (generated file, already gitignored)
- Moved changelog entry from ideas.md to existing IDEAS.md
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Add test for S.refine with path option
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Improve S.refine docs with examples following Zod-style documentation
Added sections for custom error messages, custom error paths, and
chaining refinements with clear code examples.
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Rename S.asyncParserRefine to S.asyncDecoderAssert
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Remove EffectCtx from asyncDecoderAssert in favor of throwing directly
- Renamed refiner param to assertFn, removed s (EffectCtx) argument
- Removed EffectCtx type (no longer used anywhere)
- Restored comment on .with() overload
- Updated tests, docs, and changelog
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Fix async docs wording and simplify async test assertions
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Wrap asyncDecoderAssert errors as custom SuryError
Thrown errors are caught and re-thrown as SuryError with code "custom",
preserving the original error message. Already-SuryErrors are re-thrown
as-is.
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
* Revert asyncDecoderAssert custom error wrapping, keep it simple
Let transform handle error wrapping naturally.
https://claude.ai/code/session_013mvoLw6QfNz5DJAUL1jV7W
---------
Co-authored-by: Claude <[email protected]>
* Update S.refine ReScript API from callback-based to boolean-returning Changed the public ReScript API for S.refine from the old callback-based style `(t<'value>, s<'value> => 'value => unit) => t<'value>` to the new boolean-returning style `(t<'value>, 'value => bool, ~error: string=?, ~path: array<string>=?) => t<'value>`. This aligns with the TypeScript API change in d2d8dd4, using labeled arguments (~error, ~path) instead of a JS-style options object. Updated: S.resi, Sury.resi, Sury.res implementation, IDEAS.md, docs, and all test files using the refine API. Also updated compiled code snapshots to match actual output. https://claude.ai/code/session_01FL2DmWjTLoMgTvdE43KG9z * Revert assertCompiledCode expectations to document correct behavior Keep the original expected compiled code in tests where the actual generated code is broken (pre-existing bug with refine on object schemas and union schemas). The tests fail, documenting what the code generator should produce once the underlying bugs are fixed. https://claude.ai/code/session_01FL2DmWjTLoMgTvdE43KG9z --------- Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.