[#109] 마이페이지 6-2 분할 첫번째#130
Open
chan0310 wants to merge 3 commits into
Open
Conversation
SujinKim1127
requested changes
Oct 10, 2023
SujinKim1127
left a comment
SujinKim1127
left a comment
Member
There was a problem hiding this comment.
commit message가
[fix] 마이페이지
이렇게만 되어있으면 작업내용을 파악하기가 어렵습니다
보다 더 구체적으로 commit message 작성해주세요
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| font-size:20px; |
Comment on lines
+75
to
+91
| <div style={{ width:"180px" ,display: "flex", | ||
| justifyContent: "space-between", alignItems: "center"}}> | ||
| <img src="/assets/icon/Shape/Triangle.svg" style={{marginTop:"7px", | ||
| alignSelf: "flex-start", | ||
| width: "13px", marginRight:"4px"}}/> | ||
| <style.MyAssignTitleBoxText color={COLORS.grayscale.Black} | ||
| fontSize={TEXT_STYLES.CapM14.fontSize} fontFamily={TEXT_STYLES.CapM14.fontFamily} | ||
| fontWeight={TEXT_STYLES.CapM14.fontWeight} letterSpacing={TEXT_STYLES.CapM14.letterSpacing} | ||
| style={{width:"30px"}}>지각</style.MyAssignTitleBoxText> | ||
| <style.MyAssignTitleBoxText color={COLORS.SSU.yellow} | ||
| fontSize={TEXT_STYLES.CapM14.fontSize} fontFamily={TEXT_STYLES.CapM14.fontFamily} | ||
| fontWeight={TEXT_STYLES.CapM14.fontWeight} letterSpacing={TEXT_STYLES.CapM14.letterSpacing} | ||
| style={{width:"30px"}}>{elementCount[2]}</style.MyAssignTitleBoxText> | ||
| </div> | ||
|
|
||
| <div style={{ width:"180px" ,display: "flex", | ||
| justifyContent: "space-between", alignItems: "center"}}> |
Member
There was a problem hiding this comment.
div 스타일이 똑같으면 emotion/styled 사용해서 작성해주세요!
Comment on lines
+32
to
+35
| <styles.SubjectCardText color={COLORS.grayscale.Black} | ||
| fontSize={TEXT_STYLES.HeadM18.fontSize} fontFamily={TEXT_STYLES.HeadM18.fontFamily} | ||
| fontWeight={TEXT_STYLES.HeadM18.fontWeight} letterSpacing={TEXT_STYLES.HeadM18.letterSpacing} | ||
| >{formData.title}</styles.SubjectCardText> |
Member
There was a problem hiding this comment.
이런 내용들은 styles.tsx 파일에 적어주세요..
Comment on lines
+36
to
+39
| <div style={{ width:`${formData.width!-50}px` ,display: "flex", | ||
| justifyContent: "space-between", alignItems: "center" }}> | ||
| <div style={{ width:"80px" ,display: "flex", | ||
| justifyContent: "space-between", alignItems: "center"}}> |
| "react-router-dom": "6.15.0", | ||
| "recoil": "0.7.7", | ||
| "recoil-persist": "5.1.0", | ||
| "styled-components": "^6.0.8", |
Member
There was a problem hiding this comment.
저희 emotion/styled 사용합니다
styled-components 는 삭제해주세요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
Check List
main브랜치의 최신 상태를 반영하고 있는지 확인Screenshot