This repository was archived by the owner on Oct 25, 2023. It is now read-only.
kubernetes deployment for all clusters in same account#50
Open
carlessanagustin wants to merge 10 commits into
Open
kubernetes deployment for all clusters in same account#50carlessanagustin wants to merge 10 commits into
carlessanagustin wants to merge 10 commits into
Conversation
added 10 commits
September 8, 2020 11:31
Owner
|
Hi @carlessanagustin ! What's the difference between this PR and #43? If there are new commits, you probably need to rebase on master ^^ |
Contributor
Author
|
PR 43 is for 1 cluster only, this PR is for N clusters plus some other improvements. |
Owner
|
Looking at the commits, they are completely identical: https://github.com/Dabz/ccloudexporter/pull/43/commits and https://github.com/Dabz/ccloudexporter/pull/50/commits 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows to add multiple clusters at once just by using "CCLOUD_CLUSTERS=<cluster_id1> <cluster_id2> ...<cluster_idX>". It creates X deployments, services and secrets but 1 CD ServiceMonitor with all X clusters.