q_math: reuse the first trace in QuatFromMatrix()

DaemonEngine · Jan 28, 2025 · cf5a556 · cf5a556
1 parent 39ce0d8
commit cf5a556
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/engine/qcommon/q_math.cpp b/src/engine/qcommon/q_math.cpp
@@ -2866,11 +2866,11 @@ void QuatFromMatrix( quat_t q, const matrix_t m )
 	 *
 	 *	   https://web.archive.org/web/20100818052330/http://cache-www.intel.com/cd/00/00/29/37/293748_293748.pdf
 	 */
-	float t, s;
+	float t = m[ 0 ] + m[ 5 ] + m[ 10 ] + 1.0f;
+	float s;
 
-	if ( m[ 0 ] + m[ 5 ] + m[ 10 ] + 1.0f > 0.0f )
+	if ( t > 0.0f )
 	{
-		t = m[ 0 ] + m[ 5 ] + m[ 10 ] + 1.0f;
 		s = ( 1.0f / sqrtf( t ) ) * 0.5f;
 
 		q[ 3 ] = s * t;