Implement geometry cache #1515
Merged
Implement geometry cache #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
added
T-Improvement
VReaperV
force-pushed
the
geometry-cache
branch
8 times, most recently
from
299a185 to
07571fd
Compare
VReaperV
force-pushed
the
geometry-cache
branch
3 times, most recently
from
d58bd41 to
60407b8
Compare
The geometry cache represents 3 buffers: a VBO, IBO, and inputVBO. These buffers will replace the old separate input VBOs and IBOs when enabled. This allows binding only a VAO before rendering, rather than setting up vertex pointers with the correct offset and formats every time. Additionally, it means that there's no need to switch between different VBOs/IBOs. The `inputVBO` is currently unused, but it will be needed to make models work with the geometry cache (model animations and world transform will be processed in a compute shader). Currently this is only used by the material system, but it should be possible to make the core renderer use it as well.
VReaperV
force-pushed
the
geometry-cache
branch
from
60407b8 to
c2c8487
Compare
slipher
reviewed
Feb 3, 2025
| @@ -288,7 +285,10 @@ enum class BufferBind { | |||
| COMMAND_COUNTERS_ATOMIC = 0, | |||
| COMMAND_COUNTERS_STORAGE = 4, // Avoid needlessly rebinding buffers | |||
| PORTAL_SURFACES = 5, | |||
| DEBUG = 10 | |||
| GEOMETRY_CACHE_INPUT_VBO = 6, | |||
There was a problem hiding this comment.
Not sure if they are supposed to be unique but there are two 6's.
There was a problem hiding this comment.
Right now it will work fine since buffers are still always being bound before the draws/dispatches, and later I'll probably add something to avoid rebinding both old and new-style buffers.
VReaperV
force-pushed
the
geometry-cache
branch
from
493091d to
4c359fc
Compare
VReaperV
force-pushed
the
geometry-cache
branch
from
4c359fc to
635926f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1511, #1513, and #1514.
The geometry cache represents 3 buffers: a VBO, IBO, and inputVBO. These buffers will replace the old separate input VBOs and IBOs when enabled. This allows binding only a VAO before rendering, rather than setting up vertex pointers with the correct offset and formats every time. Additionally, it means that there's no need to switch between different VBOs/IBOs. The
inputVBOis currently unused, but it will be needed to make models work with the geometry cache (model animations and world transform will be processed in a compute shader).This further improves performance and removes the VBO/IBO check for materials.
Currently this is only used by the material system, but it should be possible to make the core renderer use it as well.
This will also be required to support entities with material system.