Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: build Saigo arm nexe with -O0 to avoid a bug #1516

Merged
merged 1 commit into from
Jan 25, 2025
Merged

cmake: build Saigo arm nexe with -O0 to avoid a bug #1516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmake/DaemonFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,17 @@ else()
endif()
endif()

if (NACL AND USE_NACL_SAIGO AND SAIGO_ARCH STREQUAL "arm")
# This should be set for every build type because build type flags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link here to the relevant issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

# are set after the other custom flags and then have the last word.
# DEBUG should already use -O0 anyway.
# See: https://github.com/Unvanquished/Unvanquished/issues/3297
set_c_cxx_flag("-O0" DEBUG)
set_c_cxx_flag("-O0" RELEASE)
set_c_cxx_flag("-O0" RELWITHDEBINFO)
set_c_cxx_flag("-O0" MINSIZEREL)
endif()

# Extra debug flags.
set_c_cxx_flag("-g3" RELWITHDEBINFO)
set_c_cxx_flag("-g3" DEBUG)
Expand Down
Loading