Fix bad return type for Square() template #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It didn't take into account promotion to integer for types smaller than int. Fixes DaemonEngine#1533.
VReaperV
approved these changes
Jan 29, 2025
|
I'm in favor of merging this kind of fixup as soon as possible, to prevent future bisect runs to be polluted by this bug. We better keep such fixup as close as possible to the commit introducing the bug. The alternative would be to delay other merges to prevent them to slip in between (but we don't do that, and we better not do that). So @slipher you can merge this as soon as possible, no need to wait for one day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't take into account promotion to integer for types smaller than int.
Fixes #1533.