Collapse shaderType_t::3D_DYNAMIC and 3D_STATIC into one #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RE_RegisterShaderFromImage creates a q3shader object for textures that have just been generated at runtime. Don't attempt to find them in the shader hash table. This doesn't make much sense and even if a match were found, an image was already uploaded at that point so the memory is already wasted.
SHADER_3D_DYNAMIC and SHADER_3D_STATIC were two options for implicitly creating a shader from an image that lacks a text shader. Merge them into a single SHADER_3D. The only distinction between the two was using CGEN_IDENTITY vs. CGEN_IDENTITY_LIGHTING. This only makes a difference if r_overbrightQ3 is on. But even for emulating Quake 3 the code was wrong: it requested CGEN_IDENTITY_LIGHTING, which cancels overbright, for models. Models use the light grid which *should* receive the overbright factor. Actual ioq3 uses CGEN_LIGHTING_DIFFUSE, which we no longer have, for those models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no difference in behavior between them.