Skip to content

Migrate Setting Blocked Users View from XML to Compose #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -122,17 +122,6 @@ class ProfileOptionFragment : DialogFragment() {
}

private fun blockUser() {
profileViewModel.requestBlockMember(args.memberId)
profileViewModel.blockSuccess.observe(viewLifecycleOwner) {
if (it.getContentIfNotHandled() == true) {
Toast.makeText(
requireContext(),
R.string.other_profile_block_success_message,
Toast.LENGTH_SHORT
).show()
findNavController().navigateUp()
}
}
}

private fun setOptionReportUserClickListener() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,7 @@ class SettingFragment : Fragment() {

private fun setBlockButtonClickListener() {
binding.layoutSettingBlock.setOnDebounceClickListener {
findNavController().navigateSafe(
currentDestinationId = R.id.SettingFragment,
action = R.id.action_settingFragment_to_settingBlockFragment
)

}
}

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import androidx.navigation.compose.rememberNavController
import daily.dayo.presentation.screen.home.HomeRoute
import daily.dayo.presentation.screen.home.navigateHome
import daily.dayo.presentation.screen.mypage.navigateBackToFolder
import daily.dayo.presentation.screen.mypage.navigateBlockedUsers
import daily.dayo.presentation.screen.mypage.navigateBookmark
import daily.dayo.presentation.screen.mypage.navigateFolder
import daily.dayo.presentation.screen.mypage.navigateFolderCreate
Expand Down Expand Up @@ -84,6 +85,10 @@ class MainNavigator(
navController.navigateProfileEdit()
}

fun navigateBlockedUsers() {
navController.navigateBlockedUsers()
}

fun navigateBookmark() {
navController.navigateBookmark()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ internal fun MainScreen(
navigateBackToFolder = { folderId -> navigator.navigateBackToFolder(folderId) }
)
profileNavGraph(
snackBarHostState = snackBarHostState,
onFollowMenuClick = { memberId, tabNum -> navigator.navigateFollowMenu(memberId, tabNum) },
onFolderClick = { folderId -> navigator.navigateFolder(folderId) },
onPostClick = { postId -> navigator.navigatePost(postId) },
Expand All @@ -157,6 +158,7 @@ internal fun MainScreen(
coroutineScope = coroutineScope,
snackBarHostState = snackBarHostState,
onProfileEditClick = { navigator.navigateProfileEdit() },
onBlockUsersClick = { navigator.navigateBlockedUsers() },
onPasswordChangeClick = { navigator.navigateChangePassword() },
onSettingNotificationClick = { navigator.navigateSettingsNotification() },
onBackClick = { navigator.popBackStack() }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import daily.dayo.presentation.screen.folder.FolderCreateScreen
import daily.dayo.presentation.screen.folder.FolderEditScreen
import daily.dayo.presentation.screen.folder.FolderPostMoveScreen
import daily.dayo.presentation.screen.folder.FolderScreen
import daily.dayo.presentation.screen.settings.BlockedUsersScreen
import kotlinx.coroutines.CoroutineScope

fun NavController.navigateMyPage() {
navigate(MyPageRoute.route) {
Expand All @@ -23,6 +25,10 @@ fun NavController.navigateProfileEdit() {
navigate(MyPageRoute.profileEdit())
}

fun NavController.navigateBlockedUsers() {
navigate(MyPageRoute.blockedUsers())
}

fun NavController.navigateBookmark() {
navigate(MyPageRoute.bookmark())
}
Expand Down Expand Up @@ -109,6 +115,12 @@ fun NavGraphBuilder.myPageNavGraph(
)
}

composable(MyPageRoute.blockedUsers()) {
BlockedUsersScreen(
onBackClick = onBackClick,
)
}

composable(MyPageRoute.bookmark()) {
BookmarkScreen(
onBackClick = onBackClick
Expand Down Expand Up @@ -190,6 +202,9 @@ object MyPageRoute {
// profile edit
fun profileEdit() = "$route/edit"

// blocked users
fun blockedUsers() = "$route/blockedUsers"

// follow
fun follow(memberId: String, tabNum: String) = "$route/follow/$memberId/$tabNum"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package daily.dayo.presentation.screen.profile

import androidx.compose.material3.SnackbarHostState
import androidx.navigation.NavController
import androidx.navigation.NavGraphBuilder
import androidx.navigation.NavType
Expand All @@ -11,6 +12,7 @@ fun NavController.navigateProfile(memberId: String) {
}

fun NavGraphBuilder.profileNavGraph(
snackBarHostState: SnackbarHostState,
onFollowMenuClick: (String, Int) -> Unit,
onFolderClick: (Long) -> Unit,
onPostClick: (Long) -> Unit,
Expand All @@ -26,6 +28,7 @@ fun NavGraphBuilder.profileNavGraph(
) { navBackStackEntry ->
val memberId = navBackStackEntry.arguments?.getString("memberId") ?: ""
ProfileScreen(
externalSnackBarHostState = snackBarHostState,
memberId = memberId,
onFollowMenuClick = onFollowMenuClick,
onFolderClick = onFolderClick,
Expand Down
Loading