Created an instance of Arbitrary[String] #13
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 83.33% 62.5% -20.84%
==========================================
Files 1 1
Lines 6 8 +2
==========================================
Hits 5 5
- Misses 1 3 +2
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| println(extractUniqueWordsFromTextFile("BaconipSum.txt").mkString(",")) | ||
| // println(extractUniqueWordsFromTextFile("BaconipSum.txt").mkString(",")) |
There was a problem hiding this comment.
Remove this commented line
DanielaSfregola
left a comment
DanielaSfregola
left a comment
There was a problem hiding this comment.
Hi @KXA194,
thanks for your contribution! This is a good start: you are generating arbitrary correctly.
Could you please have a look at addressing my comments?
Thanks,
Daniela
| println(extractUniqueWordsFromTextFile("BaconipSum.txt").mkString(",")) | ||
| // println(extractUniqueWordsFromTextFile("BaconipSum.txt").mkString(",")) | ||
|
|
||
| val words: Set[String] = extractUniqueWordsFromTextFile("BaconipSum.txt") |
There was a problem hiding this comment.
Although this is correct, you should change this so that the file name is given rather than fixed.
Maybe, you could create a class that given a text file, gives you an Arbitrary[String] based on the words in the given file. Your class should also handle corner cases. For example, what would happen if the given file does not exist?
Cheers,
Daniela
| // println(extractUniqueWordsFromTextFile("BaconipSum.txt").mkString(",")) | ||
|
|
||
| val words: Set[String] = extractUniqueWordsFromTextFile("BaconipSum.txt") | ||
| val word: Arbitrary[String] = Arbitrary { |
There was a problem hiding this comment.
Well done! You can also just write Arbitrary(Gen.oneOf(words)) - it's the same, just more compact!
2 participants
An arbitrary word is selected from a textfile.