Repository navigation
fix(bridge-opencode): --unlink compara rutas canónicas (CI de main rojo en macOS) - #9
Merged
Merged
Conversation
…jo en macOS) do_unlink comparaba `readlink -f "$dest"` (ruta canónica) contra "$STORE/..." sin canonizar. En macOS el tmpdir es /var/folders -> /private/var, así que nunca coincidían: --unlink salía 0 sin quitar ningún enlace, y test/bridge-opencode.test.cjs dejaba en rojo el job Tests de main. Ahora el lado del store también se canoniza (pwd -P). Test nuevo que lo reproduce en Linux con un store detrás de un symlink. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0141jpRihLcQWr34jq6mvC7b
Contributor
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This was referenced Sep 25, 2026
Owner
Author
|
Estado del CI en este PR:
Generated by Claude Code |
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
El job Tests de
mainestá en rojo desde el merge de #3. Es el primer run en el que CI corre la suite de tests. El único fallo estest/bridge-opencode.test.cjs, en el caso "--unlink removes bridge links and keeps foreign files" (mensaje:bridge link gone).Causa:
do_unlinkcomparareadlink -f "$dest"(ruta canónica) contra"$STORE/<sub>/<archivo>", que no está canonizada. En macOSos.tmpdir()es/var/folders/..., y/vares un symlink a/private/var, así que las dos rutas nunca coinciden:--unlinksale con 0 sin quitar ningún enlace. En Linux pasa porque/tmpno es un symlink. Lo mismo le pasaría a cualquier usuario cuyo store esté detrás de un symlink.Arreglo: el lado del store también se canoniza (
pwd -P). Es un cambio de 5 líneas entools/bridge-opencode-privado.sh.Una vez que entre, conviene mezclar
mainen los PRs abiertos (#4 a #8) para que les corra CI en verde.Type of change
Evidence
Before
Log del job Tests en
main(2be6fb9):Reproducido en Linux con un store detrás de un symlink:
--unlink→exit=0y el enlacea.md -> …/alias/store/agent/a.mdsigue ahí. El test nuevo, contra el script anterior, sale✗ … 1 FAILURE(S).After
How I tested it
node test/bridge-opencode.test.cjscon el script anterior (rojo) y con el nuevo (verde); el caso de macOS se simula con un store alcanzado a través de un symlink.Checklist
🤖 Generated with Claude Code
Generated by Claude Code