Support payload for custom span#1587
Draft
CelianR wants to merge 31 commits into
Draft
Conversation
…and release as artifact
CelianR
changed the base branch from
master
to
celian/innovation-week-25q1-custom-span
March 13, 2025 12:36
Datadog ReportBranch report: ✅ 0 Failed, 387 Passed, 0 Skipped, 1m 17.76s Total duration (1m 5.84s time saved) |
Base automatically changed from
celian/innovation-week-25q1-custom-span
to
master
April 15, 2025 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Adds an option to provide a payload such that
datadog-ciis executed only once for multiple calls.It will be useful to avoid extra overhead when uploading several custom spans at once.
Here is an example payload sending two spans:
[ { "name": "hello", "startTimeInMs": 42, "endTimeInMs": 618, "tags": ["hello:world", "super:mario"], "measures": ["life:42", "hey:618", "ho:1618"] }, { "name": "hello2", "startTimeInMs": 43, "endTimeInMs": 619, "tags": ["bonjour:monde", "super:luigi"], "measures": ["life:43", "hey:619", "ho:1619"] } ]How?
Mostly refactoring, the payload is a json file containing an array of arguments.
Review checklist