Conversation
method to remove the boilerplate to start a trace agent, and only return the flushers, channel, and processor
from `manual_flush` to `flush` and `flush` to `send`
its `3.2` MB
generic `prost::Message` aggregator which batches given a `max_content_size_bytes`
a flusher should only flush, not receive messages, we abstract that from here
now the `TraceAgent` spins up a task which receives the stats so that they get properly aggregated
also modify the existing aggregator to be a stats agregator
also modified the naming import for `StatsFlusher`
it doesnt need the flushers to work, so removing that from it, and spawning own tasks for the data channels
it seems adding `prost::Message` import allows us to have the methods directly from the message we are treating with
alexgallotta
force-pushed
the
alexgallotta/refactor
branch
from
23f448d to
7aa4644
Compare
Contributor
|
Closing due to stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.