Add new version of DatadogPodAutoscaler CRD #1621
Open
+3,161
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbartosik
changed the title
jbartosik
force-pushed
the
CASCL-120-new-ddas-crd
branch
3 times, most recently
from
3c1e64d to
2f562af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
=======================================
Coverage 49.14% 49.14%
=======================================
Files 218 218
Lines 21017 21017
=======================================
Hits 10328 10328
Misses 10148 10148
Partials 541 541
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
jbartosik
force-pushed
the
CASCL-120-new-ddas-crd
branch
4 times, most recently
from
32b049f to
fb5a478
Compare
vboulineau
reviewed
Jan 21, 2025
vboulineau
reviewed
Jan 21, 2025
jbartosik
force-pushed
the
CASCL-120-new-ddas-crd
branch
7 times, most recently
from
eb18115 to
b188755
Compare
vboulineau
reviewed
Jan 29, 2025
| @@ -0,0 +1,749 @@ | |||
| { | |||
| "additionalProperties": false, | |||
There was a problem hiding this comment.
Leftover from v2alpha1 version, should be deleted.
There was a problem hiding this comment.
Still pending deletion!
jbartosik
force-pushed
the
CASCL-120-new-ddas-crd
branch
from
b188755 to
6cdfa1c
Compare
`operator-sdk create api --group datadoghq --kind DatadogPodAutoscaler --version v2alpha1`
Similar to v1alpah1, with the following changes: - `spec.policy` renamed to `spec.actuation` - `spec.policy.applyMode` replaced with `spec.actuation.mode` (allowed values `Apply` and `Preview`) - `spec.policy.upscale.match` and `spec.policy.donwscale.match` removed - `spec.policy.targets` renamed to `spec.policy.objectives` - `sepc.policy.contraints.containers[].limits` removed
jbartosik
force-pushed
the
CASCL-120-new-ddas-crd
branch
from
c06ea28 to
580f389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel