-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correlate traces to profiles with the OTel ebpf profiler #197
base: main
Are you sure you want to change the base?
Conversation
c0d6295
to
fe712b5
Compare
What do we think of using something like |
My 2 cents here: if the code does not add a big compile time, I think we will pay more in code readibility by adding #ifdef (as the code is split into multiple files) than we will win in compile time. It can be worth adding some comments to tell it will only work in Linux though. |
Noted, thanks for your input! |
ef34efa
to
a9f4269
Compare
5bbe694
to
475ab08
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 90.21% 90.29% +0.08%
==========================================
Files 79 79
Lines 4672 4721 +49
==========================================
+ Hits 4215 4263 +48
- Misses 457 458 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
475ab08
to
1282c6d
Compare
FYI, the global variables' naming is not set in stone. We plan on moving towards something more generic that does not use the elastic name. Additionally, I am in the process of a writing a problem statement regarding the way we share process data since dd-trace-cpp already shares that data through memfds. |
8984269
to
fb5241b
Compare
6dc9ac6
to
a817fa6
Compare
What's left to do here is figure how we want to handle runtime-ids in case of forks. |
* include/datadog/tracer.h * include/datadog/tracer_signature.h * src/datadog/tracer.cpp
a817fa6
to
7014f7a
Compare
* BUILD.bazel * include/datadog/tls_storage.h * include/datadog/trace_segment.h * include/datadog/tracer.h * src/datadog/trace_segment.cpp * src/datadog/tracer.cpp
* include/datadog/environment.h * include/datadog/tracer.h * include/datadog/tracer_config.h * src/datadog/tracer.cpp * src/datadog/tracer_config.cpp
* test/test_tracer.cpp * test/test_tracer_config.cpp
7014f7a
to
45310ad
Compare
Description
Based on Elastic's work to correlate traces to profiles for Java using the ebpf profiler.