Skip to content

chore: disable data pipeline by default #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: disable data pipeline by default #7055

wants to merge 1 commit into from
+1 −1

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 3, 2025

Summary of changes

Disable data pipeline by default. We will use our phased rollout strategy to enable.

Reason for change

Context https://github.com/DataDog/dd-trace-dotnet/pull/6314/files#r1995659318

Implementation details

Flipped the config

Test coverage

Other details

@ganeshnj ganeshnj requested a review from a team as a code owner June 3, 2025 19:03
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 3, 2025 •
edited
Loading

Datadog Report

All test runs 40a4f89 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 258534 2504 18h 3m 30.86s Link
exploration_tests 0 0 0 22085 3 2m 15.37s Link

@andrewlock
Copy link
Member

andrewlock commented Jun 3, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7055) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7055) - mean (1,013ms)  : 992, 1035
     .   : milestone, 1013,
    master - mean (1,018ms)  : 1004, 1032
     .   : milestone, 1018,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7055) - mean (103ms)  : 100, 105
     .   : milestone, 103,
    master - mean (102ms)  : 101, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7055) - mean (700ms)  : 682, 719
     .   : milestone, 700,
    master - mean (699ms)  : 689, 710
     .   : milestone, 699,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7055) - mean (90ms)  : 87, 92
     .   : milestone, 90,
    master - mean (89ms)  : 88, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7055) - mean (659ms)  : 641, 677
     .   : milestone, 659,
    master - mean (668ms)  : 649, 687
     .   : milestone, 668,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7055) - mean (190ms)  : 185, 194
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7055) - mean (1,121ms)  : 1090, 1152
     .   : milestone, 1121,
    master - mean (1,163ms)  : 1146, 1180
     .   : milestone, 1163,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7055) - mean (269ms)  : 265, 274
     .   : milestone, 269,
    master - mean (268ms)  : 265, 271
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7055) - mean (882ms)  : 856, 908
     .   : milestone, 882,
    master - mean (930ms)  : 917, 944
     .   : milestone, 930,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7055) - mean (263ms)  : 259, 266
     .   : milestone, 263,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (7055) - mean (871ms)  : 845, 897
     .   : milestone, 871,
    master - mean (927ms)  : 909, 944
     .   : milestone, 927,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7055 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.247
  • 3 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7055 StartStopWithChild net6.0 10.2μs 58.5ns 434ns 0 0 0 5.57 KB
#7055 StartStopWithChild netcoreapp3.1 13.4μs 66.2ns 281ns 0 0 0 5.77 KB
#7055 StartStopWithChild net472 22.2μs 115ns 529ns 1.03 0.31 0.103 6.11 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7055 WriteAndFlushEnrichedTraces net6.0 928μs 45.5ns 164ns 0 0 0 2.71 KB
#7055 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 59.3ns 205ns 0 0 0 2.7 KB
#7055 WriteAndFlushEnrichedTraces net472 1.31ms 147ns 568ns 0 0 0 3.33 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7055 AllCycleSimpleBody net6.0 325μs 1.67μs 7.85μs 0 0 0 197.41 KB
#7055 AllCycleSimpleBody netcoreapp3.1 506μs 1.95μs 7.56μs 0 0 0 205.17 KB
#7055 AllCycleSimpleBody net472 441μs 148ns 512ns 36.6 2.16 0 236.95 KB
#7055 AllCycleMoreComplexBody net6.0 339μs 154ns 595ns 0 0 0 200.92 KB
#7055 AllCycleMoreComplexBody netcoreapp3.1 491μs 2.35μs 10.2μs 0 0 0 208.58 KB
#7055 AllCycleMoreComplexBody net472 449μs 160ns 618ns 37.9 2.23 0 240.46 KB
#7055 ObjectExtractorSimpleBody net6.0 310ns 1.72ns 10ns 0 0 0 280 B
#7055 ObjectExtractorSimpleBody netcoreapp3.1 399ns 1.76ns 7.47ns 0 0 0 272 B
#7055 ObjectExtractorSimpleBody net472 304ns 0.0179ns 0.0645ns 0.0444 0 0 281 B
#7055 ObjectExtractorMoreComplexBody net6.0 6.32μs 26.8ns 104ns 0 0 0 3.78 KB
#7055 ObjectExtractorMoreComplexBody netcoreapp3.1 7.68μs 35.2ns 141ns 0 0 0 3.69 KB
#7055 ObjectExtractorMoreComplexBody net472 6.98μs 2.83ns 11ns 0.594 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7055

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net472 2.16 KB 2.17 KB 12 B 0.56%

Fewer allocations 🎉 in #7055

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7055 EncodeArgs net6.0 73.1μs 262ns 1.01μs 0 0 0 32.4 KB
#7055 EncodeArgs netcoreapp3.1 94.6μs 196ns 760ns 0 0 0 32.4 KB
#7055 EncodeArgs net472 106μs 21.1ns 79.1ns 4.77 0 0 32.5 KB
#7055 EncodeLegacyArgs net6.0 146μs 403ns 1.56μs 0 0 0 2.15 KB
#7055 EncodeLegacyArgs netcoreapp3.1 195μs 128ns 477ns 0 0 0 2.14 KB
#7055 EncodeLegacyArgs net472 264μs 54.3ns 210ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7055

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 2.28 KB 2.3 KB 12 B 0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7055 RunWafRealisticBenchmark net6.0 271μs 90.9ns 352ns 0 0 0 4.55 KB
#7055 RunWafRealisticBenchmark netcoreapp3.1 288μs 103ns 372ns 0 0 0 4.48 KB
#7055 RunWafRealisticBenchmark net472 308μs 36.8ns 142ns 0 0 0 4.66 KB
#7055 RunWafRealisticBenchmarkWithAttack net6.0 181μs 55.1ns 206ns 0 0 0 2.24 KB
#7055 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 195μs 138ns 536ns 0 0 0 2.22 KB
#7055 RunWafRealisticBenchmarkWithAttack net472 207μs 34.7ns 134ns 0 0 0 2.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7055 SendRequest net6.0 62.6μs 120ns 464ns 0 0 0 14.53 KB
#7055 SendRequest netcoreapp3.1 71.1μs 264ns 1.52μs 0 0 0 17.42 KB
#7055 SendRequest net472 0.00998ns 0.00253ns 0.00981ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7055

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.05 KB 295 B 0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7055 WriteAndFlushEnrichedTraces net6.0 666μs 1.13μs 5.29μs 0 0 0 41.56 KB
#7055 WriteAndFlushEnrichedTraces netcoreapp3.1 701μs 4.09μs 39μs 0 0 0 41.94 KB
#7055 WriteAndFlushEnrichedTraces net472 868μs 2.17μs 8.4μs 8.33 0 0 56.05 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7055 ExecuteNonQuery net6.0 2.15μs 10.4ns 42.8ns 0 0 0 1.03 KB
#7055 ExecuteNonQuery netcoreapp3.1 2.56μs 3.08ns 11.9ns 0 0 0 1.02 KB
#7055 ExecuteNonQuery net472 2.74μs 4.5ns 17.4ns 0.152 0.0138 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7055 CallElasticsearch net6.0 1.78μs 2.45ns 9.48ns 0 0 0 1.04 KB
#7055 CallElasticsearch netcoreapp3.1 2.31μs 9.35ns 36.2ns 0 0 0 1.04 KB
#7055 CallElasticsearch net472 3.61μs 4.18ns 16.2ns 0.162 0 0 1.05 KB
#7055 CallElasticsearchAsync net6.0 1.86μs 2.3ns 8.62ns 0 0 0 1.02 KB
#7055 CallElasticsearchAsync netcoreapp3.1 2.47μs 4.17ns 16.1ns 0 0 0 1.09 KB
#7055 CallElasticsearchAsync net472 3.69μs 1.19ns 4.45ns 0.165 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7055 ExecuteAsync net6.0 1.78μs 6.85ns 26.5ns 0 0 0 960 B
#7055 ExecuteAsync netcoreapp3.1 2.26μs 7.32ns 27.4ns 0 0 0 960 B
#7055 ExecuteAsync net472 2.56μs 0.924ns 3.46ns 0.141 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7055 SendAsync net6.0 6.95μs 16ns 61.9ns 0 0 0 2.37 KB
#7055 SendAsync netcoreapp3.1 8.7μs 23.7ns 88.6ns 0 0 0 2.9 KB
#7055 SendAsync net472 12.4μs 8.95ns 34.7ns 0.496 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7055

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.247 413,700.00 515,700.00

More allocations ⚠️ in #7055

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 44.1 KB 1.46 KB 3.43%

Fewer allocations 🎉 in #7055

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 43.1 KB -728 B -1.66%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 256.6 KB -18.33 KB -6.67%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7055 StringConcatBenchmark net6.0 44.3μs 234ns 1.57μs 0 0 0 43.1 KB
#7055 StringConcatBenchmark netcoreapp3.1 46.7μs 125ns 501ns 0 0 0 44.1 KB
#7055 StringConcatBenchmark net472 56.7μs 263ns 1.05μs 0 0 0 57.34 KB
#7055 StringConcatAspectBenchmark net6.0 447μs 2μs 7.76μs 0 0 0 260.33 KB
#7055 StringConcatAspectBenchmark netcoreapp3.1 519μs 2.54μs 10.5μs 0 0 0 256.6 KB
#7055 StringConcatAspectBenchmark net472 405μs 1.65μs 5.93μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7055 EnrichedLog net6.0 2.55μs 14.2ns 87.6ns 0 0 0 1.76 KB
#7055 EnrichedLog netcoreapp3.1 3.46μs 17.7ns 75.2ns 0 0 0 1.76 KB
#7055 EnrichedLog net472 3.81μs 4.44ns 17.2ns 0.263 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7055 EnrichedLog net6.0 125μs 361ns 1.35μs 0 0 0 4.37 KB
#7055 EnrichedLog netcoreapp3.1 128μs 205ns 767ns 0 0 0 4.37 KB
#7055 EnrichedLog net472 167μs 67.7ns 235ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7055 EnrichedLog net6.0 4.91μs 23.5ns 93.9ns 0 0 0 2.32 KB
#7055 EnrichedLog netcoreapp3.1 6.84μs 23.1ns 89.6ns 0 0 0 2.32 KB
#7055 EnrichedLog net472 7.43μs 4.09ns 14.2ns 0.334 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7055 SendReceive net6.0 1.98μs 9.54ns 38.2ns 0 0 0 1.21 KB
#7055 SendReceive netcoreapp3.1 2.52μs 12.2ns 47.2ns 0 0 0 1.21 KB
#7055 SendReceive net472 3.16μs 1.33ns 5.16ns 0.189 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7055 EnrichedLog net6.0 4.19μs 11.8ns 44.3ns 0 0 0 1.64 KB
#7055 EnrichedLog netcoreapp3.1 5.64μs 16.6ns 64.3ns 0 0 0 1.69 KB
#7055 EnrichedLog net472 7.28μs 6.8ns 26.3ns 0.327 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7055 StartFinishSpan net6.0 742ns 3.93ns 21.5ns 0 0 0 584 B
#7055 StartFinishSpan netcoreapp3.1 945ns 4.33ns 16.8ns 0 0 0 584 B
#7055 StartFinishSpan net472 917ns 0.319ns 1.24ns 0.0919 0 0 586 B
#7055 StartFinishScope net6.0 904ns 0.334ns 1.29ns 0 0 0 704 B
#7055 StartFinishScope netcoreapp3.1 1.14μs 5.99ns 30.5ns 0 0 0 704 B
#7055 StartFinishScope net472 1.11μs 0.188ns 0.678ns 0.105 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7055 RunOnMethodBegin net6.0 1.02μs 5.23ns 25.1ns 0 0 0 704 B
#7055 RunOnMethodBegin netcoreapp3.1 1.3μs 6.75ns 34.4ns 0 0 0 704 B
#7055 RunOnMethodBegin net472 1.38μs 0.293ns 1.1ns 0.103 0 0 666 B

Base automatically changed from ganeshnj/feature/datapipeline-bindings to master June 4, 2025 08:54
@ganeshnj ganeshnj requested review from a team as code owners June 4, 2025 08:54
@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Jun 4, 2025
@ganeshnj ganeshnj force-pushed the ganeshnj/feat/default-disable branch from a8da666 to 40a4f89 Compare June 4, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshnj @andrewlock