Skip to content

[v2] Span Events native support and graphql error reporting #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 31, 2025

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Mar 24, 2025

What does this PR do?

v2 PR for #3176

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 24, 2025

Datadog Report

Branch report: rarguelloF/AIDM-566/v2-span-events
Commit report: 834397c
Test service: dd-trace-go

✅ 0 Failed, 4440 Passed, 66 Skipped, 3m 50.09s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 24, 2025

Benchmarks

Benchmark execution time: 2025-03-31 15:17:02

Comparing candidate commit 27fd6cf in PR branch rarguelloF/AIDM-566/v2-span-events with baseline commit eb85ea1 in branch v2-dev.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 1 unstable metrics.

scenario:BenchmarkPartialFlushing/Disabled-24

  • 🟥 allocated_mem [+7.889MB; +8.038MB] or [+2.366%; +2.411%]

scenario:BenchmarkPartialFlushing/Enabled-24

  • 🟩 allocated_mem [-59.617MB; -54.867MB] or [-13.976%; -12.863%]
  • 🟩 avgHeapInUse(Mb) [-19.053MB; -14.285MB] or [-27.621%; -20.708%]

@rarguelloF rarguelloF marked this pull request as ready for review March 25, 2025 09:09
@rarguelloF rarguelloF requested review from a team as code owners March 25, 2025 09:09
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 25, 2025
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Same sentiment as in #3176 (review)

@rarguelloF rarguelloF merged commit 1cb84a3 into v2-dev Mar 31, 2025
181 of 198 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/AIDM-566/v2-span-events branch March 31, 2025 15:48
@darccio darccio added the v2.0 label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants