Skip to content

.github/workflows: check go.work.sum freshness #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

eliottness
Copy link
Contributor

What does this PR do?

  • Commit a fresh version of go.work.sum file
  • Add a check that would fail if it's not the case

Motivation

Discussed in guild meeting: go.work.sum choose have the same role as go.sum in our monorepo-multi-module case that is dd-trace-go

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@eliottness eliottness force-pushed the eliottness/go-work-smoke-test branch from c6db993 to f16d6ae Compare March 26, 2025 15:34
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 26, 2025

Datadog Report

Branch report: eliottness/go-work-smoke-test
Commit report: 2913e8e
Test service: dd-trace-go

✅ 0 Failed, 4479 Passed, 66 Skipped, 28m 5.06s Total Time

@eliottness eliottness marked this pull request as ready for review March 26, 2025 15:34
@eliottness eliottness requested review from a team as code owners March 26, 2025 15:34
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2025

Benchmarks

Benchmark execution time: 2025-03-26 16:03:30

Comparing candidate commit f16d6ae in PR branch eliottness/go-work-smoke-test with baseline commit 00da388 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

@eliottness eliottness merged commit 0b8b4d6 into v2-dev Mar 27, 2025
175 checks passed
@eliottness eliottness deleted the eliottness/go-work-smoke-test branch March 27, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants