Skip to content

Allow running wallclock profiler even without tracer #10298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbachorik merged 5 commits into from
Jan 31, 2026
Merged

Allow running wallclock profiler even without tracer #10298

jbachorik merged 5 commits into from
Jan 31, 2026
+203 −39

Conversation

@jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Jan 7, 2026 •
edited
Loading

What Does This Do

Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.

Motivation

There are users that want to run profiler without tracer (sic). For those, the wallclock profiling is not possible, ATM. This is fixing that gap.

Additional Notes

This PR requires bumping the Java profiler library to 1.37.0

Contributor Checklist

Jira ticket: PROF-13347

@pr-commenter
Copy link

pr-commenter bot commented Jan 7, 2026 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/wallclock_filter
git_commit_date 1769843538 1769857197
git_commit_sha 0253f31 6b97492
release_version 1.59.0-SNAPSHOT~0253f3130c 1.59.0-SNAPSHOT~6b9749254c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1769859080 1769859080
ci_job_id 1391812096 1391812096
ci_pipeline_id 93960076 93960076
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-a56wect5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-a56wect5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077791
Total [baseline] (10.949 s) : 0, 10948735
Agent [candidate] (1.071 s) : 0, 1071202
Total [candidate] (10.902 s) : 0, 10901742
section appsec
Agent [baseline] (1.252 s) : 0, 1252048
Total [baseline] (11.043 s) : 0, 11043465
Agent [candidate] (1.237 s) : 0, 1236905
Total [candidate] (11.0 s) : 0, 10999870
section iast
Agent [baseline] (1.252 s) : 0, 1251908
Total [baseline] (11.177 s) : 0, 11177394
Agent [candidate] (1.247 s) : 0, 1246608
Total [candidate] (11.255 s) : 0, 11254826
section profiling
Agent [baseline] (1.193 s) : 0, 1192753
Total [baseline] (11.08 s) : 0, 11080004
Agent [candidate] (1.189 s) : 0, 1189002
Total [candidate] (11.031 s) : 0, 11030842
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.252 s 174.256 ms (16.2%)
Agent iast 1.252 s 174.116 ms (16.2%)
Agent profiling 1.193 s 114.962 ms (10.7%)
Total tracing 10.949 s -
Total appsec 11.043 s 94.73 ms (0.9%)
Total iast 11.177 s 228.66 ms (2.1%)
Total profiling 11.08 s 131.27 ms (1.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.237 s 165.703 ms (15.5%)
Agent iast 1.247 s 175.407 ms (16.4%)
Agent profiling 1.189 s 117.8 ms (11.0%)
Total tracing 10.902 s -
Total appsec 11.0 s 98.127 ms (0.9%)
Total iast 11.255 s 353.084 ms (3.2%)
Total profiling 11.031 s 129.1 ms (1.2%) 
gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (636.377 ms) : 0, 636377
BytebuddyAgent [candidate] (632.466 ms) : 0, 632466
AgentMeter [baseline] (29.185 ms) : 0, 29185
AgentMeter [candidate] (29.014 ms) : 0, 29014
GlobalTracer [baseline] (260.745 ms) : 0, 260745
GlobalTracer [candidate] (259.1 ms) : 0, 259100
AppSec [baseline] (33.25 ms) : 0, 33250
AppSec [candidate] (33.081 ms) : 0, 33081
Debugger [baseline] (61.297 ms) : 0, 61297
Debugger [candidate] (60.913 ms) : 0, 60913
Remote Config [baseline] (626.912 µs) : 0, 627
Remote Config [candidate] (638.843 µs) : 0, 639
Telemetry [baseline] (14.106 ms) : 0, 14106
Telemetry [candidate] (11.494 ms) : 0, 11494
Flare Poller [baseline] (5.323 ms) : 0, 5323
Flare Poller [candidate] (7.745 ms) : 0, 7745
section appsec
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (665.004 ms) : 0, 665004
BytebuddyAgent [candidate] (656.233 ms) : 0, 656233
AgentMeter [baseline] (11.904 ms) : 0, 11904
AgentMeter [candidate] (11.795 ms) : 0, 11795
GlobalTracer [baseline] (261.076 ms) : 0, 261076
GlobalTracer [candidate] (258.269 ms) : 0, 258269
IAST [baseline] (25.776 ms) : 0, 25776
IAST [candidate] (25.199 ms) : 0, 25199
AppSec [baseline] (169.356 ms) : 0, 169356
AppSec [candidate] (167.835 ms) : 0, 167835
Debugger [baseline] (68.158 ms) : 0, 68158
Debugger [candidate] (67.426 ms) : 0, 67426
Remote Config [baseline] (701.034 µs) : 0, 701
Remote Config [candidate] (664.749 µs) : 0, 665
Telemetry [baseline] (9.423 ms) : 0, 9423
Telemetry [candidate] (9.273 ms) : 0, 9273
Flare Poller [baseline] (3.768 ms) : 0, 3768
Flare Poller [candidate] (3.645 ms) : 0, 3645
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (811.907 ms) : 0, 811907
BytebuddyAgent [candidate] (807.835 ms) : 0, 807835
AgentMeter [baseline] (11.886 ms) : 0, 11886
AgentMeter [candidate] (11.517 ms) : 0, 11517
GlobalTracer [baseline] (250.286 ms) : 0, 250286
GlobalTracer [candidate] (249.709 ms) : 0, 249709
IAST [baseline] (27.274 ms) : 0, 27274
IAST [candidate] (27.086 ms) : 0, 27086
AppSec [baseline] (34.304 ms) : 0, 34304
AppSec [candidate] (31.287 ms) : 0, 31287
Debugger [baseline] (66.697 ms) : 0, 66697
Debugger [candidate] (69.358 ms) : 0, 69358
Remote Config [baseline] (540.001 µs) : 0, 540
Remote Config [candidate] (550.875 µs) : 0, 551
Telemetry [baseline] (8.686 ms) : 0, 8686
Telemetry [candidate] (8.805 ms) : 0, 8805
Flare Poller [baseline] (3.412 ms) : 0, 3412
Flare Poller [candidate] (3.478 ms) : 0, 3478
section profiling
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (681.871 ms) : 0, 681871
BytebuddyAgent [candidate] (681.315 ms) : 0, 681315
AgentMeter [baseline] (8.645 ms) : 0, 8645
AgentMeter [candidate] (8.634 ms) : 0, 8634
GlobalTracer [baseline] (216.744 ms) : 0, 216744
GlobalTracer [candidate] (215.719 ms) : 0, 215719
AppSec [baseline] (32.706 ms) : 0, 32706
AppSec [candidate] (32.327 ms) : 0, 32327
Debugger [baseline] (68.357 ms) : 0, 68357
Debugger [candidate] (67.622 ms) : 0, 67622
Remote Config [baseline] (604.592 µs) : 0, 605
Remote Config [candidate] (599.984 µs) : 0, 600
Telemetry [baseline] (8.874 ms) : 0, 8874
Telemetry [candidate] (8.868 ms) : 0, 8868
Flare Poller [baseline] (3.822 ms) : 0, 3822
Flare Poller [candidate] (3.748 ms) : 0, 3748
ProfilingAgent [baseline] (99.994 ms) : 0, 99994
ProfilingAgent [candidate] (99.108 ms) : 0, 99108
Profiling [baseline] (100.567 ms) : 0, 100567
Profiling [candidate] (99.671 ms) : 0, 99671
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069026
Total [baseline] (8.815 s) : 0, 8814798
Agent [candidate] (1.062 s) : 0, 1062105
Total [candidate] (8.777 s) : 0, 8776614
section iast
Agent [baseline] (1.228 s) : 0, 1228349
Total [baseline] (9.331 s) : 0, 9331367
Agent [candidate] (1.233 s) : 0, 1232922
Total [candidate] (9.419 s) : 0, 9419386
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.228 s 159.323 ms (14.9%)
Total tracing 8.815 s -
Total iast 9.331 s 516.569 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.233 s 170.817 ms (16.1%)
Total tracing 8.777 s -
Total iast 9.419 s 642.771 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (631.923 ms) : 0, 631923
BytebuddyAgent [candidate] (627.242 ms) : 0, 627242
AgentMeter [baseline] (28.957 ms) : 0, 28957
AgentMeter [candidate] (28.673 ms) : 0, 28673
GlobalTracer [baseline] (259.023 ms) : 0, 259023
GlobalTracer [candidate] (257.57 ms) : 0, 257570
AppSec [baseline] (33.145 ms) : 0, 33145
AppSec [candidate] (32.717 ms) : 0, 32717
Debugger [baseline] (62.526 ms) : 0, 62526
Debugger [candidate] (60.237 ms) : 0, 60237
Remote Config [baseline] (621.863 µs) : 0, 622
Remote Config [candidate] (612.982 µs) : 0, 613
Telemetry [baseline] (12.371 ms) : 0, 12371
Telemetry [candidate] (13.161 ms) : 0, 13161
Flare Poller [baseline] (3.791 ms) : 0, 3791
Flare Poller [candidate] (5.352 ms) : 0, 5352
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (794.347 ms) : 0, 794347
BytebuddyAgent [candidate] (796.782 ms) : 0, 796782
AgentMeter [baseline] (11.131 ms) : 0, 11131
AgentMeter [candidate] (11.207 ms) : 0, 11207
GlobalTracer [baseline] (247.107 ms) : 0, 247107
GlobalTracer [candidate] (248.439 ms) : 0, 248439
IAST [baseline] (26.942 ms) : 0, 26942
IAST [candidate] (27.053 ms) : 0, 27053
AppSec [baseline] (33.828 ms) : 0, 33828
AppSec [candidate] (32.332 ms) : 0, 32332
Debugger [baseline] (65.581 ms) : 0, 65581
Debugger [candidate] (67.897 ms) : 0, 67897
Remote Config [baseline] (560.903 µs) : 0, 561
Remote Config [candidate] (555.766 µs) : 0, 556
Telemetry [baseline] (8.659 ms) : 0, 8659
Telemetry [candidate] (8.683 ms) : 0, 8683
Flare Poller [baseline] (3.49 ms) : 0, 3490
Flare Poller [candidate] (3.439 ms) : 0, 3439
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/wallclock_filter
git_commit_date 1769843538 1769857197
git_commit_sha 0253f31 6b97492
release_version 1.59.0-SNAPSHOT~0253f3130c 1.59.0-SNAPSHOT~6b9749254c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1769859732 1769859732
ci_job_id 1391812098 1391812098
ci_pipeline_id 93960076 93960076
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-a3scms93 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-a3scms93 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-229.760µs; -90.956µs] or [-8.118%; -3.214%]		 unsure
[-624.751µs; -34.567µs] or [-7.845%; -0.434%]		 unstable
[-53.409op/s; +196.284op/s] or [-4.214%; +15.486%]		 2.670ms 7.634ms 1338.938op/s 2.830ms 7.964ms 1267.500op/s
scenario:load:petclinic:iast:high_load worse
[+0.840ms; +1.700ms] or [+4.839%; +9.792%]		 worse
[+0.751ms; +2.083ms] or [+2.635%; +7.310%]		 unstable
[-40.523op/s; +7.460op/s] or [-15.391%; +2.834%]		 18.632ms 29.918ms 246.750op/s 17.362ms 28.501ms 263.281op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.254 ms) : 1242, 1266
.   : milestone, 1254,
iast (3.229 ms) : 3186, 3272
.   : milestone, 3229,
iast_FULL (5.75 ms) : 5694, 5807
.   : milestone, 5750,
iast_GLOBAL (3.62 ms) : 3554, 3686
.   : milestone, 3620,
profiling (2.124 ms) : 2101, 2147
.   : milestone, 2124,
tracing (1.769 ms) : 1755, 1783
.   : milestone, 1769,
section candidate
no_agent (1.177 ms) : 1166, 1188
.   : milestone, 1177,
iast (3.206 ms) : 3162, 3251
.   : milestone, 3206,
iast_FULL (5.789 ms) : 5731, 5847
.   : milestone, 5789,
iast_GLOBAL (3.42 ms) : 3372, 3469
.   : milestone, 3420,
profiling (2.075 ms) : 2056, 2094
.   : milestone, 2075,
tracing (1.797 ms) : 1783, 1811
.   : milestone, 1797,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.254 ms [1.242 ms, 1.266 ms] -
iast 3.229 ms [3.186 ms, 3.272 ms] 1.975 ms (157.5%)
iast_FULL 5.75 ms [5.694 ms, 5.807 ms] 4.497 ms (358.7%)
iast_GLOBAL 3.62 ms [3.554 ms, 3.686 ms] 2.366 ms (188.7%)
profiling 2.124 ms [2.101 ms, 2.147 ms] 870.504 µs (69.4%)
tracing 1.769 ms [1.755 ms, 1.783 ms] 514.919 µs (41.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.177 ms [1.166 ms, 1.188 ms] -
iast 3.206 ms [3.162 ms, 3.251 ms] 2.029 ms (172.4%)
iast_FULL 5.789 ms [5.731 ms, 5.847 ms] 4.612 ms (391.9%)
iast_GLOBAL 3.42 ms [3.372 ms, 3.469 ms] 2.244 ms (190.6%)
profiling 2.075 ms [2.056 ms, 2.094 ms] 898.227 µs (76.3%)
tracing 1.797 ms [1.783 ms, 1.811 ms] 620.181 µs (52.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.168 ms) : 16994, 17341
.   : milestone, 17168,
appsec (18.975 ms) : 18780, 19170
.   : milestone, 18975,
code_origins (17.595 ms) : 17420, 17770
.   : milestone, 17595,
iast (17.72 ms) : 17545, 17896
.   : milestone, 17720,
profiling (18.821 ms) : 18633, 19008
.   : milestone, 18821,
tracing (17.673 ms) : 17496, 17850
.   : milestone, 17673,
section candidate
no_agent (18.092 ms) : 17905, 18278
.   : milestone, 18092,
appsec (19.54 ms) : 19337, 19742
.   : milestone, 19540,
code_origins (17.595 ms) : 17422, 17768
.   : milestone, 17595,
iast (18.918 ms) : 18728, 19107
.   : milestone, 18918,
profiling (18.79 ms) : 18605, 18976
.   : milestone, 18790,
tracing (17.533 ms) : 17357, 17708
.   : milestone, 17533,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.168 ms [16.994 ms, 17.341 ms] -
appsec 18.975 ms [18.78 ms, 19.17 ms] 1.807 ms (10.5%)
code_origins 17.595 ms [17.42 ms, 17.77 ms] 427.109 µs (2.5%)
iast 17.72 ms [17.545 ms, 17.896 ms] 552.647 µs (3.2%)
profiling 18.821 ms [18.633 ms, 19.008 ms] 1.653 ms (9.6%)
tracing 17.673 ms [17.496 ms, 17.85 ms] 505.164 µs (2.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.092 ms [17.905 ms, 18.278 ms] -
appsec 19.54 ms [19.337 ms, 19.742 ms] 1.448 ms (8.0%)
code_origins 17.595 ms [17.422 ms, 17.768 ms] -496.836 µs (-2.7%)
iast 18.918 ms [18.728 ms, 19.107 ms] 825.994 µs (4.6%)
profiling 18.79 ms [18.605 ms, 18.976 ms] 698.584 µs (3.9%)
tracing 17.533 ms [17.357 ms, 17.708 ms] -559.093 µs (-3.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/wallclock_filter
git_commit_date 1769843538 1769857197
git_commit_sha 0253f31 6b97492
release_version 1.59.0-SNAPSHOT~0253f3130c 1.59.0-SNAPSHOT~6b9749254c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1769859281 1769859281
ci_job_id 1391812100 1391812100
ci_pipeline_id 93960076 93960076
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-l1wendcx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-l1wendcx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.312 s) : 15312000, 15312000
.   : milestone, 15312000,
appsec (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
iast (18.246 s) : 18246000, 18246000
.   : milestone, 18246000,
iast_GLOBAL (17.941 s) : 17941000, 17941000
.   : milestone, 17941000,
profiling (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
tracing (14.618 s) : 14618000, 14618000
.   : milestone, 14618000,
section candidate
no_agent (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
appsec (14.892 s) : 14892000, 14892000
.   : milestone, 14892000,
iast (18.384 s) : 18384000, 18384000
.   : milestone, 18384000,
iast_GLOBAL (17.833 s) : 17833000, 17833000
.   : milestone, 17833000,
profiling (14.724 s) : 14724000, 14724000
.   : milestone, 14724000,
tracing (14.86 s) : 14860000, 14860000
.   : milestone, 14860000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.312 s [15.312 s, 15.312 s] -
appsec 15.017 s [15.017 s, 15.017 s] -295.0 ms (-1.9%)
iast 18.246 s [18.246 s, 18.246 s] 2.934 s (19.2%)
iast_GLOBAL 17.941 s [17.941 s, 17.941 s] 2.629 s (17.2%)
profiling 14.957 s [14.957 s, 14.957 s] -355.0 ms (-2.3%)
tracing 14.618 s [14.618 s, 14.618 s] -694.0 ms (-4.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.058 s [15.058 s, 15.058 s] -
appsec 14.892 s [14.892 s, 14.892 s] -166.0 ms (-1.1%)
iast 18.384 s [18.384 s, 18.384 s] 3.326 s (22.1%)
iast_GLOBAL 17.833 s [17.833 s, 17.833 s] 2.775 s (18.4%)
profiling 14.724 s [14.724 s, 14.724 s] -334.0 ms (-2.2%)
tracing 14.86 s [14.86 s, 14.86 s] -198.0 ms (-1.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~6b9749254c, baseline=1.59.0-SNAPSHOT~0253f3130c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.478 ms) : 2423, 2532
.   : milestone, 2478,
iast (2.241 ms) : 2172, 2309
.   : milestone, 2241,
iast_GLOBAL (2.286 ms) : 2217, 2355
.   : milestone, 2286,
profiling (2.085 ms) : 2029, 2141
.   : milestone, 2085,
tracing (2.056 ms) : 2003, 2110
.   : milestone, 2056,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.744 ms) : 3523, 3965
.   : milestone, 3744,
iast (2.246 ms) : 2178, 2315
.   : milestone, 2246,
iast_GLOBAL (2.291 ms) : 2222, 2361
.   : milestone, 2291,
profiling (2.483 ms) : 2260, 2706
.   : milestone, 2483,
tracing (2.063 ms) : 2009, 2117
.   : milestone, 2063,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.478 ms [2.423 ms, 2.532 ms] 1.006 ms (68.3%)
iast 2.241 ms [2.172 ms, 2.309 ms] 769.069 µs (52.3%)
iast_GLOBAL 2.286 ms [2.217 ms, 2.355 ms] 814.495 µs (55.3%)
profiling 2.085 ms [2.029 ms, 2.141 ms] 613.36 µs (41.7%)
tracing 2.056 ms [2.003 ms, 2.11 ms] 584.634 µs (39.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 3.744 ms [3.523 ms, 3.965 ms] 2.272 ms (154.4%)
iast 2.246 ms [2.178 ms, 2.315 ms] 774.645 µs (52.6%)
iast_GLOBAL 2.291 ms [2.222 ms, 2.361 ms] 819.349 µs (55.7%)
profiling 2.483 ms [2.26 ms, 2.706 ms] 1.011 ms (68.7%)
tracing 2.063 ms [2.009 ms, 2.117 ms] 591.043 µs (40.2%)

@jbachorik jbachorik marked this pull request as ready for review January 7, 2026 10:46
@jbachorik jbachorik requested a review from a team as a code owner January 7, 2026 10:46
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jbachorik jbachorik added type: bug Bug report and fix comp: profiling Profiling labels Jan 7, 2026
@jbachorik jbachorik force-pushed the jb/wallclock_filter branch from 6997fe7 to a5f0d36 Compare January 7, 2026 13:34
@jbachorik jbachorik force-pushed the jb/wallclock_filter branch from 0ef488b to dde4964 Compare January 13, 2026 13:35
@jbachorik jbachorik enabled auto-merge (squash) January 13, 2026 13:42
r1viollet
r1viollet approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The user might notice more overhead by triggering this, though as this is an explicit setting, we can add a warning in the doc.

@jbachorik jbachorik force-pushed the jb/wallclock_filter branch from 09f26d2 to 6e4ac29 Compare January 21, 2026 16:40
@jbachorik
Allow running wallclock profiler even without tracer
0374059 
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
@jbachorik
Simplify changes
1dc1321
@jbachorik
Bump ddprof to 1.37.0
0e96483
@jbachorik jbachorik force-pushed the jb/wallclock_filter branch from 6e4ac29 to 0e96483 Compare January 30, 2026 13:46
@jbachorik jbachorik requested a review from a team as a code owner January 30, 2026 13:46
@jbachorik @claude
Fix wallclock profiling without tracing
cba4efb 
Explicitly pass filter= to ddprof when context filtering is disabled.
Due to ddprof quirk, omitting filter defaults to "0" (enabled), causing
zero samples when tracing is off. Empty filter disables it properly.

Added unit test to verify filter parameter in all scenarios.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@PerfectSlayer PerfectSlayer added the tag: dependencies Dependencies related changes label Jan 30, 2026
@jbachorik jbachorik merged commit c2d0978 into master Jan 31, 2026
545 checks passed
@jbachorik jbachorik deleted the jb/wallclock_filter branch January 31, 2026 11:53
@github-actions github-actions bot added this to the 1.59.0 milestone Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@zhengyu123 zhengyu123 zhengyu123 approved these changes

@rkennke rkennke Awaiting requested review from rkennke

+1 more reviewer

@r1viollet r1viollet r1viollet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: profiling Profiling tag: dependencies Dependencies related changes type: bug Bug report and fix

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jbachorik @PerfectSlayer @zhengyu123 @r1viollet