-
Notifications
You must be signed in to change notification settings - Fork 324
Caching the primaryInstrumentationName #10477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Caching the primaryInstrumentationName to avoid repeatedly calling instrumentationNames() and constantly allocating a String[]
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056507
Total [baseline] (8.72 s) : 0, 8720414
Agent [candidate] (1.057 s) : 0, 1056864
Total [candidate] (8.745 s) : 0, 8744777
section iast
Agent [baseline] (1.222 s) : 0, 1221687
Total [baseline] (9.335 s) : 0, 9334723
Agent [candidate] (1.238 s) : 0, 1237903
Total [candidate] (9.388 s) : 0, 9387855
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (622.501 ms) : 0, 622501
BytebuddyAgent [candidate] (623.84 ms) : 0, 623840
AgentMeter [baseline] (28.741 ms) : 0, 28741
AgentMeter [candidate] (28.626 ms) : 0, 28626
GlobalTracer [baseline] (257.15 ms) : 0, 257150
GlobalTracer [candidate] (257.047 ms) : 0, 257047
AppSec [baseline] (32.826 ms) : 0, 32826
AppSec [candidate] (33.076 ms) : 0, 33076
Debugger [baseline] (62.753 ms) : 0, 62753
Debugger [candidate] (59.396 ms) : 0, 59396
Remote Config [baseline] (600.673 µs) : 0, 601
Remote Config [candidate] (620.484 µs) : 0, 620
Telemetry [baseline] (9.062 ms) : 0, 9062
Telemetry [candidate] (11.419 ms) : 0, 11419
Flare Poller [baseline] (6.197 ms) : 0, 6197
Flare Poller [candidate] (6.066 ms) : 0, 6066
section iast
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (788.088 ms) : 0, 788088
BytebuddyAgent [candidate] (800.377 ms) : 0, 800377
AgentMeter [baseline] (11.162 ms) : 0, 11162
AgentMeter [candidate] (11.277 ms) : 0, 11277
GlobalTracer [baseline] (247.06 ms) : 0, 247060
GlobalTracer [candidate] (249.865 ms) : 0, 249865
AppSec [baseline] (33.892 ms) : 0, 33892
AppSec [candidate] (33.192 ms) : 0, 33192
Debugger [baseline] (65.653 ms) : 0, 65653
Debugger [candidate] (66.673 ms) : 0, 66673
Remote Config [baseline] (545.667 µs) : 0, 546
Remote Config [candidate] (550.291 µs) : 0, 550
Telemetry [baseline] (8.544 ms) : 0, 8544
Telemetry [candidate] (8.606 ms) : 0, 8606
Flare Poller [baseline] (3.523 ms) : 0, 3523
Flare Poller [candidate] (3.52 ms) : 0, 3520
IAST [baseline] (26.676 ms) : 0, 26676
IAST [candidate] (26.995 ms) : 0, 26995
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060674
Total [baseline] (10.952 s) : 0, 10951978
Agent [candidate] (1.06 s) : 0, 1060393
Total [candidate] (10.974 s) : 0, 10974349
section appsec
Agent [baseline] (1.239 s) : 0, 1239233
Total [baseline] (11.025 s) : 0, 11024647
Agent [candidate] (1.234 s) : 0, 1233731
Total [candidate] (11.132 s) : 0, 11131759
section iast
Agent [baseline] (1.231 s) : 0, 1230577
Total [baseline] (11.144 s) : 0, 11143814
Agent [candidate] (1.228 s) : 0, 1228043
Total [candidate] (11.141 s) : 0, 11140574
section profiling
Agent [baseline] (1.194 s) : 0, 1194150
Total [baseline] (10.971 s) : 0, 10971216
Agent [candidate] (1.186 s) : 0, 1185632
Total [candidate] (10.852 s) : 0, 10851821
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (623.81 ms) : 0, 623810
BytebuddyAgent [candidate] (623.525 ms) : 0, 623525
AgentMeter [baseline] (28.782 ms) : 0, 28782
AgentMeter [candidate] (28.739 ms) : 0, 28739
GlobalTracer [baseline] (257.299 ms) : 0, 257299
GlobalTracer [candidate] (257.163 ms) : 0, 257163
AppSec [baseline] (33.018 ms) : 0, 33018
AppSec [candidate] (32.874 ms) : 0, 32874
Debugger [baseline] (62.017 ms) : 0, 62017
Debugger [candidate] (60.308 ms) : 0, 60308
Remote Config [baseline] (608.8 µs) : 0, 609
Remote Config [candidate] (627.825 µs) : 0, 628
Telemetry [baseline] (9.315 ms) : 0, 9315
Telemetry [candidate] (10.762 ms) : 0, 10762
Flare Poller [baseline] (9.26 ms) : 0, 9260
Flare Poller [candidate] (9.827 ms) : 0, 9827
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (657.164 ms) : 0, 657164
BytebuddyAgent [candidate] (652.728 ms) : 0, 652728
AgentMeter [baseline] (11.915 ms) : 0, 11915
AgentMeter [candidate] (11.786 ms) : 0, 11786
GlobalTracer [baseline] (258.839 ms) : 0, 258839
GlobalTracer [candidate] (257.396 ms) : 0, 257396
AppSec [baseline] (168.809 ms) : 0, 168809
AppSec [candidate] (167.572 ms) : 0, 167572
Debugger [baseline] (66.943 ms) : 0, 66943
Debugger [candidate] (68.284 ms) : 0, 68284
Remote Config [baseline] (655.73 µs) : 0, 656
Remote Config [candidate] (683.095 µs) : 0, 683
Telemetry [baseline] (9.181 ms) : 0, 9181
Telemetry [candidate] (9.481 ms) : 0, 9481
Flare Poller [baseline] (3.55 ms) : 0, 3550
Flare Poller [candidate] (3.703 ms) : 0, 3703
IAST [baseline] (25.573 ms) : 0, 25573
IAST [candidate] (25.615 ms) : 0, 25615
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (793.513 ms) : 0, 793513
BytebuddyAgent [candidate] (791.937 ms) : 0, 791937
AgentMeter [baseline] (11.2 ms) : 0, 11200
AgentMeter [candidate] (11.199 ms) : 0, 11199
GlobalTracer [baseline] (248.719 ms) : 0, 248719
GlobalTracer [candidate] (248.445 ms) : 0, 248445
AppSec [baseline] (33.886 ms) : 0, 33886
AppSec [candidate] (34.707 ms) : 0, 34707
Debugger [baseline] (67.123 ms) : 0, 67123
Debugger [candidate] (65.697 ms) : 0, 65697
Remote Config [baseline] (555.994 µs) : 0, 556
Remote Config [candidate] (544.178 µs) : 0, 544
Telemetry [baseline] (8.551 ms) : 0, 8551
Telemetry [candidate] (8.593 ms) : 0, 8593
Flare Poller [baseline] (3.504 ms) : 0, 3504
Flare Poller [candidate] (3.511 ms) : 0, 3511
IAST [baseline] (26.93 ms) : 0, 26930
IAST [candidate] (26.926 ms) : 0, 26926
section profiling
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (682.232 ms) : 0, 682232
BytebuddyAgent [candidate] (677.715 ms) : 0, 677715
AgentMeter [baseline] (8.766 ms) : 0, 8766
AgentMeter [candidate] (8.635 ms) : 0, 8635
GlobalTracer [baseline] (218.0 ms) : 0, 218000
GlobalTracer [candidate] (216.318 ms) : 0, 216318
AppSec [baseline] (32.786 ms) : 0, 32786
AppSec [candidate] (32.194 ms) : 0, 32194
Debugger [baseline] (68.508 ms) : 0, 68508
Debugger [candidate] (67.542 ms) : 0, 67542
Remote Config [baseline] (593.218 µs) : 0, 593
Remote Config [candidate] (593.448 µs) : 0, 593
Telemetry [baseline] (8.694 ms) : 0, 8694
Telemetry [candidate] (8.706 ms) : 0, 8706
Flare Poller [baseline] (3.781 ms) : 0, 3781
Flare Poller [candidate] (3.74 ms) : 0, 3740
ProfilingAgent [baseline] (99.434 ms) : 0, 99434
ProfilingAgent [candidate] (98.739 ms) : 0, 98739
Profiling [baseline] (100.004 ms) : 0, 100004
Profiling [candidate] (99.308 ms) : 0, 99308
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.134 ms) : 3090, 3177
. : milestone, 3134,
iast_FULL (5.594 ms) : 5539, 5650
. : milestone, 5594,
iast_GLOBAL (3.346 ms) : 3297, 3395
. : milestone, 3346,
profiling (2.081 ms) : 2061, 2102
. : milestone, 2081,
tracing (1.905 ms) : 1888, 1922
. : milestone, 1905,
section candidate
no_agent (1.173 ms) : 1162, 1185
. : milestone, 1173,
iast (3.138 ms) : 3095, 3181
. : milestone, 3138,
iast_FULL (5.747 ms) : 5689, 5805
. : milestone, 5747,
iast_GLOBAL (3.521 ms) : 3467, 3575
. : milestone, 3521,
profiling (2.356 ms) : 2332, 2380
. : milestone, 2356,
tracing (1.806 ms) : 1791, 1822
. : milestone, 1806,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section baseline
no_agent (18.188 ms) : 18004, 18371
. : milestone, 18188,
appsec (18.604 ms) : 18416, 18792
. : milestone, 18604,
code_origins (18.335 ms) : 18151, 18519
. : milestone, 18335,
iast (17.834 ms) : 17656, 18012
. : milestone, 17834,
profiling (19.036 ms) : 18847, 19225
. : milestone, 19036,
tracing (17.453 ms) : 17281, 17625
. : milestone, 17453,
section candidate
no_agent (19.047 ms) : 18858, 19236
. : milestone, 19047,
appsec (18.451 ms) : 18264, 18638
. : milestone, 18451,
code_origins (17.578 ms) : 17405, 17752
. : milestone, 17578,
iast (17.774 ms) : 17598, 17950
. : milestone, 17774,
profiling (18.756 ms) : 18570, 18943
. : milestone, 18756,
tracing (17.806 ms) : 17629, 17983
. : milestone, 17806,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section baseline
no_agent (17.133 s) : 17133000, 17133000
. : milestone, 17133000,
appsec (15.373 s) : 15373000, 15373000
. : milestone, 15373000,
iast (18.314 s) : 18314000, 18314000
. : milestone, 18314000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
. : milestone, 17839000,
profiling (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
tracing (14.598 s) : 14598000, 14598000
. : milestone, 14598000,
section candidate
no_agent (15.164 s) : 15164000, 15164000
. : milestone, 15164000,
appsec (15.021 s) : 15021000, 15021000
. : milestone, 15021000,
iast (18.136 s) : 18136000, 18136000
. : milestone, 18136000,
iast_GLOBAL (17.842 s) : 17842000, 17842000
. : milestone, 17842000,
profiling (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
tracing (14.696 s) : 14696000, 14696000
. : milestone, 14696000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~46337eed2a, baseline=1.59.0-SNAPSHOT~93b3199d7c
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.488 ms) : 2434, 2543
. : milestone, 2488,
iast (2.243 ms) : 2174, 2312
. : milestone, 2243,
iast_GLOBAL (2.287 ms) : 2218, 2356
. : milestone, 2287,
profiling (2.499 ms) : 2336, 2663
. : milestone, 2499,
tracing (2.052 ms) : 1999, 2105
. : milestone, 2052,
section candidate
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (3.685 ms) : 3469, 3901
. : milestone, 3685,
iast (2.251 ms) : 2182, 2320
. : milestone, 2251,
iast_GLOBAL (2.283 ms) : 2214, 2352
. : milestone, 2283,
profiling (2.493 ms) : 2330, 2656
. : milestone, 2493,
tracing (2.058 ms) : 2004, 2111
. : milestone, 2058,
|
What Does This Do
Caching the primaryInstrumentationName to avoid repeatedly calling instrumentationNames and constantly allocating a String[]
Motivation
Avoid repetitive work and memory allocation
Additional Notes
The high load benchmarks are known to be flaky, but I wanted to double check the regressions anyway.
In a local load test, this change performed as expected...
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]