-
Notifications
You must be signed in to change notification settings - Fork 324
Fix Symbol extraction tests and Jacoco #10485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jacoco can inject synthetic field or methods inside classes for SymDB symbol extraction those injected symbols can make the tests non-consistent (IDE or gradle run) we are excluding those dynamically compiled classes from Jacoco coverage
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (332.283 µs) : 274, 391
. : milestone, 332,
basic (280.736 µs) : 274, 288
. : milestone, 281,
loop (8.952 ms) : 8945, 8958
. : milestone, 8952,
section candidate
noprobe (317.823 µs) : 287, 349
. : milestone, 318,
basic (276.573 µs) : 270, 283
. : milestone, 277,
loop (8.952 ms) : 8946, 8958
. : milestone, 8952,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061219
Total [baseline] (8.716 s) : 0, 8715670
Agent [candidate] (1.059 s) : 0, 1059136
Total [candidate] (8.706 s) : 0, 8705954
section iast
Agent [baseline] (1.231 s) : 0, 1231355
Total [baseline] (9.401 s) : 0, 9400890
Agent [candidate] (1.225 s) : 0, 1224640
Total [candidate] (9.367 s) : 0, 9367178
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (623.409 ms) : 0, 623409
BytebuddyAgent [candidate] (623.084 ms) : 0, 623084
AgentMeter [baseline] (28.979 ms) : 0, 28979
AgentMeter [candidate] (28.752 ms) : 0, 28752
GlobalTracer [baseline] (258.631 ms) : 0, 258631
GlobalTracer [candidate] (257.554 ms) : 0, 257554
AppSec [baseline] (33.018 ms) : 0, 33018
AppSec [candidate] (32.606 ms) : 0, 32606
Debugger [baseline] (59.759 ms) : 0, 59759
Debugger [candidate] (60.852 ms) : 0, 60852
Remote Config [baseline] (620.093 µs) : 0, 620
Remote Config [candidate] (605.062 µs) : 0, 605
Telemetry [baseline] (10.052 ms) : 0, 10052
Telemetry [candidate] (9.797 ms) : 0, 9797
Flare Poller [baseline] (10.057 ms) : 0, 10057
Flare Poller [candidate] (9.162 ms) : 0, 9162
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (794.358 ms) : 0, 794358
BytebuddyAgent [candidate] (789.805 ms) : 0, 789805
AgentMeter [baseline] (11.208 ms) : 0, 11208
AgentMeter [candidate] (11.195 ms) : 0, 11195
GlobalTracer [baseline] (248.379 ms) : 0, 248379
GlobalTracer [candidate] (248.101 ms) : 0, 248101
AppSec [baseline] (33.29 ms) : 0, 33290
AppSec [candidate] (31.234 ms) : 0, 31234
Debugger [baseline] (67.457 ms) : 0, 67457
Debugger [candidate] (68.403 ms) : 0, 68403
Remote Config [baseline] (554.258 µs) : 0, 554
Remote Config [candidate] (539.336 µs) : 0, 539
Telemetry [baseline] (8.822 ms) : 0, 8822
Telemetry [candidate] (8.511 ms) : 0, 8511
Flare Poller [baseline] (3.548 ms) : 0, 3548
Flare Poller [candidate] (3.47 ms) : 0, 3470
IAST [baseline] (26.894 ms) : 0, 26894
IAST [candidate] (26.715 ms) : 0, 26715
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070446
Total [baseline] (11.027 s) : 0, 11026761
Agent [candidate] (1.059 s) : 0, 1059129
Total [candidate] (10.917 s) : 0, 10917063
section appsec
Agent [baseline] (1.232 s) : 0, 1232124
Total [baseline] (11.158 s) : 0, 11157754
Agent [candidate] (1.236 s) : 0, 1236406
Total [candidate] (11.036 s) : 0, 11036237
section iast
Agent [baseline] (1.226 s) : 0, 1226183
Total [baseline] (11.138 s) : 0, 11138359
Agent [candidate] (1.23 s) : 0, 1230378
Total [candidate] (11.236 s) : 0, 11235988
section profiling
Agent [baseline] (1.186 s) : 0, 1186003
Total [baseline] (10.9 s) : 0, 10899509
Agent [candidate] (1.188 s) : 0, 1187883
Total [candidate] (11.008 s) : 0, 11008383
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (627.781 ms) : 0, 627781
BytebuddyAgent [candidate] (622.732 ms) : 0, 622732
AgentMeter [baseline] (29.183 ms) : 0, 29183
AgentMeter [candidate] (28.682 ms) : 0, 28682
GlobalTracer [baseline] (260.248 ms) : 0, 260248
GlobalTracer [candidate] (256.641 ms) : 0, 256641
AppSec [baseline] (33.395 ms) : 0, 33395
AppSec [candidate] (32.86 ms) : 0, 32860
Debugger [baseline] (63.606 ms) : 0, 63606
Debugger [candidate] (64.215 ms) : 0, 64215
Remote Config [baseline] (616.449 µs) : 0, 616
Remote Config [candidate] (610.224 µs) : 0, 610
Telemetry [baseline] (12.421 ms) : 0, 12421
Telemetry [candidate] (11.462 ms) : 0, 11462
Flare Poller [baseline] (6.216 ms) : 0, 6216
Flare Poller [candidate] (5.275 ms) : 0, 5275
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (650.913 ms) : 0, 650913
BytebuddyAgent [candidate] (654.385 ms) : 0, 654385
AgentMeter [baseline] (11.795 ms) : 0, 11795
AgentMeter [candidate] (11.819 ms) : 0, 11819
GlobalTracer [baseline] (257.374 ms) : 0, 257374
GlobalTracer [candidate] (258.824 ms) : 0, 258824
AppSec [baseline] (168.075 ms) : 0, 168075
AppSec [candidate] (167.867 ms) : 0, 167867
Debugger [baseline] (68.325 ms) : 0, 68325
Debugger [candidate] (67.52 ms) : 0, 67520
Remote Config [baseline] (660.142 µs) : 0, 660
Remote Config [candidate] (663.762 µs) : 0, 664
Telemetry [baseline] (9.286 ms) : 0, 9286
Telemetry [candidate] (9.303 ms) : 0, 9303
Flare Poller [baseline] (3.688 ms) : 0, 3688
Flare Poller [candidate] (3.682 ms) : 0, 3682
IAST [baseline] (25.468 ms) : 0, 25468
IAST [candidate] (25.72 ms) : 0, 25720
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (789.402 ms) : 0, 789402
BytebuddyAgent [candidate] (792.904 ms) : 0, 792904
AgentMeter [baseline] (11.232 ms) : 0, 11232
AgentMeter [candidate] (11.247 ms) : 0, 11247
GlobalTracer [baseline] (248.021 ms) : 0, 248021
GlobalTracer [candidate] (249.389 ms) : 0, 249389
AppSec [baseline] (32.355 ms) : 0, 32355
AppSec [candidate] (35.65 ms) : 0, 35650
Debugger [baseline] (68.98 ms) : 0, 68980
Debugger [candidate] (64.898 ms) : 0, 64898
Remote Config [baseline] (609.872 µs) : 0, 610
Remote Config [candidate] (544.113 µs) : 0, 544
Telemetry [baseline] (8.603 ms) : 0, 8603
Telemetry [candidate] (8.569 ms) : 0, 8569
Flare Poller [baseline] (3.472 ms) : 0, 3472
Flare Poller [candidate] (3.478 ms) : 0, 3478
IAST [baseline] (26.838 ms) : 0, 26838
IAST [candidate] (26.872 ms) : 0, 26872
section profiling
ProfilingAgent [baseline] (99.175 ms) : 0, 99175
ProfilingAgent [candidate] (98.602 ms) : 0, 98602
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (676.71 ms) : 0, 676710
BytebuddyAgent [candidate] (679.407 ms) : 0, 679407
AgentMeter [baseline] (8.664 ms) : 0, 8664
AgentMeter [candidate] (8.664 ms) : 0, 8664
GlobalTracer [baseline] (217.263 ms) : 0, 217263
GlobalTracer [candidate] (217.289 ms) : 0, 217289
AppSec [baseline] (32.063 ms) : 0, 32063
AppSec [candidate] (32.11 ms) : 0, 32110
Debugger [baseline] (67.789 ms) : 0, 67789
Debugger [candidate] (67.512 ms) : 0, 67512
Remote Config [baseline] (594.919 µs) : 0, 595
Remote Config [candidate] (591.043 µs) : 0, 591
Telemetry [baseline] (8.72 ms) : 0, 8720
Telemetry [candidate] (8.677 ms) : 0, 8677
Flare Poller [baseline] (3.782 ms) : 0, 3782
Flare Poller [candidate] (3.775 ms) : 0, 3775
Profiling [baseline] (99.77 ms) : 0, 99770
Profiling [candidate] (99.162 ms) : 0, 99162
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.175 ms) : 1163, 1186
. : milestone, 1175,
iast (3.022 ms) : 2987, 3057
. : milestone, 3022,
iast_FULL (5.813 ms) : 5755, 5871
. : milestone, 5813,
iast_GLOBAL (3.45 ms) : 3403, 3497
. : milestone, 3450,
profiling (1.929 ms) : 1913, 1945
. : milestone, 1929,
tracing (1.786 ms) : 1772, 1800
. : milestone, 1786,
section candidate
no_agent (1.205 ms) : 1193, 1216
. : milestone, 1205,
iast (3.133 ms) : 3092, 3174
. : milestone, 3133,
iast_FULL (5.691 ms) : 5635, 5747
. : milestone, 5691,
iast_GLOBAL (3.364 ms) : 3312, 3415
. : milestone, 3364,
profiling (2.082 ms) : 2063, 2101
. : milestone, 2082,
tracing (1.883 ms) : 1867, 1899
. : milestone, 1883,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (19.168 ms) : 18970, 19366
. : milestone, 19168,
appsec (18.644 ms) : 18453, 18835
. : milestone, 18644,
code_origins (17.769 ms) : 17590, 17948
. : milestone, 17769,
iast (17.645 ms) : 17469, 17821
. : milestone, 17645,
profiling (18.736 ms) : 18547, 18925
. : milestone, 18736,
tracing (17.568 ms) : 17394, 17741
. : milestone, 17568,
section candidate
no_agent (18.231 ms) : 18045, 18417
. : milestone, 18231,
appsec (18.529 ms) : 18342, 18716
. : milestone, 18529,
code_origins (17.693 ms) : 17519, 17867
. : milestone, 17693,
iast (17.479 ms) : 17306, 17652
. : milestone, 17479,
profiling (18.808 ms) : 18618, 18998
. : milestone, 18808,
tracing (17.307 ms) : 17137, 17477
. : milestone, 17307,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.76 ms) : 3540, 3980
. : milestone, 3760,
iast (2.271 ms) : 2201, 2341
. : milestone, 2271,
iast_GLOBAL (2.312 ms) : 2242, 2382
. : milestone, 2312,
profiling (2.507 ms) : 2292, 2723
. : milestone, 2507,
tracing (2.093 ms) : 2039, 2147
. : milestone, 2093,
section candidate
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (3.8 ms) : 3578, 4021
. : milestone, 3800,
iast (2.268 ms) : 2198, 2337
. : milestone, 2268,
iast_GLOBAL (2.326 ms) : 2255, 2396
. : milestone, 2326,
profiling (2.141 ms) : 2083, 2198
. : milestone, 2141,
tracing (2.083 ms) : 2029, 2137
. : milestone, 2083,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~749076a976, baseline=1.59.0-SNAPSHOT~02cc48359b
dateFormat X
axisFormat %s
section baseline
no_agent (15.558 s) : 15558000, 15558000
. : milestone, 15558000,
appsec (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
iast (18.078 s) : 18078000, 18078000
. : milestone, 18078000,
iast_GLOBAL (17.402 s) : 17402000, 17402000
. : milestone, 17402000,
profiling (14.889 s) : 14889000, 14889000
. : milestone, 14889000,
tracing (14.781 s) : 14781000, 14781000
. : milestone, 14781000,
section candidate
no_agent (14.905 s) : 14905000, 14905000
. : milestone, 14905000,
appsec (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
iast (18.166 s) : 18166000, 18166000
. : milestone, 18166000,
iast_GLOBAL (17.845 s) : 17845000, 17845000
. : milestone, 17845000,
profiling (15.326 s) : 15326000, 15326000
. : milestone, 15326000,
tracing (14.631 s) : 14631000, 14631000
. : milestone, 14631000,
|
What Does This Do
Jacoco can inject synthetic field or methods inside classes for SymDB symbol extraction those injected symbols can make the tests non-consistent (IDE or gradle run)
we are excluding those dynamically compiled classes from Jacoco coverage
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]