Fix JAX-RS instrumentation from overriding play framework span resource names. #8591
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… play framework span resource names.
ygree
force-pushed
the
ygree/fix-play-jaxrs-resource-name-priority
branch
from
162d4fe to
0e7401c
Compare
ygree
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Experimental change to prevent JAX-RS instrumentation from overriding play framework span resource names.
Motivation
Try to determine the cause of the problem.
Additional Notes
Currently target 1.34.0 as this problem was observed in that version.
A caveat to using ResourceNamePriorities.HTTP_FRAMEWORK_ROUTE priority 3 instead of ResourceNamePriorities.HTTP_PATH_NORMALIZER priority 1 for the root span; this prevents the resource from being set to 404 when the status code is 404 because ResourceNamePriorities.HTTP_404 has a lower priority of 2.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-14549