Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more places to use the internal maven proxy #8592

Merged
merged 8 commits into from
Mar 31, 2025
Merged

Fix more places to use the internal maven proxy #8592

merged 8 commits into from
Mar 31, 2025

Conversation

randomanderson
Copy link
Contributor

@randomanderson randomanderson commented Mar 20, 2025 •
edited
Loading

What Does This Do

This PR makes the following changes:

  • Uses two proxies instead of one. One for gradlePlugins, one for mavenCentral()
  • Moves mavenLocal() to be before the proxies
  • Removes unnecessary repository {} blocks (ie whenever java.gradle is applied)
  • Removes unnecessary gradlePluginPortal() declarations
  • Updates build files to use repositories.gradle where possible
  • Updates buildscript {} blocks to include the proxies
  • Updates proxy address to a more direct route
  • Updates the mule maven build to use the proxy

The priority of the repos are as follows:

  1. mavenLocal()
  2. gradle plugin proxy (when in pluginManagement or a buildscript {} block using plugins)
  3. maven proxy
  4. gradlePluginPortal() (when in pluginManagement or a buildscript {} block using plugins
  5. mavenCentral()

Motivation

#8554 was incomplete in that it didn't cover all of the cases. As a result, many dependency lookups were not going through the proxy. Additionally, mavenLocal() being after the proxy meant many more calls than necessary.

Additional Notes

  1. There's probably a less repetitive way of doing this but gradle is complicated. Of the SIX confusing and overlapping ways to configure plugins with gradle, dd-trace-java uses FIVE of them. And more complications:
  • pluginManagement needs to be the very first declaration in settings.gradle
  • Getting rid of buildscript {} would mean all of our custom code would need to be in plugins instead of the build files
  • Not using plugins that only support the "old style declarations"
  • etc, etc
  1. It's hard to test all of the edge cases because only jobs in Gitlab use the proxy

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@randomanderson randomanderson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Mar 20, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 20, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/replace-maven-central
git_commit_date 1743425619 1743426663
git_commit_sha 32ca4c6 7875d0b
release_version 1.48.0-SNAPSHOT~32ca4c67e9 1.48.0-SNAPSHOT~7875d0bb62
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743429546 1743429546
ci_job_id 872380219 872380219
ci_pipeline_id 60506302 60506302
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-232sggg1-project-304-concurrent-0-5gb9ufzs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-232sggg1-project-304-concurrent-0-5gb9ufzs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057640
Total [baseline] (10.468 s) : 0, 10467808
Agent [candidate] (1.055 s) : 0, 1055123
Total [candidate] (10.442 s) : 0, 10441918
section appsec
Agent [baseline] (1.195 s) : 0, 1195369
Total [baseline] (10.75 s) : 0, 10750106
Agent [candidate] (1.196 s) : 0, 1195600
Total [candidate] (10.75 s) : 0, 10750378
section iast
Agent [baseline] (1.182 s) : 0, 1181990
Total [baseline] (11.131 s) : 0, 11131120
Agent [candidate] (1.181 s) : 0, 1180732
Total [candidate] (11.006 s) : 0, 11005507
section profiling
Agent [baseline] (1.275 s) : 0, 1275160
Total [baseline] (10.905 s) : 0, 10905297
Agent [candidate] (1.279 s) : 0, 1279278
Total [candidate] (10.917 s) : 0, 10917246
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.195 s 137.729 ms (13.0%)
Agent iast 1.182 s 124.351 ms (11.8%)
Agent profiling 1.275 s 217.52 ms (20.6%)
Total tracing 10.468 s -
Total appsec 10.75 s 282.298 ms (2.7%)
Total iast 11.131 s 663.312 ms (6.3%)
Total profiling 10.905 s 437.49 ms (4.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.196 s 140.477 ms (13.3%)
Agent iast 1.181 s 125.609 ms (11.9%)
Agent profiling 1.279 s 224.155 ms (21.2%)
Total tracing 10.442 s -
Total appsec 10.75 s 308.461 ms (3.0%)
Total iast 11.006 s 563.59 ms (5.4%)
Total profiling 10.917 s 475.329 ms (4.6%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.19 ms) : 0, 719190
BytebuddyAgent [candidate] (720.71 ms) : 0, 720710
GlobalTracer [baseline] (240.75 ms) : 0, 240750
GlobalTracer [candidate] (239.982 ms) : 0, 239982
AppSec [baseline] (54.844 ms) : 0, 54844
AppSec [candidate] (54.531 ms) : 0, 54531
Debugger [baseline] (4.463 ms) : 0, 4463
Debugger [candidate] (5.16 ms) : 0, 5160
Remote Config [baseline] (698.049 µs) : 0, 698
Remote Config [candidate] (676.075 µs) : 0, 676
Telemetry [baseline] (17.035 ms) : 0, 17035
Telemetry [candidate] (13.4 ms) : 0, 13400
section appsec
BytebuddyAgent [baseline] (739.109 ms) : 0, 739109
BytebuddyAgent [candidate] (739.156 ms) : 0, 739156
GlobalTracer [baseline] (235.709 ms) : 0, 235709
GlobalTracer [candidate] (235.718 ms) : 0, 235718
IAST [baseline] (21.749 ms) : 0, 21749
IAST [candidate] (21.797 ms) : 0, 21797
AppSec [baseline] (176.039 ms) : 0, 176039
AppSec [candidate] (176.152 ms) : 0, 176152
Debugger [baseline] (4.272 ms) : 0, 4272
Debugger [candidate] (4.274 ms) : 0, 4274
Remote Config [baseline] (643.987 µs) : 0, 644
Remote Config [candidate] (639.741 µs) : 0, 640
Telemetry [baseline] (8.167 ms) : 0, 8167
Telemetry [candidate] (8.196 ms) : 0, 8196
section iast
BytebuddyAgent [baseline] (839.42 ms) : 0, 839420
BytebuddyAgent [candidate] (837.838 ms) : 0, 837838
GlobalTracer [baseline] (229.361 ms) : 0, 229361
GlobalTracer [candidate] (229.812 ms) : 0, 229812
IAST [baseline] (22.931 ms) : 0, 22931
IAST [candidate] (22.931 ms) : 0, 22931
AppSec [baseline] (56.046 ms) : 0, 56046
AppSec [candidate] (55.993 ms) : 0, 55993
Debugger [baseline] (4.205 ms) : 0, 4205
Debugger [candidate] (4.199 ms) : 0, 4199
Remote Config [baseline] (620.069 µs) : 0, 620
Remote Config [candidate] (619.484 µs) : 0, 619
Telemetry [baseline] (8.839 ms) : 0, 8839
Telemetry [candidate] (8.877 ms) : 0, 8877
section profiling
BytebuddyAgent [baseline] (711.055 ms) : 0, 711055
BytebuddyAgent [candidate] (714.421 ms) : 0, 714421
GlobalTracer [baseline] (347.586 ms) : 0, 347586
GlobalTracer [candidate] (348.788 ms) : 0, 348788
AppSec [baseline] (53.676 ms) : 0, 53676
AppSec [candidate] (53.223 ms) : 0, 53223
Debugger [baseline] (4.309 ms) : 0, 4309
Debugger [candidate] (4.292 ms) : 0, 4292
Remote Config [baseline] (712.504 µs) : 0, 713
Remote Config [candidate] (712.174 µs) : 0, 712
Telemetry [baseline] (9.05 ms) : 0, 9050
Telemetry [candidate] (9.005 ms) : 0, 9005
ProfilingAgent [baseline] (102.979 ms) : 0, 102979
ProfilingAgent [candidate] (102.937 ms) : 0, 102937
Profiling [baseline] (103.005 ms) : 0, 103005
Profiling [candidate] (102.964 ms) : 0, 102964
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049261
Total [baseline] (8.663 s) : 0, 8663366
Agent [candidate] (1.053 s) : 0, 1053311
Total [candidate] (8.708 s) : 0, 8708052
section iast
Agent [baseline] (1.181 s) : 0, 1180761
Total [baseline] (9.229 s) : 0, 9228933
Agent [candidate] (1.195 s) : 0, 1195141
Total [candidate] (9.317 s) : 0, 9317184
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.188 s) : 0, 1188218
Total [baseline] (9.239 s) : 0, 9238925
Agent [candidate] (1.181 s) : 0, 1180996
Total [candidate] (9.217 s) : 0, 9216509
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1178252
Total [baseline] (9.208 s) : 0, 9207654
Agent [candidate] (1.176 s) : 0, 1176270
Total [candidate] (9.235 s) : 0, 9235181
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.181 s 131.5 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.188 s 138.957 ms (13.2%)
Agent iast_TELEMETRY_OFF 1.178 s 128.991 ms (12.3%)
Total tracing 8.663 s -
Total iast 9.229 s 565.566 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.239 s 575.559 ms (6.6%)
Total iast_TELEMETRY_OFF 9.208 s 544.287 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.195 s 141.83 ms (13.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 127.685 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.176 s 122.959 ms (11.7%)
Total tracing 8.708 s -
Total iast 9.317 s 609.131 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.217 s 508.457 ms (5.8%)
Total iast_TELEMETRY_OFF 9.235 s 527.128 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.832 ms) : 0, 717832
BytebuddyAgent [candidate] (719.388 ms) : 0, 719388
GlobalTracer [baseline] (238.345 ms) : 0, 238345
GlobalTracer [candidate] (239.081 ms) : 0, 239081
AppSec [baseline] (54.447 ms) : 0, 54447
AppSec [candidate] (54.569 ms) : 0, 54569
Debugger [baseline] (4.439 ms) : 0, 4439
Debugger [candidate] (4.483 ms) : 0, 4483
Remote Config [baseline] (682.018 µs) : 0, 682
Remote Config [candidate] (694.694 µs) : 0, 695
Telemetry [baseline] (12.88 ms) : 0, 12880
Telemetry [candidate] (14.517 ms) : 0, 14517
section iast
BytebuddyAgent [baseline] (838.081 ms) : 0, 838081
BytebuddyAgent [candidate] (849.436 ms) : 0, 849436
GlobalTracer [baseline] (229.504 ms) : 0, 229504
GlobalTracer [candidate] (231.689 ms) : 0, 231689
IAST [baseline] (22.869 ms) : 0, 22869
IAST [candidate] (23.166 ms) : 0, 23166
AppSec [baseline] (56.192 ms) : 0, 56192
AppSec [candidate] (56.307 ms) : 0, 56307
Debugger [baseline] (4.206 ms) : 0, 4206
Debugger [candidate] (4.288 ms) : 0, 4288
Remote Config [baseline] (610.595 µs) : 0, 611
Remote Config [candidate] (638.349 µs) : 0, 638
Telemetry [baseline] (8.85 ms) : 0, 8850
Telemetry [candidate] (9.033 ms) : 0, 9033
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (843.316 ms) : 0, 843316
BytebuddyAgent [candidate] (838.771 ms) : 0, 838771
GlobalTracer [baseline] (231.012 ms) : 0, 231012
GlobalTracer [candidate] (229.403 ms) : 0, 229403
IAST [baseline] (23.026 ms) : 0, 23026
IAST [candidate] (22.895 ms) : 0, 22895
AppSec [baseline] (56.464 ms) : 0, 56464
AppSec [candidate] (55.658 ms) : 0, 55658
Debugger [baseline] (4.25 ms) : 0, 4250
Debugger [candidate] (4.237 ms) : 0, 4237
Remote Config [baseline] (627.75 µs) : 0, 628
Remote Config [candidate] (618.374 µs) : 0, 618
Telemetry [baseline] (8.988 ms) : 0, 8988
Telemetry [candidate] (8.872 ms) : 0, 8872
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.457 ms) : 0, 836457
BytebuddyAgent [candidate] (834.775 ms) : 0, 834775
GlobalTracer [baseline] (229.142 ms) : 0, 229142
GlobalTracer [candidate] (229.027 ms) : 0, 229027
IAST [baseline] (22.408 ms) : 0, 22408
IAST [candidate] (22.344 ms) : 0, 22344
AppSec [baseline] (56.135 ms) : 0, 56135
AppSec [candidate] (56.229 ms) : 0, 56229
Debugger [baseline] (4.202 ms) : 0, 4202
Debugger [candidate] (4.15 ms) : 0, 4150
Remote Config [baseline] (619.988 µs) : 0, 620
Remote Config [candidate] (622.687 µs) : 0, 623
Telemetry [baseline] (8.776 ms) : 0, 8776
Telemetry [candidate] (8.699 ms) : 0, 8699
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-31T13:33:52 2025-03-31T13:41:39
git_branch master landerson/replace-maven-central
git_commit_date 1743425619 1743426663
git_commit_sha 32ca4c6 7875d0b
release_version 1.48.0-SNAPSHOT~32ca4c67e9 1.48.0-SNAPSHOT~7875d0bb62
start_time 2025-03-31T13:33:38 2025-03-31T13:41:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743428899 1743428899
ci_job_id 872380220 872380220
ci_pipeline_id 60506302 60506302
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ie6fuauo-project-304-concurrent-0-z2j7y8gs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ie6fuauo-project-304-concurrent-0-z2j7y8gs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9
    dateFormat X
    axisFormat %s
section baseline
no_agent (380.595 µs) : 360, 401
.   : milestone, 381,
iast (510.153 µs) : 488, 532
.   : milestone, 510,
iast_FULL (735.02 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (562.814 µs) : 541, 585
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (512.418 µs) : 491, 534
.   : milestone, 512,
iast_INACTIVE (468.334 µs) : 447, 490
.   : milestone, 468,
iast_TELEMETRY_OFF (501.464 µs) : 480, 523
.   : milestone, 501,
tracing (458.596 µs) : 437, 480
.   : milestone, 459,
section candidate
no_agent (381.119 µs) : 361, 401
.   : milestone, 381,
iast (517.063 µs) : 495, 539
.   : milestone, 517,
iast_FULL (742.509 µs) : 720, 765
.   : milestone, 743,
iast_GLOBAL (559.217 µs) : 537, 581
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (516.792 µs) : 495, 539
.   : milestone, 517,
iast_INACTIVE (470.677 µs) : 448, 493
.   : milestone, 471,
iast_TELEMETRY_OFF (517.038 µs) : 495, 539
.   : milestone, 517,
tracing (458.512 µs) : 438, 479
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.595 µs [360.212 µs, 400.978 µs] -
iast 510.153 µs [488.429 µs, 531.877 µs] 129.558 µs (34.0%)
iast_FULL 735.02 µs [712.933 µs, 757.106 µs] 354.425 µs (93.1%)
iast_GLOBAL 562.814 µs [540.869 µs, 584.76 µs] 182.219 µs (47.9%)
iast_HARDCODED_SECRET_DISABLED 512.418 µs [490.578 µs, 534.258 µs] 131.823 µs (34.6%)
iast_INACTIVE 468.334 µs [446.778 µs, 489.89 µs] 87.739 µs (23.1%)
iast_TELEMETRY_OFF 501.464 µs [479.593 µs, 523.335 µs] 120.869 µs (31.8%)
tracing 458.596 µs [437.318 µs, 479.875 µs] 78.002 µs (20.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.119 µs [361.441 µs, 400.798 µs] -
iast 517.063 µs [495.162 µs, 538.963 µs] 135.943 µs (35.7%)
iast_FULL 742.509 µs [719.675 µs, 765.344 µs] 361.39 µs (94.8%)
iast_GLOBAL 559.217 µs [537.471 µs, 580.964 µs] 178.098 µs (46.7%)
iast_HARDCODED_SECRET_DISABLED 516.792 µs [494.729 µs, 538.855 µs] 135.673 µs (35.6%)
iast_INACTIVE 470.677 µs [448.397 µs, 492.958 µs] 89.558 µs (23.5%)
iast_TELEMETRY_OFF 517.038 µs [495.356 µs, 538.719 µs] 135.918 µs (35.7%)
tracing 458.512 µs [437.801 µs, 479.224 µs] 77.393 µs (20.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.368 ms) : 1347, 1388
.   : milestone, 1368,
appsec (1.751 ms) : 1727, 1775
.   : milestone, 1751,
appsec_no_iast (1.73 ms) : 1707, 1754
.   : milestone, 1730,
code_origins (1.69 ms) : 1662, 1718
.   : milestone, 1690,
iast (1.526 ms) : 1501, 1551
.   : milestone, 1526,
profiling (1.527 ms) : 1503, 1551
.   : milestone, 1527,
tracing (1.522 ms) : 1498, 1546
.   : milestone, 1522,
section candidate
no_agent (1.361 ms) : 1342, 1381
.   : milestone, 1361,
appsec (1.743 ms) : 1719, 1768
.   : milestone, 1743,
appsec_no_iast (1.732 ms) : 1708, 1755
.   : milestone, 1732,
code_origins (1.696 ms) : 1669, 1724
.   : milestone, 1696,
iast (1.529 ms) : 1505, 1554
.   : milestone, 1529,
profiling (1.534 ms) : 1509, 1558
.   : milestone, 1534,
tracing (1.492 ms) : 1467, 1517
.   : milestone, 1492,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.368 ms [1.347 ms, 1.388 ms] -
appsec 1.751 ms [1.727 ms, 1.775 ms] 383.451 µs (28.0%)
appsec_no_iast 1.73 ms [1.707 ms, 1.754 ms] 362.65 µs (26.5%)
code_origins 1.69 ms [1.662 ms, 1.718 ms] 322.342 µs (23.6%)
iast 1.526 ms [1.501 ms, 1.551 ms] 158.034 µs (11.6%)
profiling 1.527 ms [1.503 ms, 1.551 ms] 159.455 µs (11.7%)
tracing 1.522 ms [1.498 ms, 1.546 ms] 154.141 µs (11.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.342 ms, 1.381 ms] -
appsec 1.743 ms [1.719 ms, 1.768 ms] 382.246 µs (28.1%)
appsec_no_iast 1.732 ms [1.708 ms, 1.755 ms] 370.403 µs (27.2%)
code_origins 1.696 ms [1.669 ms, 1.724 ms] 335.19 µs (24.6%)
iast 1.529 ms [1.505 ms, 1.554 ms] 167.936 µs (12.3%)
profiling 1.534 ms [1.509 ms, 1.558 ms] 172.765 µs (12.7%)
tracing 1.492 ms [1.467 ms, 1.517 ms] 130.451 µs (9.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/replace-maven-central
git_commit_date 1743425619 1743426663
git_commit_sha 32ca4c6 7875d0b
release_version 1.48.0-SNAPSHOT~32ca4c67e9 1.48.0-SNAPSHOT~7875d0bb62
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1743429141 1743429141
ci_job_id 872380221 872380221
ci_pipeline_id 60506302 60506302
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zvu8n-98-project-304-concurrent-0-22koc3kz 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zvu8n-98-project-304-concurrent-0-22koc3kz 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
.   : milestone, 1480,
appsec (2.365 ms) : 2321, 2409
.   : milestone, 2365,
iast (2.136 ms) : 2080, 2192
.   : milestone, 2136,
iast_GLOBAL (2.173 ms) : 2116, 2229
.   : milestone, 2173,
profiling (2.001 ms) : 1956, 2047
.   : milestone, 2001,
tracing (1.968 ms) : 1925, 2011
.   : milestone, 1968,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.359 ms) : 2315, 2404
.   : milestone, 2359,
iast (2.127 ms) : 2072, 2183
.   : milestone, 2127,
iast_GLOBAL (2.184 ms) : 2128, 2241
.   : milestone, 2184,
profiling (2.009 ms) : 1963, 2055
.   : milestone, 2009,
tracing (1.972 ms) : 1929, 2015
.   : milestone, 1972,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.469 ms, 1.492 ms] -
appsec 2.365 ms [2.321 ms, 2.409 ms] 885.099 µs (59.8%)
iast 2.136 ms [2.08 ms, 2.192 ms] 656.223 µs (44.3%)
iast_GLOBAL 2.173 ms [2.116 ms, 2.229 ms] 692.669 µs (46.8%)
profiling 2.001 ms [1.956 ms, 2.047 ms] 521.146 µs (35.2%)
tracing 1.968 ms [1.925 ms, 2.011 ms] 488.014 µs (33.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.464 ms, 1.487 ms] -
appsec 2.359 ms [2.315 ms, 2.404 ms] 884.046 µs (59.9%)
iast 2.127 ms [2.072 ms, 2.183 ms] 652.071 µs (44.2%)
iast_GLOBAL 2.184 ms [2.128 ms, 2.241 ms] 709.045 µs (48.1%)
profiling 2.009 ms [1.963 ms, 2.055 ms] 533.647 µs (36.2%)
tracing 1.972 ms [1.929 ms, 2.015 ms] 496.391 µs (33.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~7875d0bb62, baseline=1.48.0-SNAPSHOT~32ca4c67e9
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.799 s) : 14799000, 14799000
.   : milestone, 14799000,
appsec (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,
iast (18.515 s) : 18515000, 18515000
.   : milestone, 18515000,
iast_GLOBAL (17.604 s) : 17604000, 17604000
.   : milestone, 17604000,
profiling (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
tracing (15.234 s) : 15234000, 15234000
.   : milestone, 15234000,
section candidate
no_agent (15.419 s) : 15419000, 15419000
.   : milestone, 15419000,
appsec (14.88 s) : 14880000, 14880000
.   : milestone, 14880000,
iast (18.565 s) : 18565000, 18565000
.   : milestone, 18565000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
.   : milestone, 17985000,
profiling (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
tracing (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.799 s [14.799 s, 14.799 s] -
appsec 15.086 s [15.086 s, 15.086 s] 287.0 ms (1.9%)
iast 18.515 s [18.515 s, 18.515 s] 3.716 s (25.1%)
iast_GLOBAL 17.604 s [17.604 s, 17.604 s] 2.805 s (19.0%)
profiling 15.095 s [15.095 s, 15.095 s] 296.0 ms (2.0%)
tracing 15.234 s [15.234 s, 15.234 s] 435.0 ms (2.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.419 s [15.419 s, 15.419 s] -
appsec 14.88 s [14.88 s, 14.88 s] -539.0 ms (-3.5%)
iast 18.565 s [18.565 s, 18.565 s] 3.146 s (20.4%)
iast_GLOBAL 17.985 s [17.985 s, 17.985 s] 2.566 s (16.6%)
profiling 15.015 s [15.015 s, 15.015 s] -404.0 ms (-2.6%)
tracing 15.008 s [15.008 s, 15.008 s] -411.0 ms (-2.7%)

@randomanderson randomanderson marked this pull request as ready for review March 20, 2025 15:52
@randomanderson randomanderson requested review from a team as code owners March 20, 2025 15:52
@randomanderson randomanderson marked this pull request as draft March 20, 2025 19:23
@randomanderson
Copy link
Contributor Author

Still getting 429 from maven central. Need to make sure this is actually using the proxy

@randomanderson randomanderson marked this pull request as ready for review March 31, 2025 14:50
@randomanderson randomanderson requested a review from mcculls March 31, 2025 16:14
@randomanderson randomanderson merged commit f020e29 into master Mar 31, 2025
254 checks passed
@randomanderson randomanderson deleted the landerson/replace-maven-central branch March 31, 2025 18:29
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@mcculls mcculls mcculls approved these changes

@juan-fernandez juan-fernandez Awaiting requested review from juan-fernandez juan-fernandez is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@randomanderson @smola @mcculls