-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation name to startSpan (A-J) #8594
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
2dfcc4d
to
90f9dfd
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043292
Total [baseline] (8.683 s) : 0, 8682543
Agent [candidate] (1.048 s) : 0, 1048157
Total [candidate] (8.667 s) : 0, 8667189
section iast
Agent [baseline] (1.179 s) : 0, 1178550
Total [baseline] (9.223 s) : 0, 9222978
Agent [candidate] (1.173 s) : 0, 1173225
Total [candidate] (9.216 s) : 0, 9215671
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1182581
Total [baseline] (9.226 s) : 0, 9226262
Agent [candidate] (1.172 s) : 0, 1171992
Total [candidate] (9.19 s) : 0, 9190038
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168867
Total [baseline] (9.223 s) : 0, 9222745
Agent [candidate] (1.167 s) : 0, 1166971
Total [candidate] (9.208 s) : 0, 9208151
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.024 ms) : 0, 718024
BytebuddyAgent [candidate] (721.836 ms) : 0, 721836
GlobalTracer [baseline] (239.585 ms) : 0, 239585
GlobalTracer [candidate] (240.735 ms) : 0, 240735
AppSec [baseline] (55.148 ms) : 0, 55148
AppSec [candidate] (55.256 ms) : 0, 55256
Remote Config [baseline] (707.016 µs) : 0, 707
Remote Config [candidate] (701.553 µs) : 0, 702
Telemetry [baseline] (13.836 ms) : 0, 13836
Telemetry [candidate] (13.573 ms) : 0, 13573
section iast
BytebuddyAgent [baseline] (843.895 ms) : 0, 843895
BytebuddyAgent [candidate] (838.484 ms) : 0, 838484
GlobalTracer [baseline] (230.852 ms) : 0, 230852
GlobalTracer [candidate] (230.091 ms) : 0, 230091
IAST [baseline] (23.57 ms) : 0, 23570
IAST [candidate] (22.979 ms) : 0, 22979
AppSec [baseline] (55.05 ms) : 0, 55050
AppSec [candidate] (56.412 ms) : 0, 56412
Remote Config [baseline] (606.051 µs) : 0, 606
Remote Config [candidate] (634.711 µs) : 0, 635
Telemetry [baseline] (8.664 ms) : 0, 8664
Telemetry [candidate] (8.743 ms) : 0, 8743
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (845.67 ms) : 0, 845670
BytebuddyAgent [candidate] (837.312 ms) : 0, 837312
GlobalTracer [baseline] (231.767 ms) : 0, 231767
GlobalTracer [candidate] (230.45 ms) : 0, 230450
IAST [baseline] (23.156 ms) : 0, 23156
IAST [candidate] (23.779 ms) : 0, 23779
AppSec [baseline] (56.515 ms) : 0, 56515
AppSec [candidate] (55.241 ms) : 0, 55241
Remote Config [baseline] (619.503 µs) : 0, 620
Remote Config [candidate] (609.599 µs) : 0, 610
Telemetry [baseline] (8.811 ms) : 0, 8811
Telemetry [candidate] (8.685 ms) : 0, 8685
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.524 ms) : 0, 835524
BytebuddyAgent [candidate] (832.679 ms) : 0, 832679
GlobalTracer [baseline] (229.917 ms) : 0, 229917
GlobalTracer [candidate] (230.713 ms) : 0, 230713
IAST [baseline] (22.387 ms) : 0, 22387
IAST [candidate] (22.396 ms) : 0, 22396
AppSec [baseline] (55.921 ms) : 0, 55921
AppSec [candidate] (56.024 ms) : 0, 56024
Remote Config [baseline] (605.335 µs) : 0, 605
Remote Config [candidate] (610.336 µs) : 0, 610
Telemetry [baseline] (8.53 ms) : 0, 8530
Telemetry [candidate] (8.535 ms) : 0, 8535
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052546
Total [baseline] (10.496 s) : 0, 10495761
Agent [candidate] (1.045 s) : 0, 1045199
Total [candidate] (10.427 s) : 0, 10426910
section appsec
Agent [baseline] (1.182 s) : 0, 1182246
Total [baseline] (10.713 s) : 0, 10712600
Agent [candidate] (1.187 s) : 0, 1186718
Total [candidate] (10.738 s) : 0, 10738354
section iast
Agent [baseline] (1.174 s) : 0, 1173843
Total [baseline] (11.018 s) : 0, 11017973
Agent [candidate] (1.179 s) : 0, 1178953
Total [candidate] (10.963 s) : 0, 10962719
section profiling
Agent [baseline] (1.261 s) : 0, 1261242
Total [baseline] (10.851 s) : 0, 10850707
Agent [candidate] (1.27 s) : 0, 1269640
Total [candidate] (10.812 s) : 0, 10811660
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.861 ms) : 0, 726861
BytebuddyAgent [candidate] (719.051 ms) : 0, 719051
GlobalTracer [baseline] (242.281 ms) : 0, 242281
GlobalTracer [candidate] (240.943 ms) : 0, 240943
AppSec [baseline] (54.94 ms) : 0, 54940
AppSec [candidate] (54.902 ms) : 0, 54902
Remote Config [baseline] (697.83 µs) : 0, 698
Remote Config [candidate] (698.14 µs) : 0, 698
Telemetry [baseline] (11.553 ms) : 0, 11553
Telemetry [candidate] (13.64 ms) : 0, 13640
section appsec
BytebuddyAgent [baseline] (735.207 ms) : 0, 735207
BytebuddyAgent [candidate] (737.23 ms) : 0, 737230
GlobalTracer [baseline] (236.042 ms) : 0, 236042
GlobalTracer [candidate] (236.738 ms) : 0, 236738
AppSec [baseline] (175.201 ms) : 0, 175201
AppSec [candidate] (176.662 ms) : 0, 176662
Remote Config [baseline] (678.065 µs) : 0, 678
Remote Config [candidate] (666.533 µs) : 0, 667
Telemetry [baseline] (8.331 ms) : 0, 8331
Telemetry [candidate] (8.73 ms) : 0, 8730
IAST [baseline] (21.755 ms) : 0, 21755
IAST [candidate] (21.44 ms) : 0, 21440
section iast
BytebuddyAgent [baseline] (839.452 ms) : 0, 839452
BytebuddyAgent [candidate] (843.7 ms) : 0, 843700
GlobalTracer [baseline] (230.415 ms) : 0, 230415
GlobalTracer [candidate] (230.768 ms) : 0, 230768
AppSec [baseline] (55.978 ms) : 0, 55978
AppSec [candidate] (56.278 ms) : 0, 56278
Remote Config [baseline] (603.875 µs) : 0, 604
Remote Config [candidate] (605.36 µs) : 0, 605
Telemetry [baseline] (8.682 ms) : 0, 8682
Telemetry [candidate] (8.711 ms) : 0, 8711
IAST [baseline] (22.771 ms) : 0, 22771
IAST [candidate] (22.9 ms) : 0, 22900
section profiling
BytebuddyAgent [baseline] (709.961 ms) : 0, 709961
BytebuddyAgent [candidate] (714.658 ms) : 0, 714658
GlobalTracer [baseline] (349.56 ms) : 0, 349560
GlobalTracer [candidate] (352.557 ms) : 0, 352557
AppSec [baseline] (54.222 ms) : 0, 54222
AppSec [candidate] (54.037 ms) : 0, 54037
Remote Config [baseline] (718.777 µs) : 0, 719
Remote Config [candidate] (724.21 µs) : 0, 724
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (9.048 ms) : 0, 9048
ProfilingAgent [baseline] (96.413 ms) : 0, 96413
ProfilingAgent [candidate] (96.894 ms) : 0, 96894
Profiling [baseline] (96.437 ms) : 0, 96437
Profiling [candidate] (96.919 ms) : 0, 96919
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1382
. : milestone, 1362,
appsec (1.757 ms) : 1732, 1781
. : milestone, 1757,
appsec_no_iast (1.76 ms) : 1736, 1784
. : milestone, 1760,
code_origins (1.672 ms) : 1644, 1699
. : milestone, 1672,
iast (1.506 ms) : 1482, 1530
. : milestone, 1506,
profiling (1.53 ms) : 1505, 1555
. : milestone, 1530,
tracing (1.487 ms) : 1461, 1512
. : milestone, 1487,
section candidate
no_agent (1.358 ms) : 1339, 1378
. : milestone, 1358,
appsec (1.734 ms) : 1710, 1758
. : milestone, 1734,
appsec_no_iast (1.74 ms) : 1714, 1765
. : milestone, 1740,
code_origins (1.675 ms) : 1647, 1703
. : milestone, 1675,
iast (1.535 ms) : 1511, 1559
. : milestone, 1535,
profiling (1.545 ms) : 1521, 1570
. : milestone, 1545,
tracing (1.506 ms) : 1480, 1532
. : milestone, 1506,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section baseline
no_agent (389.594 µs) : 370, 410
. : milestone, 390,
iast (518.372 µs) : 496, 540
. : milestone, 518,
iast_FULL (734.697 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (560.538 µs) : 539, 582
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (517.229 µs) : 495, 539
. : milestone, 517,
iast_INACTIVE (470.644 µs) : 448, 493
. : milestone, 471,
iast_TELEMETRY_OFF (501.815 µs) : 480, 523
. : milestone, 502,
tracing (457.042 µs) : 436, 478
. : milestone, 457,
section candidate
no_agent (380.041 µs) : 360, 400
. : milestone, 380,
iast (515.688 µs) : 494, 538
. : milestone, 516,
iast_FULL (737.26 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (557.023 µs) : 535, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (520.846 µs) : 499, 543
. : milestone, 521,
iast_INACTIVE (473.233 µs) : 451, 495
. : milestone, 473,
iast_TELEMETRY_OFF (498.836 µs) : 477, 521
. : milestone, 499,
tracing (459.583 µs) : 439, 480
. : milestone, 460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.339 ms) : 2295, 2383
. : milestone, 2339,
iast (2.119 ms) : 2063, 2174
. : milestone, 2119,
iast_GLOBAL (2.17 ms) : 2114, 2227
. : milestone, 2170,
profiling (1.977 ms) : 1933, 2021
. : milestone, 1977,
tracing (1.966 ms) : 1923, 2009
. : milestone, 1966,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.348 ms) : 2304, 2392
. : milestone, 2348,
iast (2.126 ms) : 2071, 2182
. : milestone, 2126,
iast_GLOBAL (2.165 ms) : 2109, 2221
. : milestone, 2165,
profiling (1.975 ms) : 1931, 2019
. : milestone, 1975,
tracing (1.953 ms) : 1910, 1996
. : milestone, 1953,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~90f9dfdd84, baseline=1.48.0-SNAPSHOT~9c4ccdf54a
dateFormat X
axisFormat %s
section baseline
no_agent (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
appsec (15.19 s) : 15190000, 15190000
. : milestone, 15190000,
iast (18.993 s) : 18993000, 18993000
. : milestone, 18993000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
tracing (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
section candidate
no_agent (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
appsec (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
iast (18.908 s) : 18908000, 18908000
. : milestone, 18908000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
. : milestone, 17947000,
profiling (15.159 s) : 15159000, 15159000
. : milestone, 15159000,
tracing (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
|
What Does This Do
Adds instrumentation name to
startSpan
in order to have proper telemetryThis is a partial change. Futher changes will happen for the rest of startSpan(k to z) and also to buildSpan(
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]