Websocket: ensure that trace context is propagated from the handshake #8619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
added
type: bug
tag: no release notes
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~ef2a423c86, baseline=1.48.0-SNAPSHOT~4a5461cf3e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049005
Total [baseline] (10.411 s) : 0, 10410532
Agent [candidate] (1.052 s) : 0, 1051917
Total [candidate] (10.407 s) : 0, 10406585
section appsec
Agent [baseline] (1.195 s) : 0, 1195312
Total [baseline] (10.725 s) : 0, 10725087
Agent [candidate] (1.195 s) : 0, 1194578
Total [candidate] (10.782 s) : 0, 10781502
section iast
Agent [baseline] (1.179 s) : 0, 1179046
Total [baseline] (11.068 s) : 0, 11067718
Agent [candidate] (1.189 s) : 0, 1188996
Total [candidate] (11.105 s) : 0, 11104522
section profiling
Agent [baseline] (1.273 s) : 0, 1273269
Total [baseline] (10.86 s) : 0, 10859539
Agent [candidate] (1.283 s) : 0, 1283114
Total [candidate] (10.876 s) : 0, 10876306
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~ef2a423c86, baseline=1.48.0-SNAPSHOT~4a5461cf3e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.556 ms) : 0, 718556
BytebuddyAgent [candidate] (718.519 ms) : 0, 718519
GlobalTracer [baseline] (238.744 ms) : 0, 238744
GlobalTracer [candidate] (238.792 ms) : 0, 238792
AppSec [baseline] (54.681 ms) : 0, 54681
AppSec [candidate] (54.899 ms) : 0, 54899
Debugger [baseline] (4.42 ms) : 0, 4420
Debugger [candidate] (5.156 ms) : 0, 5156
Remote Config [baseline] (695.376 µs) : 0, 695
Remote Config [candidate] (692.49 µs) : 0, 692
Telemetry [baseline] (12.196 ms) : 0, 12196
Telemetry [candidate] (14.239 ms) : 0, 14239
section appsec
BytebuddyAgent [baseline] (739.201 ms) : 0, 739201
BytebuddyAgent [candidate] (738.554 ms) : 0, 738554
GlobalTracer [baseline] (235.72 ms) : 0, 235720
GlobalTracer [candidate] (235.76 ms) : 0, 235760
IAST [baseline] (21.778 ms) : 0, 21778
IAST [candidate] (21.679 ms) : 0, 21679
AppSec [baseline] (176.638 ms) : 0, 176638
AppSec [candidate] (176.137 ms) : 0, 176137
Debugger [baseline] (4.297 ms) : 0, 4297
Debugger [candidate] (4.301 ms) : 0, 4301
Remote Config [baseline] (647.42 µs) : 0, 647
Remote Config [candidate] (648.317 µs) : 0, 648
Telemetry [baseline] (8.181 ms) : 0, 8181
Telemetry [candidate] (8.597 ms) : 0, 8597
section iast
BytebuddyAgent [baseline] (837.605 ms) : 0, 837605
BytebuddyAgent [candidate] (844.232 ms) : 0, 844232
GlobalTracer [baseline] (229.029 ms) : 0, 229029
GlobalTracer [candidate] (231.839 ms) : 0, 231839
IAST [baseline] (23.008 ms) : 0, 23008
IAST [candidate] (23.176 ms) : 0, 23176
AppSec [baseline] (55.975 ms) : 0, 55975
AppSec [candidate] (56.47 ms) : 0, 56470
Debugger [baseline] (4.212 ms) : 0, 4212
Debugger [candidate] (4.194 ms) : 0, 4194
Remote Config [baseline] (625.388 µs) : 0, 625
Remote Config [candidate] (620.306 µs) : 0, 620
Telemetry [baseline] (8.942 ms) : 0, 8942
Telemetry [candidate] (8.802 ms) : 0, 8802
section profiling
BytebuddyAgent [baseline] (709.692 ms) : 0, 709692
BytebuddyAgent [candidate] (715.614 ms) : 0, 715614
GlobalTracer [baseline] (348.477 ms) : 0, 348477
GlobalTracer [candidate] (350.91 ms) : 0, 350910
AppSec [baseline] (53.95 ms) : 0, 53950
AppSec [candidate] (53.637 ms) : 0, 53637
Debugger [baseline] (4.259 ms) : 0, 4259
Debugger [candidate] (4.287 ms) : 0, 4287
Remote Config [baseline] (701.354 µs) : 0, 701
Remote Config [candidate] (699.943 µs) : 0, 700
Telemetry [baseline] (8.911 ms) : 0, 8911
Telemetry [candidate] (8.946 ms) : 0, 8946
ProfilingAgent [baseline] (102.401 ms) : 0, 102401
ProfilingAgent [candidate] (103.802 ms) : 0, 103802
Profiling [baseline] (102.428 ms) : 0, 102428
Profiling [candidate] (103.827 ms) : 0, 103827
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~ef2a423c86, baseline=1.48.0-SNAPSHOT~4a5461cf3e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053787
Total [baseline] (8.678 s) : 0, 8677978
Agent [candidate] (1.061 s) : 0, 1060578
Total [candidate] (8.71 s) : 0, 8710290
section iast
Agent [baseline] (1.185 s) : 0, 1184679
Total [baseline] (9.335 s) : 0, 9335428
Agent [candidate] (1.184 s) : 0, 1183734
Total [candidate] (9.262 s) : 0, 9261967
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175878
Total [baseline] (9.19 s) : 0, 9189980
Agent [candidate] (1.181 s) : 0, 1181340
Total [candidate] (9.217 s) : 0, 9217470
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1181142
Total [baseline] (9.28 s) : 0, 9279591
Agent [candidate] (1.176 s) : 0, 1176431
Total [candidate] (9.255 s) : 0, 9255269
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~ef2a423c86, baseline=1.48.0-SNAPSHOT~4a5461cf3e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.78 ms) : 0, 721780
BytebuddyAgent [candidate] (726.087 ms) : 0, 726087
GlobalTracer [baseline] (239.945 ms) : 0, 239945
GlobalTracer [candidate] (241.67 ms) : 0, 241670
AppSec [baseline] (54.92 ms) : 0, 54920
AppSec [candidate] (55.05 ms) : 0, 55050
Debugger [baseline] (5.135 ms) : 0, 5135
Debugger [candidate] (6.667 ms) : 0, 6667
Remote Config [baseline] (708.524 µs) : 0, 709
Remote Config [candidate] (697.278 µs) : 0, 697
Telemetry [baseline] (11.473 ms) : 0, 11473
Telemetry [candidate] (10.593 ms) : 0, 10593
section iast
BytebuddyAgent [baseline] (842.79 ms) : 0, 842790
BytebuddyAgent [candidate] (840.549 ms) : 0, 840549
GlobalTracer [baseline] (229.686 ms) : 0, 229686
GlobalTracer [candidate] (230.673 ms) : 0, 230673
IAST [baseline] (22.765 ms) : 0, 22765
IAST [candidate] (22.952 ms) : 0, 22952
AppSec [baseline] (55.999 ms) : 0, 55999
AppSec [candidate] (56.211 ms) : 0, 56211
Debugger [baseline] (4.211 ms) : 0, 4211
Debugger [candidate] (4.195 ms) : 0, 4195
Remote Config [baseline] (623.399 µs) : 0, 623
Remote Config [candidate] (621.7 µs) : 0, 622
Telemetry [baseline] (8.92 ms) : 0, 8920
Telemetry [candidate] (8.854 ms) : 0, 8854
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.822 ms) : 0, 835822
BytebuddyAgent [candidate] (839.16 ms) : 0, 839160
GlobalTracer [baseline] (228.574 ms) : 0, 228574
GlobalTracer [candidate] (229.619 ms) : 0, 229619
IAST [baseline] (22.758 ms) : 0, 22758
IAST [candidate] (22.933 ms) : 0, 22933
AppSec [baseline] (55.765 ms) : 0, 55765
AppSec [candidate] (56.397 ms) : 0, 56397
Debugger [baseline] (4.122 ms) : 0, 4122
Debugger [candidate] (4.214 ms) : 0, 4214
Remote Config [baseline] (594.255 µs) : 0, 594
Remote Config [candidate] (598.151 µs) : 0, 598
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.74 ms) : 0, 8740
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.817 ms) : 0, 839817
BytebuddyAgent [candidate] (835.995 ms) : 0, 835995
GlobalTracer [baseline] (229.142 ms) : 0, 229142
GlobalTracer [candidate] (228.994 ms) : 0, 228994
IAST [baseline] (22.526 ms) : 0, 22526
IAST [candidate] (22.451 ms) : 0, 22451
AppSec [baseline] (56.426 ms) : 0, 56426
AppSec [candidate] (55.774 ms) : 0, 55774
Debugger [baseline] (4.182 ms) : 0, 4182
Debugger [candidate] (4.179 ms) : 0, 4179
Remote Config [baseline] (615.058 µs) : 0, 615
Remote Config [candidate] (612.233 µs) : 0, 612
Telemetry [baseline] (8.698 ms) : 0, 8698
Telemetry [candidate] (8.777 ms) : 0, 8777
LoadDacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~ef2a423c86, baseline=1.48.0-SNAPSHOT~4a5461cf3e
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.354 ms) : 2310, 2398
. : milestone, 2354,
iast (2.122 ms) : 2067, 2177
. : milestone, 2122,
iast_GLOBAL (2.169 ms) : 2113, 2225
. : milestone, 2169,
profiling (1.975 ms) : 1931, 2019
. : milestone, 1975,
tracing (1.957 ms) : 1915, 2000
. : milestone, 1957,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.351 ms) : 2308, 2395
. : milestone, 2351,
iast (2.134 ms) : 2079, 2190
. : milestone, 2134,
iast_GLOBAL (2.161 ms) : 2105, 2217
. : milestone, 2161,
profiling (2.001 ms) : 1955, 2046
. : milestone, 2001,
tracing (1.973 ms) : 1930, 2016
. : milestone, 1973,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~ef2a423c86, baseline=1.48.0-SNAPSHOT~4a5461cf3e
dateFormat X
axisFormat %s
section baseline
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
iast (18.896 s) : 18896000, 18896000
. : milestone, 18896000,
iast_GLOBAL (18.18 s) : 18180000, 18180000
. : milestone, 18180000,
profiling (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
tracing (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
section candidate
no_agent (15.653 s) : 15653000, 15653000
. : milestone, 15653000,
appsec (14.832 s) : 14832000, 14832000
. : milestone, 14832000,
iast (18.974 s) : 18974000, 18974000
. : milestone, 18974000,
iast_GLOBAL (18.144 s) : 18144000, 18144000
. : milestone, 18144000,
profiling (14.873 s) : 14873000, 14873000
. : milestone, 14873000,
tracing (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
|
amarziali
added
inst: websocket
amarziali
force-pushed
the
andrea.marziali/websocket-propagate
branch
from
c5d3158 to
f67f0a8
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| @@ -192,6 +192,10 @@ default AgentSpan asAgentSpan() { | |||
| return this; | |||
| } | |||
|
|
|||
| default void copyPropagationAndBaggage(final AgentSpan source) { | |||
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| default void copyPropagationAndBaggage(final AgentSpan source) { | |
| default void copyPropagationAndBaggage(AgentSpan source) { |
Avoid declaring as final as it may not be used (...read more)
The rule "Avoid useless final type in interface method" advises against the unnecessary use of the final keyword in the method parameters of an interface. In Java, the final keyword is used to denote that a variable cannot be changed once assigned. However, in the context of an interface method, this is redundant as the value of the parameter cannot be changed within the method anyway.
The importance of this rule lies in the clarity and simplicity of code. Unnecessary use of final in this context can lead to confusion for those reading the code, as it suggests that there may be a specific reason for its use when there is not. It can also clutter the code, making it less readable.
Good coding practices to avoid this rule violation include simply not using the final keyword in the method parameters of an interface. This does not affect the functionality of the code, but it makes it cleaner and easier to understand. For example, instead of writing void process(final Object arg);, you can write void process(Object arg);. This maintains the same functionality but improves the readability of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
According to the websocket RFC:
This PR copies propagation tags from the handshake to receive or close spans that are opened in a new trace and locks the DM if it's inherited since it's a requirement for the intake
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]