-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate V1/V2 custom events to validate metrics sent via telemetry #8640
Open
manuel-alvarez-alvarez
wants to merge
1
commit into
master
Choose a base branch
from
malvarez/ato-custom-event-metric
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~5ec4ad63ac, baseline=1.48.0-SNAPSHOT~6d284ce182
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059346
Total [baseline] (8.693 s) : 0, 8693334
Agent [candidate] (1.066 s) : 0, 1065653
Total [candidate] (8.668 s) : 0, 8668249
section iast
Agent [baseline] (1.189 s) : 0, 1188755
Total [baseline] (9.273 s) : 0, 9272548
Agent [candidate] (1.178 s) : 0, 1177950
Total [candidate] (9.228 s) : 0, 9227799
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1181486
Total [baseline] (9.227 s) : 0, 9226604
Agent [candidate] (1.18 s) : 0, 1180394
Total [candidate] (9.195 s) : 0, 9195499
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177553
Total [baseline] (9.236 s) : 0, 9235966
Agent [candidate] (1.176 s) : 0, 1175819
Total [candidate] (9.229 s) : 0, 9228687
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~5ec4ad63ac, baseline=1.48.0-SNAPSHOT~6d284ce182
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.624 ms) : 0, 723624
BytebuddyAgent [candidate] (728.755 ms) : 0, 728755
GlobalTracer [baseline] (241.4 ms) : 0, 241400
GlobalTracer [candidate] (242.356 ms) : 0, 242356
AppSec [baseline] (56.234 ms) : 0, 56234
AppSec [candidate] (57.179 ms) : 0, 57179
Debugger [baseline] (4.375 ms) : 0, 4375
Debugger [candidate] (4.448 ms) : 0, 4448
Remote Config [baseline] (707.089 µs) : 0, 707
Remote Config [candidate] (702.161 µs) : 0, 702
Telemetry [baseline] (12.307 ms) : 0, 12307
Telemetry [candidate] (11.422 ms) : 0, 11422
section iast
BytebuddyAgent [baseline] (845.054 ms) : 0, 845054
BytebuddyAgent [candidate] (836.063 ms) : 0, 836063
GlobalTracer [baseline] (230.501 ms) : 0, 230501
GlobalTracer [candidate] (229.292 ms) : 0, 229292
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (22.615 ms) : 0, 22615
AppSec [baseline] (56.143 ms) : 0, 56143
AppSec [candidate] (56.0 ms) : 0, 56000
Debugger [baseline] (4.143 ms) : 0, 4143
Debugger [candidate] (4.155 ms) : 0, 4155
Remote Config [baseline] (608.283 µs) : 0, 608
Remote Config [candidate] (596.675 µs) : 0, 597
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.775 ms) : 0, 8775
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.712 ms) : 0, 838712
BytebuddyAgent [candidate] (837.733 ms) : 0, 837733
GlobalTracer [baseline] (230.349 ms) : 0, 230349
GlobalTracer [candidate] (230.125 ms) : 0, 230125
IAST [baseline] (23.657 ms) : 0, 23657
IAST [candidate] (22.818 ms) : 0, 22818
AppSec [baseline] (54.679 ms) : 0, 54679
AppSec [candidate] (55.774 ms) : 0, 55774
Debugger [baseline] (4.146 ms) : 0, 4146
Debugger [candidate] (4.097 ms) : 0, 4097
Remote Config [baseline] (610.306 µs) : 0, 610
Remote Config [candidate] (596.592 µs) : 0, 597
Telemetry [baseline] (8.792 ms) : 0, 8792
Telemetry [candidate] (8.711 ms) : 0, 8711
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.168 ms) : 0, 836168
BytebuddyAgent [candidate] (834.759 ms) : 0, 834759
GlobalTracer [baseline] (229.511 ms) : 0, 229511
GlobalTracer [candidate] (229.226 ms) : 0, 229226
IAST [baseline] (23.07 ms) : 0, 23070
IAST [candidate] (22.269 ms) : 0, 22269
AppSec [baseline] (55.072 ms) : 0, 55072
AppSec [candidate] (55.855 ms) : 0, 55855
Debugger [baseline] (4.138 ms) : 0, 4138
Debugger [candidate] (4.172 ms) : 0, 4172
Remote Config [baseline] (593.299 µs) : 0, 593
Remote Config [candidate] (600.149 µs) : 0, 600
Telemetry [baseline] (8.558 ms) : 0, 8558
Telemetry [candidate] (8.511 ms) : 0, 8511
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~5ec4ad63ac, baseline=1.48.0-SNAPSHOT~6d284ce182
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047622
Total [baseline] (10.421 s) : 0, 10420808
Agent [candidate] (1.054 s) : 0, 1053704
Total [candidate] (10.48 s) : 0, 10480192
section appsec
Agent [baseline] (1.192 s) : 0, 1191992
Total [baseline] (10.729 s) : 0, 10728600
Agent [candidate] (1.19 s) : 0, 1190068
Total [candidate] (10.765 s) : 0, 10764535
section iast
Agent [baseline] (1.179 s) : 0, 1179495
Total [baseline] (11.039 s) : 0, 11039260
Agent [candidate] (1.18 s) : 0, 1179686
Total [candidate] (10.942 s) : 0, 10941620
section profiling
Agent [baseline] (1.281 s) : 0, 1281299
Total [baseline] (10.929 s) : 0, 10928791
Agent [candidate] (1.276 s) : 0, 1275791
Total [candidate] (10.883 s) : 0, 10883419
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~5ec4ad63ac, baseline=1.48.0-SNAPSHOT~6d284ce182
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.923 ms) : 0, 717923
BytebuddyAgent [candidate] (719.145 ms) : 0, 719145
GlobalTracer [baseline] (238.801 ms) : 0, 238801
GlobalTracer [candidate] (239.707 ms) : 0, 239707
AppSec [baseline] (53.983 ms) : 0, 53983
AppSec [candidate] (54.368 ms) : 0, 54368
Debugger [baseline] (4.365 ms) : 0, 4365
Debugger [candidate] (4.384 ms) : 0, 4384
Remote Config [baseline] (693.989 µs) : 0, 694
Remote Config [candidate] (694.881 µs) : 0, 695
Telemetry [baseline] (11.42 ms) : 0, 11420
Telemetry [candidate] (14.834 ms) : 0, 14834
section appsec
BytebuddyAgent [baseline] (736.506 ms) : 0, 736506
BytebuddyAgent [candidate] (735.446 ms) : 0, 735446
GlobalTracer [baseline] (235.338 ms) : 0, 235338
GlobalTracer [candidate] (235.082 ms) : 0, 235082
AppSec [baseline] (175.836 ms) : 0, 175836
AppSec [candidate] (175.408 ms) : 0, 175408
Debugger [baseline] (4.287 ms) : 0, 4287
Debugger [candidate] (4.243 ms) : 0, 4243
Remote Config [baseline] (636.548 µs) : 0, 637
Remote Config [candidate] (633.764 µs) : 0, 634
Telemetry [baseline] (8.212 ms) : 0, 8212
Telemetry [candidate] (8.17 ms) : 0, 8170
IAST [baseline] (21.447 ms) : 0, 21447
IAST [candidate] (21.376 ms) : 0, 21376
section iast
BytebuddyAgent [baseline] (837.957 ms) : 0, 837957
BytebuddyAgent [candidate] (838.1 ms) : 0, 838100
GlobalTracer [baseline] (229.54 ms) : 0, 229540
GlobalTracer [candidate] (229.54 ms) : 0, 229540
AppSec [baseline] (55.572 ms) : 0, 55572
AppSec [candidate] (55.714 ms) : 0, 55714
Debugger [baseline] (4.124 ms) : 0, 4124
Debugger [candidate] (4.094 ms) : 0, 4094
Remote Config [baseline] (600.24 µs) : 0, 600
Remote Config [candidate] (594.238 µs) : 0, 594
Telemetry [baseline] (8.63 ms) : 0, 8630
Telemetry [candidate] (8.606 ms) : 0, 8606
IAST [baseline] (22.658 ms) : 0, 22658
IAST [candidate] (22.6 ms) : 0, 22600
section profiling
BytebuddyAgent [baseline] (714.235 ms) : 0, 714235
BytebuddyAgent [candidate] (711.275 ms) : 0, 711275
GlobalTracer [baseline] (349.52 ms) : 0, 349520
GlobalTracer [candidate] (348.785 ms) : 0, 348785
AppSec [baseline] (54.936 ms) : 0, 54936
AppSec [candidate] (53.337 ms) : 0, 53337
Debugger [baseline] (4.261 ms) : 0, 4261
Debugger [candidate] (4.254 ms) : 0, 4254
Remote Config [baseline] (697.702 µs) : 0, 698
Remote Config [candidate] (692.384 µs) : 0, 692
Telemetry [baseline] (9.05 ms) : 0, 9050
Telemetry [candidate] (8.924 ms) : 0, 8924
ProfilingAgent [baseline] (102.646 ms) : 0, 102646
ProfilingAgent [candidate] (102.444 ms) : 0, 102444
Profiling [baseline] (102.671 ms) : 0, 102671
Profiling [candidate] (102.47 ms) : 0, 102470
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~5ec4ad63ac, baseline=1.48.0-SNAPSHOT~6d284ce182
dateFormat X
axisFormat %s
section baseline
no_agent (383.772 µs) : 364, 404
. : milestone, 384,
iast (519.971 µs) : 498, 542
. : milestone, 520,
iast_FULL (736.431 µs) : 715, 758
. : milestone, 736,
iast_GLOBAL (559.685 µs) : 538, 581
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (526.293 µs) : 504, 548
. : milestone, 526,
iast_INACTIVE (473.252 µs) : 452, 495
. : milestone, 473,
iast_TELEMETRY_OFF (508.588 µs) : 487, 530
. : milestone, 509,
tracing (478.681 µs) : 457, 500
. : milestone, 479,
section candidate
no_agent (387.311 µs) : 366, 408
. : milestone, 387,
iast (519.491 µs) : 498, 541
. : milestone, 519,
iast_FULL (739.78 µs) : 717, 762
. : milestone, 740,
iast_GLOBAL (563.32 µs) : 541, 585
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (518.271 µs) : 497, 540
. : milestone, 518,
iast_INACTIVE (476.049 µs) : 454, 498
. : milestone, 476,
iast_TELEMETRY_OFF (507.669 µs) : 486, 529
. : milestone, 508,
tracing (463.815 µs) : 443, 485
. : milestone, 464,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~5ec4ad63ac, baseline=1.48.0-SNAPSHOT~6d284ce182
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
. : milestone, 1355,
appsec (1.751 ms) : 1728, 1775
. : milestone, 1751,
appsec_no_iast (1.742 ms) : 1718, 1765
. : milestone, 1742,
code_origins (1.705 ms) : 1678, 1732
. : milestone, 1705,
iast (1.559 ms) : 1534, 1583
. : milestone, 1559,
profiling (1.523 ms) : 1500, 1547
. : milestone, 1523,
tracing (1.544 ms) : 1520, 1568
. : milestone, 1544,
section candidate
no_agent (1.359 ms) : 1339, 1379
. : milestone, 1359,
appsec (1.766 ms) : 1743, 1790
. : milestone, 1766,
appsec_no_iast (1.745 ms) : 1721, 1768
. : milestone, 1745,
code_origins (1.7 ms) : 1674, 1727
. : milestone, 1700,
iast (1.542 ms) : 1518, 1567
. : milestone, 1542,
profiling (1.552 ms) : 1529, 1575
. : milestone, 1552,
tracing (1.508 ms) : 1482, 1533
. : milestone, 1508,
Dacapo |
jandro996
approved these changes
Mar 28, 2025
smola
approved these changes
Apr 3, 2025
bc2bae0
to
5ec4ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
tag: no release notes
Changes to exclude from release notes
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Sends separated telemetry payloads for V1/V2 custom events.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]