-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jvmstat for JDKs 9+ programmatically #8641
Draft
MattAlp
wants to merge
4
commits into
master
Choose a base branch
from
mattalp/patch-jvmstat-access
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049538
Total [baseline] (10.519 s) : 0, 10519169
Agent [candidate] (1.051 s) : 0, 1051150
Total [candidate] (10.514 s) : 0, 10514347
section appsec
Agent [baseline] (1.194 s) : 0, 1193832
Total [baseline] (10.707 s) : 0, 10706928
Agent [candidate] (1.193 s) : 0, 1193050
Total [candidate] (10.804 s) : 0, 10803630
section iast
Agent [baseline] (1.178 s) : 0, 1178192
Total [baseline] (11.014 s) : 0, 11014452
Agent [candidate] (1.18 s) : 0, 1179626
Total [candidate] (10.985 s) : 0, 10985303
section profiling
Agent [baseline] (1.28 s) : 0, 1279653
Total [baseline] (10.836 s) : 0, 10836477
Agent [candidate] (1.297 s) : 0, 1297443
Total [candidate] (10.948 s) : 0, 10948486
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.4 ms) : 0, 717400
BytebuddyAgent [candidate] (715.822 ms) : 0, 715822
GlobalTracer [baseline] (238.592 ms) : 0, 238592
GlobalTracer [candidate] (239.595 ms) : 0, 239595
AppSec [baseline] (54.205 ms) : 0, 54205
AppSec [candidate] (56.001 ms) : 0, 56001
Debugger [baseline] (4.432 ms) : 0, 4432
Debugger [candidate] (4.393 ms) : 0, 4393
Remote Config [baseline] (691.2 µs) : 0, 691
Remote Config [candidate] (708.049 µs) : 0, 708
Telemetry [baseline] (13.661 ms) : 0, 13661
Telemetry [candidate] (12.209 ms) : 0, 12209
section appsec
BytebuddyAgent [baseline] (737.586 ms) : 0, 737586
BytebuddyAgent [candidate] (737.168 ms) : 0, 737168
GlobalTracer [baseline] (235.09 ms) : 0, 235090
GlobalTracer [candidate] (237.318 ms) : 0, 237318
IAST [baseline] (21.583 ms) : 0, 21583
IAST [candidate] (21.819 ms) : 0, 21819
AppSec [baseline] (176.01 ms) : 0, 176010
AppSec [candidate] (171.649 ms) : 0, 171649
Debugger [baseline] (4.288 ms) : 0, 4288
Debugger [candidate] (4.682 ms) : 0, 4682
Remote Config [baseline] (645.84 µs) : 0, 646
Remote Config [candidate] (655.346 µs) : 0, 655
Telemetry [baseline] (8.917 ms) : 0, 8917
Telemetry [candidate] (8.191 ms) : 0, 8191
section iast
BytebuddyAgent [baseline] (836.277 ms) : 0, 836277
BytebuddyAgent [candidate] (834.995 ms) : 0, 834995
GlobalTracer [baseline] (228.889 ms) : 0, 228889
GlobalTracer [candidate] (230.692 ms) : 0, 230692
IAST [baseline] (22.755 ms) : 0, 22755
IAST [candidate] (22.763 ms) : 0, 22763
AppSec [baseline] (56.181 ms) : 0, 56181
AppSec [candidate] (55.139 ms) : 0, 55139
Debugger [baseline] (4.176 ms) : 0, 4176
Debugger [candidate] (4.286 ms) : 0, 4286
Remote Config [baseline] (619.719 µs) : 0, 620
Remote Config [candidate] (614.657 µs) : 0, 615
Telemetry [baseline] (8.82 ms) : 0, 8820
Telemetry [candidate] (8.773 ms) : 0, 8773
section profiling
BytebuddyAgent [baseline] (714.742 ms) : 0, 714742
BytebuddyAgent [candidate] (721.247 ms) : 0, 721247
GlobalTracer [baseline] (348.64 ms) : 0, 348640
GlobalTracer [candidate] (356.008 ms) : 0, 356008
AppSec [baseline] (53.93 ms) : 0, 53930
AppSec [candidate] (54.614 ms) : 0, 54614
Debugger [baseline] (4.327 ms) : 0, 4327
Debugger [candidate] (4.406 ms) : 0, 4406
Remote Config [baseline] (691.889 µs) : 0, 692
Remote Config [candidate] (725.38 µs) : 0, 725
Telemetry [baseline] (9.048 ms) : 0, 9048
Telemetry [candidate] (9.165 ms) : 0, 9165
ProfilingAgent [baseline] (102.299 ms) : 0, 102299
ProfilingAgent [candidate] (103.17 ms) : 0, 103170
Profiling [baseline] (102.324 ms) : 0, 102324
Profiling [candidate] (103.195 ms) : 0, 103195
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061406
Total [baseline] (8.701 s) : 0, 8700880
Agent [candidate] (1.05 s) : 0, 1050051
Total [candidate] (8.662 s) : 0, 8661816
section iast
Agent [baseline] (1.176 s) : 0, 1176447
Total [baseline] (9.26 s) : 0, 9259871
Agent [candidate] (1.182 s) : 0, 1181794
Total [candidate] (9.29 s) : 0, 9290497
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1184301
Total [baseline] (9.227 s) : 0, 9226662
Agent [candidate] (1.186 s) : 0, 1186386
Total [candidate] (9.249 s) : 0, 9248616
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1179869
Total [baseline] (9.265 s) : 0, 9264962
Agent [candidate] (1.178 s) : 0, 1177893
Total [candidate] (9.268 s) : 0, 9267898
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.815 ms) : 0, 725815
BytebuddyAgent [candidate] (716.59 ms) : 0, 716590
GlobalTracer [baseline] (241.371 ms) : 0, 241371
GlobalTracer [candidate] (239.307 ms) : 0, 239307
AppSec [baseline] (55.449 ms) : 0, 55449
AppSec [candidate] (54.347 ms) : 0, 54347
Debugger [baseline] (5.223 ms) : 0, 5223
Debugger [candidate] (4.429 ms) : 0, 4429
Remote Config [baseline] (692.31 µs) : 0, 692
Remote Config [candidate] (730.152 µs) : 0, 730
Telemetry [baseline] (12.163 ms) : 0, 12163
Telemetry [candidate] (12.269 ms) : 0, 12269
section iast
BytebuddyAgent [baseline] (835.895 ms) : 0, 835895
BytebuddyAgent [candidate] (836.142 ms) : 0, 836142
GlobalTracer [baseline] (228.204 ms) : 0, 228204
GlobalTracer [candidate] (230.705 ms) : 0, 230705
IAST [baseline] (22.773 ms) : 0, 22773
IAST [candidate] (22.953 ms) : 0, 22953
AppSec [baseline] (55.397 ms) : 0, 55397
AppSec [candidate] (55.892 ms) : 0, 55892
Debugger [baseline] (4.193 ms) : 0, 4193
Debugger [candidate] (4.331 ms) : 0, 4331
Remote Config [baseline] (613.788 µs) : 0, 614
Remote Config [candidate] (629.908 µs) : 0, 630
Telemetry [baseline] (8.832 ms) : 0, 8832
Telemetry [candidate] (8.817 ms) : 0, 8817
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.667 ms) : 0, 841667
BytebuddyAgent [candidate] (840.796 ms) : 0, 840796
GlobalTracer [baseline] (229.663 ms) : 0, 229663
GlobalTracer [candidate] (231.229 ms) : 0, 231229
IAST [baseline] (22.971 ms) : 0, 22971
IAST [candidate] (22.908 ms) : 0, 22908
AppSec [baseline] (55.811 ms) : 0, 55811
AppSec [candidate] (55.384 ms) : 0, 55384
Debugger [baseline] (4.173 ms) : 0, 4173
Debugger [candidate] (4.251 ms) : 0, 4251
Remote Config [baseline] (607.645 µs) : 0, 608
Remote Config [candidate] (615.799 µs) : 0, 616
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (8.73 ms) : 0, 8730
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.566 ms) : 0, 838566
BytebuddyAgent [candidate] (832.988 ms) : 0, 832988
GlobalTracer [baseline] (228.984 ms) : 0, 228984
GlobalTracer [candidate] (230.365 ms) : 0, 230365
IAST [baseline] (22.493 ms) : 0, 22493
IAST [candidate] (22.485 ms) : 0, 22485
AppSec [baseline] (55.829 ms) : 0, 55829
AppSec [candidate] (56.023 ms) : 0, 56023
Debugger [baseline] (4.183 ms) : 0, 4183
Debugger [candidate] (4.218 ms) : 0, 4218
Remote Config [baseline] (617.295 µs) : 0, 617
Remote Config [candidate] (623.704 µs) : 0, 624
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.8 ms) : 0, 8800
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1329, 1370
. : milestone, 1350,
appsec (1.737 ms) : 1713, 1762
. : milestone, 1737,
appsec_no_iast (1.72 ms) : 1696, 1744
. : milestone, 1720,
code_origins (1.666 ms) : 1639, 1692
. : milestone, 1666,
iast (1.5 ms) : 1476, 1523
. : milestone, 1500,
profiling (1.511 ms) : 1488, 1534
. : milestone, 1511,
tracing (1.492 ms) : 1467, 1516
. : milestone, 1492,
section candidate
no_agent (1.363 ms) : 1343, 1382
. : milestone, 1363,
appsec (1.725 ms) : 1701, 1748
. : milestone, 1725,
appsec_no_iast (1.736 ms) : 1713, 1759
. : milestone, 1736,
code_origins (1.674 ms) : 1647, 1701
. : milestone, 1674,
iast (1.499 ms) : 1475, 1523
. : milestone, 1499,
profiling (1.539 ms) : 1514, 1564
. : milestone, 1539,
tracing (1.492 ms) : 1467, 1517
. : milestone, 1492,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section baseline
no_agent (378.282 µs) : 358, 399
. : milestone, 378,
iast (507.482 µs) : 485, 529
. : milestone, 507,
iast_FULL (727.782 µs) : 706, 750
. : milestone, 728,
iast_GLOBAL (550.638 µs) : 529, 572
. : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (509.881 µs) : 488, 531
. : milestone, 510,
iast_INACTIVE (454.308 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (493.073 µs) : 471, 515
. : milestone, 493,
tracing (455.37 µs) : 434, 477
. : milestone, 455,
section candidate
no_agent (378.997 µs) : 359, 399
. : milestone, 379,
iast (511.479 µs) : 490, 533
. : milestone, 511,
iast_FULL (720.95 µs) : 699, 743
. : milestone, 721,
iast_GLOBAL (552.82 µs) : 531, 574
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (504.328 µs) : 483, 526
. : milestone, 504,
iast_INACTIVE (459.348 µs) : 438, 481
. : milestone, 459,
iast_TELEMETRY_OFF (501.202 µs) : 479, 523
. : milestone, 501,
tracing (456.7 µs) : 436, 478
. : milestone, 457,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.345 ms) : 2301, 2389
. : milestone, 2345,
iast (2.117 ms) : 2061, 2173
. : milestone, 2117,
iast_GLOBAL (2.163 ms) : 2107, 2219
. : milestone, 2163,
profiling (1.977 ms) : 1932, 2021
. : milestone, 1977,
tracing (1.962 ms) : 1919, 2005
. : milestone, 1962,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.34 ms) : 2296, 2384
. : milestone, 2340,
iast (2.13 ms) : 2074, 2186
. : milestone, 2130,
iast_GLOBAL (2.178 ms) : 2121, 2235
. : milestone, 2178,
profiling (1.985 ms) : 1940, 2030
. : milestone, 1985,
tracing (1.957 ms) : 1913, 2000
. : milestone, 1957,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~9c0bcf5efc, baseline=1.48.0-SNAPSHOT~2a848ef2e2
dateFormat X
axisFormat %s
section baseline
no_agent (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
appsec (14.811 s) : 14811000, 14811000
. : milestone, 14811000,
iast (18.844 s) : 18844000, 18844000
. : milestone, 18844000,
iast_GLOBAL (18.107 s) : 18107000, 18107000
. : milestone, 18107000,
profiling (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
tracing (15.283 s) : 15283000, 15283000
. : milestone, 15283000,
section candidate
no_agent (15.36 s) : 15360000, 15360000
. : milestone, 15360000,
appsec (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
iast (19.015 s) : 19015000, 19015000
. : milestone, 19015000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
. : milestone, 17912000,
profiling (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
tracing (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR begins the process of deprecating the use of
jps
via a subprocess, accomplished by exposing thejvmstat
code used byjps
under the hood using module patching (for JDKs 9+).Motivation
Customer machines often come without tools like
jps
available, causing cleanup related-tasks to fail.Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-11290