-
Notifications
You must be signed in to change notification settings - Fork 300
Introducing an internal instrumentation component name #8708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071232
Total [baseline] (8.723 s) : 0, 8722882
Agent [candidate] (1.058 s) : 0, 1058134
Total [candidate] (8.698 s) : 0, 8698323
section iast
Agent [baseline] (1.187 s) : 0, 1187341
Total [baseline] (9.253 s) : 0, 9253364
Agent [candidate] (1.189 s) : 0, 1188638
Total [candidate] (9.242 s) : 0, 9242023
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183019
Total [baseline] (9.223 s) : 0, 9222862
Agent [candidate] (1.185 s) : 0, 1185283
Total [candidate] (9.206 s) : 0, 9206122
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1189509
Total [baseline] (9.297 s) : 0, 9297119
Agent [candidate] (1.188 s) : 0, 1188295
Total [candidate] (9.253 s) : 0, 9253091
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (731.134 ms) : 0, 731134
BytebuddyAgent [candidate] (722.234 ms) : 0, 722234
GlobalTracer [baseline] (242.402 ms) : 0, 242402
GlobalTracer [candidate] (239.844 ms) : 0, 239844
AppSec [baseline] (54.606 ms) : 0, 54606
AppSec [candidate] (55.421 ms) : 0, 55421
Debugger [baseline] (4.386 ms) : 0, 4386
Debugger [candidate] (5.082 ms) : 0, 5082
Remote Config [baseline] (4.302 ms) : 0, 4302
Remote Config [candidate] (2.177 ms) : 0, 2177
Telemetry [baseline] (10.726 ms) : 0, 10726
Telemetry [candidate] (9.93 ms) : 0, 9930
section iast
BytebuddyAgent [baseline] (840.969 ms) : 0, 840969
BytebuddyAgent [candidate] (841.771 ms) : 0, 841771
GlobalTracer [baseline] (230.761 ms) : 0, 230761
GlobalTracer [candidate] (230.766 ms) : 0, 230766
IAST [baseline] (24.369 ms) : 0, 24369
IAST [candidate] (23.856 ms) : 0, 23856
AppSec [baseline] (54.262 ms) : 0, 54262
AppSec [candidate] (55.306 ms) : 0, 55306
Debugger [baseline] (4.281 ms) : 0, 4281
Debugger [candidate] (4.255 ms) : 0, 4255
Remote Config [baseline] (610.35 µs) : 0, 610
Remote Config [candidate] (599.642 µs) : 0, 600
Telemetry [baseline] (8.711 ms) : 0, 8711
Telemetry [candidate] (8.69 ms) : 0, 8690
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.584 ms) : 0, 838584
BytebuddyAgent [candidate] (840.077 ms) : 0, 840077
GlobalTracer [baseline] (229.275 ms) : 0, 229275
GlobalTracer [candidate] (229.628 ms) : 0, 229628
IAST [baseline] (25.064 ms) : 0, 25064
IAST [candidate] (26.109 ms) : 0, 26109
AppSec [baseline] (53.344 ms) : 0, 53344
AppSec [candidate] (52.439 ms) : 0, 52439
Debugger [baseline] (4.192 ms) : 0, 4192
Debugger [candidate] (4.239 ms) : 0, 4239
Remote Config [baseline] (603.541 µs) : 0, 604
Remote Config [candidate] (591.794 µs) : 0, 592
Telemetry [baseline] (8.655 ms) : 0, 8655
Telemetry [candidate] (8.79 ms) : 0, 8790
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (843.514 ms) : 0, 843514
BytebuddyAgent [candidate] (842.804 ms) : 0, 842804
GlobalTracer [baseline] (230.439 ms) : 0, 230439
GlobalTracer [candidate] (230.528 ms) : 0, 230528
IAST [baseline] (22.462 ms) : 0, 22462
IAST [candidate] (22.564 ms) : 0, 22564
AppSec [baseline] (56.003 ms) : 0, 56003
AppSec [candidate] (55.632 ms) : 0, 55632
Debugger [baseline] (4.187 ms) : 0, 4187
Debugger [candidate] (4.12 ms) : 0, 4120
Remote Config [baseline] (647.814 µs) : 0, 648
Remote Config [candidate] (624.055 µs) : 0, 624
Telemetry [baseline] (8.749 ms) : 0, 8749
Telemetry [candidate] (8.564 ms) : 0, 8564
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058280
Total [baseline] (10.593 s) : 0, 10593262
Agent [candidate] (1.058 s) : 0, 1057966
Total [candidate] (10.47 s) : 0, 10470368
section appsec
Agent [baseline] (1.202 s) : 0, 1201956
Total [baseline] (10.822 s) : 0, 10822269
Agent [candidate] (1.204 s) : 0, 1204249
Total [candidate] (10.819 s) : 0, 10818684
section iast
Agent [baseline] (1.194 s) : 0, 1194178
Total [baseline] (11.111 s) : 0, 11110599
Agent [candidate] (1.195 s) : 0, 1195364
Total [candidate] (11.08 s) : 0, 11080303
section profiling
Agent [baseline] (1.298 s) : 0, 1298116
Total [baseline] (10.931 s) : 0, 10931345
Agent [candidate] (1.294 s) : 0, 1294313
Total [candidate] (10.91 s) : 0, 10910102
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.885 ms) : 0, 721885
BytebuddyAgent [candidate] (721.679 ms) : 0, 721679
GlobalTracer [baseline] (239.373 ms) : 0, 239373
GlobalTracer [candidate] (239.879 ms) : 0, 239879
AppSec [baseline] (54.92 ms) : 0, 54920
AppSec [candidate] (55.828 ms) : 0, 55828
Debugger [baseline] (4.364 ms) : 0, 4364
Debugger [candidate] (4.4 ms) : 0, 4400
Remote Config [baseline] (683.259 µs) : 0, 683
Remote Config [candidate] (686.981 µs) : 0, 687
Telemetry [baseline] (13.57 ms) : 0, 13570
Telemetry [candidate] (12.106 ms) : 0, 12106
section appsec
BytebuddyAgent [baseline] (741.587 ms) : 0, 741587
BytebuddyAgent [candidate] (743.553 ms) : 0, 743553
GlobalTracer [baseline] (236.43 ms) : 0, 236430
GlobalTracer [candidate] (237.412 ms) : 0, 237412
IAST [baseline] (21.975 ms) : 0, 21975
IAST [candidate] (22.287 ms) : 0, 22287
AppSec [baseline] (176.375 ms) : 0, 176375
AppSec [candidate] (175.567 ms) : 0, 175567
Debugger [baseline] (4.252 ms) : 0, 4252
Debugger [candidate] (4.232 ms) : 0, 4232
Remote Config [baseline] (636.794 µs) : 0, 637
Remote Config [candidate] (628.986 µs) : 0, 629
Telemetry [baseline] (8.213 ms) : 0, 8213
Telemetry [candidate] (8.215 ms) : 0, 8215
section iast
BytebuddyAgent [baseline] (846.671 ms) : 0, 846671
BytebuddyAgent [candidate] (847.986 ms) : 0, 847986
GlobalTracer [baseline] (231.042 ms) : 0, 231042
GlobalTracer [candidate] (231.472 ms) : 0, 231472
IAST [baseline] (23.59 ms) : 0, 23590
IAST [candidate] (22.999 ms) : 0, 22999
AppSec [baseline] (55.65 ms) : 0, 55650
AppSec [candidate] (55.82 ms) : 0, 55820
Debugger [baseline] (4.283 ms) : 0, 4283
Debugger [candidate] (4.241 ms) : 0, 4241
Remote Config [baseline] (609.224 µs) : 0, 609
Remote Config [candidate] (614.452 µs) : 0, 614
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.674 ms) : 0, 8674
section profiling
BytebuddyAgent [baseline] (715.613 ms) : 0, 715613
BytebuddyAgent [candidate] (713.37 ms) : 0, 713370
GlobalTracer [baseline] (361.557 ms) : 0, 361557
GlobalTracer [candidate] (361.603 ms) : 0, 361603
AppSec [baseline] (54.335 ms) : 0, 54335
AppSec [candidate] (53.067 ms) : 0, 53067
Debugger [baseline] (4.449 ms) : 0, 4449
Debugger [candidate] (4.39 ms) : 0, 4390
Remote Config [baseline] (695.184 µs) : 0, 695
Remote Config [candidate] (652.609 µs) : 0, 653
Telemetry [baseline] (9.057 ms) : 0, 9057
Telemetry [candidate] (8.983 ms) : 0, 8983
ProfilingAgent [baseline] (101.967 ms) : 0, 101967
ProfilingAgent [candidate] (102.017 ms) : 0, 102017
Profiling [baseline] (101.992 ms) : 0, 101992
Profiling [candidate] (102.042 ms) : 0, 102042
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section baseline
no_agent (378.82 µs) : 359, 399
. : milestone, 379,
iast (510.069 µs) : 488, 532
. : milestone, 510,
iast_FULL (729.451 µs) : 708, 751
. : milestone, 729,
iast_GLOBAL (553.102 µs) : 531, 575
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (511.987 µs) : 490, 534
. : milestone, 512,
iast_INACTIVE (461.629 µs) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (503.546 µs) : 481, 526
. : milestone, 504,
tracing (457.762 µs) : 436, 479
. : milestone, 458,
section candidate
no_agent (383.161 µs) : 362, 404
. : milestone, 383,
iast (510.16 µs) : 489, 532
. : milestone, 510,
iast_FULL (733.416 µs) : 711, 756
. : milestone, 733,
iast_GLOBAL (562.371 µs) : 539, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (508.413 µs) : 487, 530
. : milestone, 508,
iast_INACTIVE (459.665 µs) : 438, 481
. : milestone, 460,
iast_TELEMETRY_OFF (501.188 µs) : 479, 523
. : milestone, 501,
tracing (456.376 µs) : 435, 478
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section baseline
no_agent (1.371 ms) : 1352, 1390
. : milestone, 1371,
appsec (1.728 ms) : 1703, 1752
. : milestone, 1728,
appsec_no_iast (1.722 ms) : 1699, 1746
. : milestone, 1722,
code_origins (1.697 ms) : 1670, 1725
. : milestone, 1697,
iast (1.508 ms) : 1484, 1532
. : milestone, 1508,
profiling (1.523 ms) : 1498, 1548
. : milestone, 1523,
tracing (1.516 ms) : 1492, 1539
. : milestone, 1516,
section candidate
no_agent (1.363 ms) : 1343, 1383
. : milestone, 1363,
appsec (1.726 ms) : 1702, 1751
. : milestone, 1726,
appsec_no_iast (1.736 ms) : 1712, 1759
. : milestone, 1736,
code_origins (1.684 ms) : 1657, 1711
. : milestone, 1684,
iast (1.522 ms) : 1497, 1547
. : milestone, 1522,
profiling (1.555 ms) : 1531, 1579
. : milestone, 1555,
tracing (1.498 ms) : 1473, 1524
. : milestone, 1498,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.336 ms) : 2293, 2380
. : milestone, 2336,
iast (2.113 ms) : 2058, 2168
. : milestone, 2113,
iast_GLOBAL (2.154 ms) : 2098, 2210
. : milestone, 2154,
profiling (1.967 ms) : 1923, 2011
. : milestone, 1967,
tracing (1.943 ms) : 1901, 1985
. : milestone, 1943,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.344 ms) : 2300, 2387
. : milestone, 2344,
iast (2.117 ms) : 2062, 2173
. : milestone, 2117,
iast_GLOBAL (2.153 ms) : 2097, 2209
. : milestone, 2153,
profiling (2.435 ms) : 2264, 2607
. : milestone, 2435,
tracing (1.954 ms) : 1912, 1997
. : milestone, 1954,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~8922284d45, baseline=1.49.0-SNAPSHOT~0604f664bc
dateFormat X
axisFormat %s
section baseline
no_agent (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
appsec (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
iast (18.536 s) : 18536000, 18536000
. : milestone, 18536000,
iast_GLOBAL (18.242 s) : 18242000, 18242000
. : milestone, 18242000,
profiling (15.543 s) : 15543000, 15543000
. : milestone, 15543000,
tracing (14.723 s) : 14723000, 14723000
. : milestone, 14723000,
section candidate
no_agent (15.24 s) : 15240000, 15240000
. : milestone, 15240000,
appsec (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
iast (18.517 s) : 18517000, 18517000
. : milestone, 18517000,
iast_GLOBAL (17.718 s) : 17718000, 17718000
. : milestone, 17718000,
profiling (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
tracing (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
|
What Does This Do
This pull request introduced an internal field on the
AgentSpanContext
to store a reliable component name used by instrumentations.The goal is to have it reliably serialized under
_dd.integration_component
. This will contribute to have internal usage data points on integrations.It also adds component for
opentracing
andopentelemetry
originated spans that will give us an idea of the source of the span.It differs from the
spans_created
telemetry since that usage data is not calculated on the tracer side but on the intake. It will give us more flexibility especially wrt changes on the metric since it won't require tracer changesThe data is also attached to any span. Especially for customer issues, this will help to understand if a span was internally or externally created
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]