-
Notifications
You must be signed in to change notification settings - Fork 300
Added graphql span events for errors #8721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nayeem-kamal
wants to merge
16
commits into
master
Choose a base branch
from
nayeem-kamal/graphql-errors-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
BenchmarksStartupParameters
See matching parameters
SummaryFound 8 performance improvements and 22 performance regressions! Performance is the same for 37 metrics, 4 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020760
Total [baseline] (8.655 s) : 0, 8654581
Agent [candidate] (1.049 s) : 0, 1048551
Total [candidate] (8.648 s) : 0, 8648230
section iast
Agent [baseline] (1.137 s) : 0, 1136981
Total [baseline] (9.174 s) : 0, 9173922
Agent [candidate] (1.178 s) : 0, 1178461
Total [candidate] (9.281 s) : 0, 9281224
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.134 s) : 0, 1134341
Total [baseline] (9.179 s) : 0, 9179062
Agent [candidate] (1.184 s) : 0, 1183965
Total [candidate] (9.193 s) : 0, 9192873
section iast_TELEMETRY_OFF
Agent [baseline] (1.131 s) : 0, 1131162
Total [baseline] (9.19 s) : 0, 9190353
Agent [candidate] (1.182 s) : 0, 1182121
Total [candidate] (9.225 s) : 0, 9224747
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.011 ms) : 0, 681011
BytebuddyAgent [candidate] (717.287 ms) : 0, 717287
GlobalTracer [baseline] (243.525 ms) : 0, 243525
GlobalTracer [candidate] (239.745 ms) : 0, 239745
AppSec [baseline] (55.648 ms) : 0, 55648
AppSec [candidate] (54.675 ms) : 0, 54675
Debugger [baseline] (6.917 ms) : 0, 6917
Debugger [candidate] (4.364 ms) : 0, 4364
Remote Config [baseline] (713.59 µs) : 0, 714
Remote Config [candidate] (704.628 µs) : 0, 705
Telemetry [baseline] (9.357 ms) : 0, 9357
Telemetry [candidate] (15.761 ms) : 0, 15761
section iast
BytebuddyAgent [baseline] (790.394 ms) : 0, 790394
BytebuddyAgent [candidate] (839.658 ms) : 0, 839658
GlobalTracer [baseline] (230.055 ms) : 0, 230055
GlobalTracer [candidate] (230.687 ms) : 0, 230687
IAST [baseline] (22.633 ms) : 0, 22633
IAST [candidate] (22.832 ms) : 0, 22832
AppSec [baseline] (56.092 ms) : 0, 56092
AppSec [candidate] (55.835 ms) : 0, 55835
Debugger [baseline] (5.868 ms) : 0, 5868
Debugger [candidate] (4.154 ms) : 0, 4154
Remote Config [baseline] (576.855 µs) : 0, 577
Remote Config [candidate] (605.181 µs) : 0, 605
Telemetry [baseline] (7.95 ms) : 0, 7950
Telemetry [candidate] (8.759 ms) : 0, 8759
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.144 ms) : 0, 788144
BytebuddyAgent [candidate] (843.773 ms) : 0, 843773
GlobalTracer [baseline] (229.418 ms) : 0, 229418
GlobalTracer [candidate] (231.279 ms) : 0, 231279
IAST [baseline] (22.811 ms) : 0, 22811
IAST [candidate] (22.914 ms) : 0, 22914
AppSec [baseline] (56.324 ms) : 0, 56324
AppSec [candidate] (56.264 ms) : 0, 56264
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (4.171 ms) : 0, 4171
Remote Config [baseline] (592.781 µs) : 0, 593
Remote Config [candidate] (604.751 µs) : 0, 605
Telemetry [baseline] (7.89 ms) : 0, 7890
Telemetry [candidate] (8.894 ms) : 0, 8894
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (785.664 ms) : 0, 785664
BytebuddyAgent [candidate] (842.012 ms) : 0, 842012
GlobalTracer [baseline] (229.598 ms) : 0, 229598
GlobalTracer [candidate] (231.861 ms) : 0, 231861
IAST [baseline] (22.233 ms) : 0, 22233
IAST [candidate] (22.638 ms) : 0, 22638
AppSec [baseline] (55.978 ms) : 0, 55978
AppSec [candidate] (56.052 ms) : 0, 56052
Debugger [baseline] (5.902 ms) : 0, 5902
Debugger [candidate] (4.123 ms) : 0, 4123
Remote Config [baseline] (602.392 µs) : 0, 602
Remote Config [candidate] (597.947 µs) : 0, 598
Telemetry [baseline] (7.801 ms) : 0, 7801
Telemetry [candidate] (8.636 ms) : 0, 8636
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003565
Total [baseline] (10.419 s) : 0, 10419184
Agent [candidate] (1.053 s) : 0, 1053352
Total [candidate] (10.409 s) : 0, 10408967
section appsec
Agent [baseline] (1.148 s) : 0, 1148131
Total [baseline] (10.65 s) : 0, 10649811
Agent [candidate] (1.195 s) : 0, 1195485
Total [candidate] (10.789 s) : 0, 10789168
section iast
Agent [baseline] (1.135 s) : 0, 1134674
Total [baseline] (10.858 s) : 0, 10857797
Agent [candidate] (1.175 s) : 0, 1175297
Total [candidate] (11.02 s) : 0, 11019688
section profiling
Agent [baseline] (1.25 s) : 0, 1250485
Total [baseline] (10.713 s) : 0, 10713025
Agent [candidate] (1.271 s) : 0, 1270586
Total [candidate] (10.83 s) : 0, 10829988
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.764 ms) : 0, 668764
BytebuddyAgent [candidate] (726.124 ms) : 0, 726124
GlobalTracer [baseline] (239.445 ms) : 0, 239445
GlobalTracer [candidate] (240.828 ms) : 0, 240828
AppSec [baseline] (54.496 ms) : 0, 54496
AppSec [candidate] (54.569 ms) : 0, 54569
Debugger [baseline] (6.144 ms) : 0, 6144
Debugger [candidate] (4.359 ms) : 0, 4359
Remote Config [baseline] (715.36 µs) : 0, 715
Remote Config [candidate] (713.777 µs) : 0, 714
Telemetry [baseline] (10.598 ms) : 0, 10598
Telemetry [candidate] (10.639 ms) : 0, 10639
section appsec
BytebuddyAgent [baseline] (687.586 ms) : 0, 687586
BytebuddyAgent [candidate] (740.823 ms) : 0, 740823
GlobalTracer [baseline] (236.224 ms) : 0, 236224
GlobalTracer [candidate] (237.48 ms) : 0, 237480
AppSec [baseline] (175.843 ms) : 0, 175843
AppSec [candidate] (176.562 ms) : 0, 176562
Debugger [baseline] (5.873 ms) : 0, 5873
Debugger [candidate] (4.32 ms) : 0, 4320
Remote Config [baseline] (634.801 µs) : 0, 635
Remote Config [candidate] (645.359 µs) : 0, 645
Telemetry [baseline] (7.768 ms) : 0, 7768
Telemetry [candidate] (8.858 ms) : 0, 8858
IAST [baseline] (21.695 ms) : 0, 21695
IAST [candidate] (21.522 ms) : 0, 21522
section iast
BytebuddyAgent [baseline] (787.877 ms) : 0, 787877
BytebuddyAgent [candidate] (837.418 ms) : 0, 837418
GlobalTracer [baseline] (229.761 ms) : 0, 229761
GlobalTracer [candidate] (229.95 ms) : 0, 229950
AppSec [baseline] (56.44 ms) : 0, 56440
AppSec [candidate] (55.723 ms) : 0, 55723
Debugger [baseline] (5.815 ms) : 0, 5815
Debugger [candidate] (4.15 ms) : 0, 4150
Remote Config [baseline] (579.733 µs) : 0, 580
Remote Config [candidate] (587.15 µs) : 0, 587
Telemetry [baseline] (7.816 ms) : 0, 7816
Telemetry [candidate] (8.712 ms) : 0, 8712
IAST [baseline] (22.995 ms) : 0, 22995
IAST [candidate] (22.841 ms) : 0, 22841
section profiling
BytebuddyAgent [baseline] (661.447 ms) : 0, 661447
BytebuddyAgent [candidate] (709.288 ms) : 0, 709288
GlobalTracer [baseline] (373.671 ms) : 0, 373671
GlobalTracer [candidate] (350.69 ms) : 0, 350690
AppSec [baseline] (54.233 ms) : 0, 54233
AppSec [candidate] (53.521 ms) : 0, 53521
Debugger [baseline] (6.131 ms) : 0, 6131
Debugger [candidate] (4.245 ms) : 0, 4245
Remote Config [baseline] (645.335 µs) : 0, 645
Remote Config [candidate] (700.278 µs) : 0, 700
Telemetry [baseline] (8.134 ms) : 0, 8134
Telemetry [candidate] (8.875 ms) : 0, 8875
ProfilingAgent [baseline] (96.313 ms) : 0, 96313
ProfilingAgent [candidate] (101.739 ms) : 0, 101739
Profiling [baseline] (96.337 ms) : 0, 96337
Profiling [candidate] (101.768 ms) : 0, 101768
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (382.811 µs) : 362, 403
. : milestone, 383,
iast (528.006 µs) : 505, 551
. : milestone, 528,
iast_FULL (738.988 µs) : 716, 762
. : milestone, 739,
iast_GLOBAL (559.482 µs) : 536, 583
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (525.054 µs) : 502, 548
. : milestone, 525,
iast_INACTIVE (463.472 µs) : 441, 486
. : milestone, 463,
iast_TELEMETRY_OFF (515.834 µs) : 493, 539
. : milestone, 516,
tracing (458.569 µs) : 437, 481
. : milestone, 459,
section candidate
no_agent (382.401 µs) : 361, 404
. : milestone, 382,
iast (509.761 µs) : 488, 532
. : milestone, 510,
iast_FULL (732.539 µs) : 711, 754
. : milestone, 733,
iast_GLOBAL (557.567 µs) : 536, 579
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (511.599 µs) : 490, 533
. : milestone, 512,
iast_INACTIVE (465.044 µs) : 444, 486
. : milestone, 465,
iast_TELEMETRY_OFF (497.253 µs) : 475, 519
. : milestone, 497,
tracing (454.971 µs) : 434, 475
. : milestone, 455,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.728 ms) : 1704, 1752
. : milestone, 1728,
appsec_no_iast (1.745 ms) : 1722, 1769
. : milestone, 1745,
code_origins (1.683 ms) : 1656, 1709
. : milestone, 1683,
iast (1.514 ms) : 1489, 1539
. : milestone, 1514,
profiling (1.51 ms) : 1487, 1534
. : milestone, 1510,
tracing (1.494 ms) : 1469, 1518
. : milestone, 1494,
section candidate
no_agent (1.354 ms) : 1335, 1374
. : milestone, 1354,
appsec (1.727 ms) : 1704, 1751
. : milestone, 1727,
appsec_no_iast (1.764 ms) : 1741, 1787
. : milestone, 1764,
code_origins (1.665 ms) : 1638, 1692
. : milestone, 1665,
iast (1.519 ms) : 1495, 1543
. : milestone, 1519,
profiling (1.493 ms) : 1469, 1517
. : milestone, 1493,
tracing (1.519 ms) : 1494, 1544
. : milestone, 1519,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
appsec (15.252 s) : 15252000, 15252000
. : milestone, 15252000,
iast (18.955 s) : 18955000, 18955000
. : milestone, 18955000,
iast_GLOBAL (18.056 s) : 18056000, 18056000
. : milestone, 18056000,
profiling (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
tracing (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
section candidate
no_agent (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
appsec (14.693 s) : 14693000, 14693000
. : milestone, 14693000,
iast (19.094 s) : 19094000, 19094000
. : milestone, 19094000,
iast_GLOBAL (18.118 s) : 18118000, 18118000
. : milestone, 18118000,
profiling (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
tracing (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~175e6e4b57, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.378 ms) : 2331, 2424
. : milestone, 2378,
iast (2.156 ms) : 2097, 2214
. : milestone, 2156,
iast_GLOBAL (2.204 ms) : 2144, 2263
. : milestone, 2204,
profiling (2.003 ms) : 1957, 2050
. : milestone, 2003,
tracing (1.988 ms) : 1943, 2033
. : milestone, 1988,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.385 ms) : 2339, 2431
. : milestone, 2385,
iast (2.156 ms) : 2098, 2215
. : milestone, 2156,
iast_GLOBAL (2.199 ms) : 2140, 2258
. : milestone, 2199,
profiling (2.012 ms) : 1966, 2059
. : milestone, 2012,
tracing (1.98 ms) : 1935, 2025
. : milestone, 1980,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]